[edk2,edk2-platforms,v2,1/2] Readme.md: Update instructions to fetch source

Message ID 1543243935-4242-1-git-send-email-nariman.poushin@linaro.org
State Superseded
Headers show
Series
  • [edk2,edk2-platforms,v2,1/2] Readme.md: Update instructions to fetch source
Related show

Commit Message

Nariman Poushin Nov. 26, 2018, 2:52 p.m.
Openssl is fetched as a git submodule, so make sure git clone --recursive
is specified in the instructions to fetch a full source tree.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Nariman Poushin <nariman.poushin@linaro.org>

---

Changes since v1:

	- Added Contribution Agreement tag

 Readme.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.7.4


_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Leif Lindholm Dec. 11, 2018, 6:32 p.m. | #1
On Mon, Nov 26, 2018 at 02:52:14PM +0000, Nariman Poushin wrote:
> Openssl is fetched as a git submodule, so make sure git clone --recursive

> is specified in the instructions to fetch a full source tree.

> 

> Contributed-under: TianoCore Contribution Agreement 1.1

> Signed-off-by: Nariman Poushin <nariman.poushin@linaro.org>


Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

Pushed as 572a554e1d.

Did you send a v7(?) of 2/2, I haven't seen one?
(No panic if you haven't, just we had some emails going missing
earlier in this thread and I wanted to make sure that wasn't happening
again.)

/
    Leif

> ---

> 

> Changes since v1:

> 

> 	- Added Contribution Agreement tag

> 

>  Readme.md | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/Readme.md b/Readme.md

> index 6ad5953..bb53c6f 100644

> --- a/Readme.md

> +++ b/Readme.md

> @@ -78,7 +78,7 @@ target-specific binutils. These are included with any prepackaged GCC toolchain

>     1. [edk2-non-osi](https://github.com/tianocore/edk2-non-osi) (if building

>        platforms that need it)

>     ```

> -   $ git clone https://github.com/tianocore/edk2.git

> +   $ git clone https://github.com/tianocore/edk2.git --recursive

>     ...

>     $ git clone https://github.com/tianocore/edk2-platforms.git

>     ...

> -- 

> 2.7.4

> 

> 

> _______________________________________________

> edk2-devel mailing list

> edk2-devel@lists.01.org

> https://lists.01.org/mailman/listinfo/edk2-devel

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Nariman Poushin Dec. 12, 2018, 3:19 p.m. | #2
On Tue, 11 Dec 2018 at 18:32, Leif Lindholm <leif.lindholm@linaro.org>
wrote:

> On Mon, Nov 26, 2018 at 02:52:14PM +0000, Nariman Poushin wrote:

> > Openssl is fetched as a git submodule, so make sure git clone --recursive

> > is specified in the instructions to fetch a full source tree.

> >

> > Contributed-under: TianoCore Contribution Agreement 1.1

> > Signed-off-by: Nariman Poushin <nariman.poushin@linaro.org>

>

> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

> Pushed as 572a554e1d.

>

>

Thanks!


> Did you send a v7(?) of 2/2, I haven't seen one?

> (No panic if you haven't, just we had some emails going missing

> earlier in this thread and I wanted to make sure that wasn't happening

> again.)

>

> /

>     Leif

>


No, not yet, I will sort this out soon, have been diverted on other stuff.
No email
chaos, yet!

Thanks
Nariman


>

> > ---

> >

> > Changes since v1:

> >

> >       - Added Contribution Agreement tag

> >

> >  Readme.md | 2 +-

> >  1 file changed, 1 insertion(+), 1 deletion(-)

> >

> > diff --git a/Readme.md b/Readme.md

> > index 6ad5953..bb53c6f 100644

> > --- a/Readme.md

> > +++ b/Readme.md

> > @@ -78,7 +78,7 @@ target-specific binutils. These are included with any

> prepackaged GCC toolchain

> >     1. [edk2-non-osi](https://github.com/tianocore/edk2-non-osi) (if

> building

> >        platforms that need it)

> >     ```

> > -   $ git clone https://github.com/tianocore/edk2.git

> > +   $ git clone https://github.com/tianocore/edk2.git --recursive

> >     ...

> >     $ git clone https://github.com/tianocore/edk2-platforms.git

> >     ...

> > --

> > 2.7.4

> >

> >

> > _______________________________________________

> > edk2-devel mailing list

> > edk2-devel@lists.01.org

> > https://lists.01.org/mailman/listinfo/edk2-devel

>

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patch

diff --git a/Readme.md b/Readme.md
index 6ad5953..bb53c6f 100644
--- a/Readme.md
+++ b/Readme.md
@@ -78,7 +78,7 @@  target-specific binutils. These are included with any prepackaged GCC toolchain
    1. [edk2-non-osi](https://github.com/tianocore/edk2-non-osi) (if building
       platforms that need it)
    ```
-   $ git clone https://github.com/tianocore/edk2.git
+   $ git clone https://github.com/tianocore/edk2.git --recursive
    ...
    $ git clone https://github.com/tianocore/edk2-platforms.git
    ...