diff mbox series

clk: qcom: Fix gpll0_out_main parent

Message ID 20181207053749.24872-1-vkoul@kernel.org
State Superseded
Headers show
Series clk: qcom: Fix gpll0_out_main parent | expand

Commit Message

Vinod Koul Dec. 7, 2018, 5:37 a.m. UTC 
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>


gpll0_out_main parent is cxo so fix it.

Fixes: 652f1813c113 ("clk: qcom: gcc: Add global clock controller driver for QCS404")
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

Signed-off-by: Vinod Koul <vkoul@kernel.org>

---
 drivers/clk/qcom/gcc-qcs404.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.19.2

Comments

Marc Gonzalez Dec. 7, 2018, 8:33 a.m. UTC | #1 
On 07/12/2018 06:37, Vinod Koul wrote:

> From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

> 

> gpll0_out_main parent is cxo so fix it.

> 

> Fixes: 652f1813c113 ("clk: qcom: gcc: Add global clock controller driver for QCS404")

> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

> Signed-off-by: Vinod Koul <vkoul@kernel.org>

> ---

>  drivers/clk/qcom/gcc-qcs404.c | 2 +-


IMO 'qcs404' should be mentioned somewhere in the title, to make it clear
which SoC is being patched.

Regards.
Vinod Koul Dec. 7, 2018, 8:40 a.m. UTC | #2 
On 07-12-18, 09:33, Marc Gonzalez wrote:
> On 07/12/2018 06:37, Vinod Koul wrote:

> 

> > From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

> > 

> > gpll0_out_main parent is cxo so fix it.

> > 

> > Fixes: 652f1813c113 ("clk: qcom: gcc: Add global clock controller driver for QCS404")

> > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

> > Signed-off-by: Vinod Koul <vkoul@kernel.org>

> > ---

> >  drivers/clk/qcom/gcc-qcs404.c | 2 +-

> 

> IMO 'qcs404' should be mentioned somewhere in the title, to make it clear

> which SoC is being patched.


Yes my bad, V2 on the way. Thanks for pointing out.

-- 
~Vinod
diff mbox series

Patch

diff --git a/drivers/clk/qcom/gcc-qcs404.c b/drivers/clk/qcom/gcc-qcs404.c
index ef1b267cb058..64da032bb9ed 100644
--- a/drivers/clk/qcom/gcc-qcs404.c
+++ b/drivers/clk/qcom/gcc-qcs404.c
@@ -297,7 +297,7 @@  static struct clk_alpha_pll gpll0_out_main = {
 		.hw.init = &(struct clk_init_data){
 			.name = "gpll0_out_main",
 			.parent_names = (const char *[])
-					{ "gpll0_sleep_clk_src" },
+					{ "cxo" },
 			.num_parents = 1,
 			.ops = &clk_alpha_pll_ops,
 		},