| Message ID | 20181217131519.8052-1-linus.walleij@linaro.org |
|---|---|
| State | Accepted |
| Commit | a0752e9c3097b2c4fccd618802938e0951038dfa |
| Headers | show |
| Series | memory: omap-gpmc: Get the header of the enum | expand |
* Linus Walleij <linus.walleij@linaro.org> [181217 13:15]: > Commit 21abf103818a > ("gpio: Pass a flag to gpiochip_request_own_desc()") > started to pass an enum gpiod_flags but this file is > not including the header file that defines that enum > and the compiler spits: > > drivers/memory/omap-gpmc.c: In function > 'gpmc_probe_generic_child': > drivers/memory/omap-gpmc.c:2174:9: error: type of formal > parameter 4 is incomplete > 0); > ^ > > Cc: Ladislav Michl <ladis@linux-mips.org> > Cc: Janusz Krzysztofik <jmkrzyszt@gmail.com> > Cc: Tony Lindgren <tony@atomide.com> > Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> > Fixes: 21abf103818a ("gpio: Pass a flag to gpiochip_request_own_desc()") > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > Sorry for my mistakes... No worries: Acked-by: Tony Lindgren <tony@atomide.com>
diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c index b9b4f7058b05..e1d91e64e008 100644 --- a/drivers/memory/omap-gpmc.c +++ b/drivers/memory/omap-gpmc.c @@ -21,6 +21,7 @@ #include <linux/spinlock.h> #include <linux/io.h> #include <linux/gpio/driver.h> +#include <linux/gpio/consumer.h> /* GPIO descriptor enum */ #include <linux/interrupt.h> #include <linux/irqdomain.h> #include <linux/platform_device.h>
Commit 21abf103818a ("gpio: Pass a flag to gpiochip_request_own_desc()") started to pass an enum gpiod_flags but this file is not including the header file that defines that enum and the compiler spits: drivers/memory/omap-gpmc.c: In function 'gpmc_probe_generic_child': drivers/memory/omap-gpmc.c:2174:9: error: type of formal parameter 4 is incomplete 0); ^ Cc: Ladislav Michl <ladis@linux-mips.org> Cc: Janusz Krzysztofik <jmkrzyszt@gmail.com> Cc: Tony Lindgren <tony@atomide.com> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Fixes: 21abf103818a ("gpio: Pass a flag to gpiochip_request_own_desc()") Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- Sorry for my mistakes... --- drivers/memory/omap-gpmc.c | 1 + 1 file changed, 1 insertion(+) -- 2.19.2