| Message ID | 20181220111201.30613-1-ard.biesheuvel@linaro.org |
|---|---|
| State | Accepted |
| Commit | 87b920fe22be94f1ea310b21355817800fb614c2 |
| Headers | show |
| Series | [edk2] MdePkg/Arm/ProcessorBind.h: fix copy/paste error | expand |
On Thu, Dec 20, 2018 at 12:12:01PM +0100, Ard Biesheuvel wrote: > Instead of #defining MAX_ALLOC_ADDRESS to MAX_ADDRESS as intended, > it is #defined to itself, causing all ARM builds to break. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> > --- > > Apologies for the breakage. Please ack asap. > > MdePkg/Include/Arm/ProcessorBind.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MdePkg/Include/Arm/ProcessorBind.h b/MdePkg/Include/Arm/ProcessorBind.h > index 16a61fc7a325..0b7b486125f9 100644 > --- a/MdePkg/Include/Arm/ProcessorBind.h > +++ b/MdePkg/Include/Arm/ProcessorBind.h > @@ -151,7 +151,7 @@ typedef INT32 INTN; > /// > /// Maximum usable address at boot time > /// > -#define MAX_ALLOC_ADDRESS MAX_ALLOC_ADDRESS > +#define MAX_ALLOC_ADDRESS MAX_ADDRESS > > /// > /// Maximum legal ARM INTN and UINTN values. > -- > 2.19.2 > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
On Thu, 20 Dec 2018 at 12:21, Leif Lindholm <leif.lindholm@linaro.org> wrote: > > On Thu, Dec 20, 2018 at 12:12:01PM +0100, Ard Biesheuvel wrote: > > Instead of #defining MAX_ALLOC_ADDRESS to MAX_ADDRESS as intended, > > it is #defined to itself, causing all ARM builds to break. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> > Pushed as 4a1500db2b42..87b920fe22be (with Leif's ack) > > --- > > > > Apologies for the breakage. Please ack asap. > > > > MdePkg/Include/Arm/ProcessorBind.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/MdePkg/Include/Arm/ProcessorBind.h b/MdePkg/Include/Arm/ProcessorBind.h > > index 16a61fc7a325..0b7b486125f9 100644 > > --- a/MdePkg/Include/Arm/ProcessorBind.h > > +++ b/MdePkg/Include/Arm/ProcessorBind.h > > @@ -151,7 +151,7 @@ typedef INT32 INTN; > > /// > > /// Maximum usable address at boot time > > /// > > -#define MAX_ALLOC_ADDRESS MAX_ALLOC_ADDRESS > > +#define MAX_ALLOC_ADDRESS MAX_ADDRESS > > > > /// > > /// Maximum legal ARM INTN and UINTN values. > > -- > > 2.19.2 > > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
diff --git a/MdePkg/Include/Arm/ProcessorBind.h b/MdePkg/Include/Arm/ProcessorBind.h index 16a61fc7a325..0b7b486125f9 100644 --- a/MdePkg/Include/Arm/ProcessorBind.h +++ b/MdePkg/Include/Arm/ProcessorBind.h @@ -151,7 +151,7 @@ typedef INT32 INTN; /// /// Maximum usable address at boot time /// -#define MAX_ALLOC_ADDRESS MAX_ALLOC_ADDRESS +#define MAX_ALLOC_ADDRESS MAX_ADDRESS /// /// Maximum legal ARM INTN and UINTN values.
Instead of #defining MAX_ALLOC_ADDRESS to MAX_ADDRESS as intended, it is #defined to itself, causing all ARM builds to break. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> --- Apologies for the breakage. Please ack asap. MdePkg/Include/Arm/ProcessorBind.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.19.2 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel