[1/1] glsl-es-1.00: sanity.shader_test fragment needs default precision

Message ID 1363804248-11775-1-git-send-email-tom.gall@linaro.org
State Accepted
Commit f0b6f7a34fd82d040d3d1d64eefd27e23573ae32
Headers show

Commit Message

Tom Gall March 20, 2013, 6:30 p.m.
GLSL ES 1.00 spec 4.5.3 page 36:
"The fragment language has no default precision qualifier for
floating point types."

Adding default precision for float in the fragment shader
so this sanity testcase doesn't error out.
mediump is choosen since according to 4.5.2 page 34:
"The fragment language requires any uses of lowp and mediump to
compile without error.  Support for highp is optional."

Signed-off-by: Tom Gall <tom.gall@linaro.org>
---
 tests/spec/glsl-es-1.00/execution/sanity.shader_test |    2 ++
 1 file changed, 2 insertions(+)

Comments

Stuart Abercrombie March 28, 2013, 6:41 p.m. | #1
Reviewed-by: Stuart Abercrombie <sabercrombie@chromium.org>


On Wed, Mar 20, 2013 at 11:30 AM, Tom Gall <tom.gall@linaro.org> wrote:

> GLSL ES 1.00 spec 4.5.3 page 36:
> "The fragment language has no default precision qualifier for
> floating point types."
>
> Adding default precision for float in the fragment shader
> so this sanity testcase doesn't error out.
> mediump is choosen since according to 4.5.2 page 34:
> "The fragment language requires any uses of lowp and mediump to
> compile without error.  Support for highp is optional."
>
> Signed-off-by: Tom Gall <tom.gall@linaro.org>
> ---
>  tests/spec/glsl-es-1.00/execution/sanity.shader_test |    2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/tests/spec/glsl-es-1.00/execution/sanity.shader_test
> b/tests/spec/glsl-es-1.00/execution/sanity.shader_test
> index 0884e2c..5461167 100644
> --- a/tests/spec/glsl-es-1.00/execution/sanity.shader_test
> +++ b/tests/spec/glsl-es-1.00/execution/sanity.shader_test
> @@ -12,6 +12,8 @@ void main() {
>  }
>
>  [fragment shader]
> +precision mediump float;
> +
>  uniform vec4 u_color;
>
>  void main() {
> --
> 1.7.10.4
>
> _______________________________________________
> Piglit mailing list
> Piglit@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/piglit
>
Chad Versace April 10, 2013, 1:31 a.m. | #2
On 03/20/2013 11:30 AM, Tom Gall wrote:
> GLSL ES 1.00 spec 4.5.3 page 36:
> "The fragment language has no default precision qualifier for
> floating point types."
>
> Adding default precision for float in the fragment shader
> so this sanity testcase doesn't error out.
> mediump is choosen since according to 4.5.2 page 34:
> "The fragment language requires any uses of lowp and mediump to
> compile without error.  Support for highp is optional."
>
> Signed-off-by: Tom Gall <tom.gall@linaro.org>
> ---
>   tests/spec/glsl-es-1.00/execution/sanity.shader_test |    2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/tests/spec/glsl-es-1.00/execution/sanity.shader_test b/tests/spec/glsl-es-1.00/execution/sanity.shader_test
> index 0884e2c..5461167 100644
> --- a/tests/spec/glsl-es-1.00/execution/sanity.shader_test
> +++ b/tests/spec/glsl-es-1.00/execution/sanity.shader_test
> @@ -12,6 +12,8 @@ void main() {
>   }
>
>   [fragment shader]
> +precision mediump float;
> +
>   uniform vec4 u_color;
>
>   void main() {
>

Thanks, committed to master.

Patch

diff --git a/tests/spec/glsl-es-1.00/execution/sanity.shader_test b/tests/spec/glsl-es-1.00/execution/sanity.shader_test
index 0884e2c..5461167 100644
--- a/tests/spec/glsl-es-1.00/execution/sanity.shader_test
+++ b/tests/spec/glsl-es-1.00/execution/sanity.shader_test
@@ -12,6 +12,8 @@  void main() {
 }
 
 [fragment shader]
+precision mediump float;
+
 uniform vec4 u_color;
 
 void main() {