| Message ID | 20190102091729.18582-4-vkoul@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | net: Add support for Qualcomm ethqos | expand |
HI Rob, On 11-01-19, 09:01, Rob Herring wrote: > On Wed, Jan 02, 2019 at 02:47:25PM +0530, Vinod Koul wrote: > > Some controllers require that phy delay should be disabled. So add > > If the MAC requires it, then the compatible string should imply this. If > it depends on the PHY, then okay. Thanks for the review, yes this was targeted to PHY. After feedback from Andrew, I have removed this is v2 posted earlier! -- ~Vinod
On 1/11/19 7:01 AM, Rob Herring wrote: > On Wed, Jan 02, 2019 at 02:47:25PM +0530, Vinod Koul wrote: >> Some controllers require that phy delay should be disabled. So add > > If the MAC requires it, then the compatible string should imply this. If > it depends on the PHY, then okay. > >> optional properties rx-disable-delay and tx-disable-delay for it. >> >> Signed-off-by: Vinod Koul <vkoul@kernel.org> >> --- >> Documentation/devicetree/bindings/net/stmmac.txt | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/net/stmmac.txt b/Documentation/devicetree/bindings/net/stmmac.txt >> index cb694062afff..ec18897e22c8 100644 >> --- a/Documentation/devicetree/bindings/net/stmmac.txt >> +++ b/Documentation/devicetree/bindings/net/stmmac.txt >> @@ -74,6 +74,8 @@ Optional properties: >> - snps,mb: mixed-burst >> - snps,rb: rebuild INCRx Burst >> - mdio: with compatible = "snps,dwmac-mdio", create and register mdio bus. >> +- rx-delay-disable: bool, when present disable the rx delay >> +- tx-delay-disable: bool, when present disable the tx delay > > Needs a vendor prefix. Indeed, and it would actually be nicer to allow specifying delays directly in ps units, see: Documentation/devicetree/bindings/net/dwmac-sun8i.txt Documentation/devicetree/bindings/net/mediatek-dwmac.txt for examples. -- Florian
diff --git a/Documentation/devicetree/bindings/net/stmmac.txt b/Documentation/devicetree/bindings/net/stmmac.txt index cb694062afff..ec18897e22c8 100644 --- a/Documentation/devicetree/bindings/net/stmmac.txt +++ b/Documentation/devicetree/bindings/net/stmmac.txt @@ -74,6 +74,8 @@ Optional properties: - snps,mb: mixed-burst - snps,rb: rebuild INCRx Burst - mdio: with compatible = "snps,dwmac-mdio", create and register mdio bus. +- rx-delay-disable: bool, when present disable the rx delay +- tx-delay-disable: bool, when present disable the tx delay - Multiple RX Queues parameters: below the list of all the parameters to configure the multiple RX queues: - snps,rx-queues-to-use: number of RX queues to be used in the driver
Some controllers require that phy delay should be disabled. So add optional properties rx-disable-delay and tx-disable-delay for it. Signed-off-by: Vinod Koul <vkoul@kernel.org> --- Documentation/devicetree/bindings/net/stmmac.txt | 2 ++ 1 file changed, 2 insertions(+) -- 2.20.1