diff mbox series

[v1,4/7] cpufreq: qcom-hw: Move to device_initcall

Message ID f62562bb1f8ffc021a814707e0c74a91d5d0746f.1547078153.git.amit.kucheria@linaro.org
State New
Headers show
Series [v1,1/7] drivers: thermal: of-thermal: Print name of device node with error | expand

Commit Message

Amit Kucheria Jan. 10, 2019, midnight UTC
subsys_initcall causes problems registering the driver as a thermal
cooling device.

If "faster boot" is the main reason for doing subsys_initcall, this
should be handled in the bootloader or another boot constraint
framework.

Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>

---
 drivers/cpufreq/qcom-cpufreq-hw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.17.1

Comments

Viresh Kumar Jan. 10, 2019, 6:44 a.m. UTC | #1
On 10-01-19, 05:30, Amit Kucheria wrote:
> subsys_initcall causes problems registering the driver as a thermal

> cooling device.

> 

> If "faster boot" is the main reason for doing subsys_initcall, this

> should be handled in the bootloader or another boot constraint

> framework.

> 

> Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>

> ---

>  drivers/cpufreq/qcom-cpufreq-hw.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/drivers/cpufreq/qcom-cpufreq-hw.c b/drivers/cpufreq/qcom-cpufreq-hw.c

> index d83939a1b3d4..649dddd72749 100644

> --- a/drivers/cpufreq/qcom-cpufreq-hw.c

> +++ b/drivers/cpufreq/qcom-cpufreq-hw.c

> @@ -296,7 +296,7 @@ static int __init qcom_cpufreq_hw_init(void)

>  {

>  	return platform_driver_register(&qcom_cpufreq_hw_driver);

>  }

> -subsys_initcall(qcom_cpufreq_hw_init);

> +device_initcall(qcom_cpufreq_hw_init);

>  

>  static void __exit qcom_cpufreq_hw_exit(void)

>  {


Applied. Thanks.

-- 
viresh
diff mbox series

Patch

diff --git a/drivers/cpufreq/qcom-cpufreq-hw.c b/drivers/cpufreq/qcom-cpufreq-hw.c
index d83939a1b3d4..649dddd72749 100644
--- a/drivers/cpufreq/qcom-cpufreq-hw.c
+++ b/drivers/cpufreq/qcom-cpufreq-hw.c
@@ -296,7 +296,7 @@  static int __init qcom_cpufreq_hw_init(void)
 {
 	return platform_driver_register(&qcom_cpufreq_hw_driver);
 }
-subsys_initcall(qcom_cpufreq_hw_init);
+device_initcall(qcom_cpufreq_hw_init);
 
 static void __exit qcom_cpufreq_hw_exit(void)
 {