From patchwork Mon Jan 14 08:24:34 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vincent Guittot X-Patchwork-Id: 155412 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp3399153jaa; Mon, 14 Jan 2019 00:24:40 -0800 (PST) X-Google-Smtp-Source: ALg8bN4AoK17a8k6owQviWYlwd5xDGhX1aX3naGqyvXmwY7xnCO36C/cyu0Bxz3z0NJiY8USExPF X-Received: by 2002:a17:902:108a:: with SMTP id c10mr24756861pla.131.1547454280827; Mon, 14 Jan 2019 00:24:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547454280; cv=none; d=google.com; s=arc-20160816; b=zFmWjGjN46L4kdZemMAGzMBXHG5sZBeQkQ+H4KbARQ71roVoxjxJJPC5PZ7iUolKoK YjHsh7E9J5iu/5OIIgFDtYjcAfXhjsLaGfQ+M400g6sU5jRlOSmapHrbIcnYvJbeezQP hfbhzk2fBFWPPenlPsNFY+gYVOwhLzGxEZ9HcO13vxbSgJfnJHNcOb6IjvyhOJpR5sy6 9S04Bytb4yh1gnaAuCCS27w8ySVa0YD8/qdHV9SGGpfW6zKwnW2yZAkfO0uaPoT4Wg+g /PHh6cT38Wdx3uMZg8wX4qi+Kvd30ZsFokvbznxoLLuVE8NDaCbXC05lCoLXoOq4BLLo yROQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=YkPn1xL2oiOArne/N0Ongdrcw7L7vib32IvSe9FF2Fc=; b=AVQmk7ChFTgka9z5fuVn4bKvWete+tBw55FbJboHtKwuFmFJayVlfEYhNPU0KZE35L fTugWPDA7dq9XNewe43nT8sfCIsQRSvLolZheitCGLORXJbmq9lcNEXFYZNRSgSZHwyy Z0uqOvC3yXdrgPJWP4+Vr40WouLj65S9Ly2HAdbw7NyzGAP8Fm85hUG6TsAVjJKS2C8Q AXZ5eiJyjEuBgIUkDW4X066MpYhvbaPYoPq7JqEhWGeHkxwV6nAstkNoVdpwICzTTHIG nLyO63Cx48p0dhDWVXTBwQvx4vSTyWCOsTKZvwV9c/09vHQS+LgRNGBuEeHAxjHhkwUl bDSw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XUtYRSZy; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l129si38026048pfl.284.2019.01.14.00.24.40; Mon, 14 Jan 2019 00:24:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=XUtYRSZy; spf=pass (google.com: best guess record for domain of devicetree-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726518AbfANIYj (ORCPT + 7 others); Mon, 14 Jan 2019 03:24:39 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:52995 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726064AbfANIYj (ORCPT ); Mon, 14 Jan 2019 03:24:39 -0500 Received: by mail-wm1-f66.google.com with SMTP id m1so7917285wml.2 for ; Mon, 14 Jan 2019 00:24:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=YkPn1xL2oiOArne/N0Ongdrcw7L7vib32IvSe9FF2Fc=; b=XUtYRSZy6SQeX2YpwgO/tK6iru2s/vfHaxM8c9QHOhdzWcpDi2pGL3qW8aBP7ah9Un MuC4eVNPZNmZw9euyORY+vlCZh713DQEIloLteThOJHFozL0eUMb25yE7OCAaw1oghqg zpLXVaWmeilM+jNaH9Zq8YsXk/KmFaABuUWDM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=YkPn1xL2oiOArne/N0Ongdrcw7L7vib32IvSe9FF2Fc=; b=jDNBLxJw+ga0fgA/LOUZZY8q6hEsx2oJ1zItC4G91mQWE3MUBO2/Sp4gvJDBm/DaOP yRnry0AxZvH5tgSKtDdI2AF3uUTkX3T1q5kMI/MPgWXqSAVLQQwS4VLN8SyxITW2sjWd iL5aZ2VJJeJR1Q98HCiA/cpX35mwU+W7/+5PJZ7BvDf5F7i4+McQy7rtQUInyqqvCLZm hQ2dz+Yefi9yN+T9OUvKXZx5Qp//MImYPxnom5zW81y7B+wxKCGGqnKAprArgruk+lXO 5UHoY6rSW9Vfb2SRs/6acOXXq13Qi0rfgbRJgfJvkfei51gsSvbRBTbSmrcso5+3rDqf v1eg== X-Gm-Message-State: AJcUukdyAJTaas6jrJWoBhUBO2OgxcTCdZlF9D50qnAHtIP3vCnRXnsW RzOMBaWpsV7z9piocIghwEu+9Q== X-Received: by 2002:a1c:2382:: with SMTP id j124mr10685396wmj.14.1547454277799; Mon, 14 Jan 2019 00:24:37 -0800 (PST) Received: from localhost.localdomain ([2a01:e0a:f:6020:39ec:3900:1e09:314e]) by smtp.gmail.com with ESMTPSA id i192sm28546146wmg.7.2019.01.14.00.24.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 14 Jan 2019 00:24:37 -0800 (PST) From: Vincent Guittot To: xuwei5@hisilicon.com, robh+dt@kernel.org, mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linus.walleij@linaro.org Cc: Vincent Guittot Subject: [PATCH v2] arm64/hisilicon: fix SDcard detection Date: Mon, 14 Jan 2019 09:24:34 +0100 Message-Id: <1547454274-1674-1-git-send-email-vincent.guittot@linaro.org> X-Mailer: git-send-email 2.7.4 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The SDcard detection of hikey960 is active low so cd-inverted is wrong. Instead of adding cd-inverted, we should better set correctly cd-gpios to use GPIO_ACTIVE_LOW. Signed-off-by: Vincent Guittot --- SD card detection was not working on v5.0-rc1 but patch https://marc.info/?l=linux-mmc&m=154637189021211&w=2 makes it work. Nevertheles, latest changes in of_mmc_detection makes possible to have a correct DT config. arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.7.4 Reviewed-by: Linus Walleij diff --git a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts index 71bfe41..dc314e7 100644 --- a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts +++ b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts @@ -665,8 +665,7 @@ sd-uhs-sdr50; sd-uhs-sdr104; disable-wp; - cd-inverted; - cd-gpios = <&gpio25 3 0>; + cd-gpios = <&gpio25 3 GPIO_ACTIVE_LOW>; pinctrl-names = "default"; pinctrl-0 = <&sd_pmx_func &sd_clk_cfg_func