| Message ID | 972fd6c1a222b35159671ca82fb63db1632c3ba3.1548046988.git.baolin.wang@linaro.org |
|---|---|
| State | Accepted |
| Commit | a3f1caeefed0731e64bef39859482e6c9de8f027 |
| Headers | show |
| Series | gpio: sprd: Remove unused irq trigger setting | expand |
On Mon, Jan 21, 2019 at 6:06 AM Baolin Wang <baolin.wang@linaro.org> wrote: > The Spreadtrum PMIC interrupt controller has no registers to set irq > trigger type, since it is always high level trigger. That means the > PMIC EIC controller as a child device of PMIC INTC does not need to > set the trigger type, so remove it. > > Signed-off-by: Baolin Wang <baolin.wang@linaro.org> Patch applied. Yours, Linus Walleij
diff --git a/drivers/gpio/gpio-pmic-eic-sprd.c b/drivers/gpio/gpio-pmic-eic-sprd.c index 29e044f..ac573da 100644 --- a/drivers/gpio/gpio-pmic-eic-sprd.c +++ b/drivers/gpio/gpio-pmic-eic-sprd.c @@ -322,7 +322,6 @@ static int sprd_pmic_eic_probe(struct platform_device *pdev) ret = devm_request_threaded_irq(&pdev->dev, pmic_eic->irq, NULL, sprd_pmic_eic_irq_handler, - IRQF_TRIGGER_LOW | IRQF_ONESHOT | IRQF_NO_SUSPEND, dev_name(&pdev->dev), pmic_eic); if (ret) {
The Spreadtrum PMIC interrupt controller has no registers to set irq trigger type, since it is always high level trigger. That means the PMIC EIC controller as a child device of PMIC INTC does not need to set the trigger type, so remove it. Signed-off-by: Baolin Wang <baolin.wang@linaro.org> --- drivers/gpio/gpio-pmic-eic-sprd.c | 1 - 1 file changed, 1 deletion(-) -- 1.7.9.5