From patchwork Mon Jan 21 15:40:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amit Kucheria X-Patchwork-Id: 156211 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp6514767jaa; Mon, 21 Jan 2019 07:42:40 -0800 (PST) X-Google-Smtp-Source: ALg8bN6SIZGQPW6yvaMbuppXM1UcZmOCF/3l3NS1++vc+sDqZeB6onr7ooMlmzACKb4pw5o3ckRv X-Received: by 2002:a17:902:2969:: with SMTP id g96mr30467480plb.295.1548085360420; Mon, 21 Jan 2019 07:42:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548085360; cv=none; d=google.com; s=arc-20160816; b=qjLuUCeRh09UbpYGKX/BvDoXkwMIGPA65Z+FJ9M5s+E/VHglz5CzdorJho4ozxTSGw ufq+r3ZdYtKCT7VocEWYnZy8TnGeO680Yri+KxsqRnj2Q01+z0C+9jb8wCk4Bz85DEqH RV7DbvbkRfjdLAxu3ScHReGyE7ekoc7oWatciGIKvZYF55wfWeITURFBFMh+XCwllALq KDQuE5KUxB14MVr171Yd0Pd8xw/+7Z6PtlhxK27EbXUs9ioBuRZwP4ehG6yogWoE6p7k LXlBWP9ohRvq5QJZET9KP7wA6TDsNab8zrOMe1/UB2FgKTv6TZ2ARUOC1oGbtFB+sIRP hPsw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=mOHRY9GecvR+zxuWJYSMLBDQ2KcwLpDTRI+yrgkHn2w=; b=VEoHNy5wYuFKOQ73gDrBOb4ljFDkWuSdvWVr8vjXdgoUQFf9Drrapkem7nlHAwr+q2 ZfxZUeZpLJiJVp17z+MY5IVT5oXk/AFwaPt+JEZkGj8K0bFe0gFuCucQxurx0WYN7fpR bp+9SXNs6f1L8peHQ6+WdsGlBFklMHC/APrFN8RV2ZRN+pJdEtPXwP54o/qP7Jls6X0J F7LSTNKgNHaYdmMGb8svelqWNyIn16mvtM8CzoXjnFJnwU+UwF+Nq1rjoA+nSuzgY24R O9F7SiebTi5sxhLn9vj7TTNuoblyzaiTX3DWAh4EFPvC3kxx1m1JMANqxfgJUl8I9TBd kSow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="fR/Gwm5u"; spf=pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c21si12316502plo.165.2019.01.21.07.42.40; Mon, 21 Jan 2019 07:42:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="fR/Gwm5u"; spf=pass (google.com: best guess record for domain of linux-pm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-pm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729864AbfAUPmj (ORCPT + 11 others); Mon, 21 Jan 2019 10:42:39 -0500 Received: from mail-wm1-f68.google.com ([209.85.128.68]:56285 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728807AbfAUPmj (ORCPT ); Mon, 21 Jan 2019 10:42:39 -0500 Received: by mail-wm1-f68.google.com with SMTP id y139so11165454wmc.5 for ; Mon, 21 Jan 2019 07:42:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=mOHRY9GecvR+zxuWJYSMLBDQ2KcwLpDTRI+yrgkHn2w=; b=fR/Gwm5uDyVf8kvr7f/Rw+Or8RDtRiDTXnbpdc5hGFstxhrTrpkL+utGhNw6JbRWJ5 92PsbST9aFJTObXUv5gw86T8+fuD1QF9SgnC1v7qnKqLqyQbUn9K2It1FwHfRSATE4GD /EbNTH+2oc1l8/DiC2tkH6PAlsWStqza59+A4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=mOHRY9GecvR+zxuWJYSMLBDQ2KcwLpDTRI+yrgkHn2w=; b=cePhq7QHj9HrdWmCwDv6m281XohVXEhMb4n8UbbzRz+BWNi4KgAPJSeuQ3Do66FqlB mmZieDXyzBda6EVCN2Z97Jhq9sN2oDnsw81SQRG1qbI+WZtFA/eJy/bP1L2wqneSzQ6o 06Jt+jHW7oTgwVLZpjUQLrNjW27tJKuV2VcfVqegdFlizppIUiLYhCpZuefhRU9zbbEB gV7Fx1gC68rICWAiwMjNZZIWUkLakZC/xjZwT+VuT8c4mppwVVX3JW9OghqCR4agSMbL t2UQZ/VP98YI4/ecc0pjIRRnRXfCnn4BLX8AkVfpmRPj40zAp1fthnixtn4WKG9zFFMW GdHQ== X-Gm-Message-State: AJcUukeT7gk7QLVGZaKubX0GfO7KqCegwG28LvUayn/+COPbSxHTcSnx ZW+/rBS4Ldo79j8BJsulqo+EsA== X-Received: by 2002:a1c:c008:: with SMTP id q8mr22990286wmf.99.1548085357709; Mon, 21 Jan 2019 07:42:37 -0800 (PST) Received: from localhost ([49.248.61.1]) by smtp.gmail.com with ESMTPSA id n127sm57377257wmd.20.2019.01.21.07.42.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 Jan 2019 07:42:37 -0800 (PST) From: Amit Kucheria To: linux-kernel@vger.kernel.org Cc: linux-arm-msm@vger.kernel.org, viresh.kumar@linaro.org, edubezval@gmail.com, swboyd@chromium.org, dianders@chromium.org, mka@chromium.org, Zhang Rui , Daniel Lezcano , linux-pm@vger.kernel.org Subject: [PATCH v2 1/9] thermal: cpu_cooling: Require thermal core to be compiled in Date: Mon, 21 Jan 2019 21:10:26 +0530 Message-Id: <3f3e38e55c2de4b730fd7c6aa30c125f3a6a8704.1548084260.git.amit.kucheria@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: References: In-Reply-To: References: Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org The CPU cooling driver (cpu_cooling.c) allows the platform's cpufreq driver to register as a cooling device and cool down the platform by throttling the CPU frequency. In order to be able to auto-register a cpufreq driver as a cooling device from the cpufreq core, we need access to code inside cpu_cooling.c which, in turn, accesses code inside thermal core. CPU_FREQ is a bool while THERMAL is tristate. In some configurations (e.g. allmodconfig), CONFIG_THERMAL ends up as a module while CONFIG_CPU_FREQ is compiled in. This leads to following error: drivers/cpufreq/cpufreq.o: In function `cpufreq_offline': cpufreq.c:(.text+0x407c): undefined reference to `cpufreq_cooling_unregister' drivers/cpufreq/cpufreq.o: In function `cpufreq_online': cpufreq.c:(.text+0x70c0): undefined reference to `of_cpufreq_cooling_register' Given that platforms using CPU_THERMAL usually want it compiled-in so it is available early in boot, make CPU_THERMAL depend on THERMAL being compiled-in instead of allowing it to be a module. Suggested-by: Rafael J. Wysocki Signed-off-by: Amit Kucheria --- drivers/thermal/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.17.1 diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig index 30323426902e..58bb7d72dc2b 100644 --- a/drivers/thermal/Kconfig +++ b/drivers/thermal/Kconfig @@ -152,6 +152,7 @@ config CPU_THERMAL bool "generic cpu cooling support" depends on CPU_FREQ depends on THERMAL_OF + depends on THERMAL=y help This implements the generic cpu cooling mechanism through frequency reduction. An ACPI version of this already exists