dt-bindings: sdhci-omap: Add properties for using external dma

Message ID 20190122084706.11522-1-zhang.chunyan@linaro.org
State New
Headers show
Series
  • dt-bindings: sdhci-omap: Add properties for using external dma
Related show

Commit Message

Chunyan Zhang Jan. 22, 2019, 8:47 a.m.
sdhci-omap can support both external dma controller via dmaengine
framework as well as ADMA which standard SD host controller
provides.

Signed-off-by: Chunyan Zhang <zhang.chunyan@linaro.org>

Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>

---
 Documentation/devicetree/bindings/mmc/sdhci-omap.txt | 7 +++++++
 1 file changed, 7 insertions(+)

-- 
2.17.1

Comments

Faiz Abbas Jan. 22, 2019, 10:20 a.m. | #1
Hi Chunyan,

+Rob Herring

On 22/01/19 2:17 PM, Chunyan Zhang wrote:
> sdhci-omap can support both external dma controller via dmaengine

> framework as well as ADMA which standard SD host controller

> provides.

> 

> Signed-off-by: Chunyan Zhang <zhang.chunyan@linaro.org>

> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>

> ---


Thanks for fixing this. However, this change should be part of the
series (with a change log and a version number). I will send this as a
part of my series after I get some Acks on the driver patches.

Thanks,
Faiz
Chunyan Zhang Jan. 23, 2019, 2:44 a.m. | #2
On Tue, 22 Jan 2019 at 18:17, Faiz Abbas <faiz_abbas@ti.com> wrote:
>

> Hi Chunyan,

>

> +Rob Herring

>

> On 22/01/19 2:17 PM, Chunyan Zhang wrote:

> > sdhci-omap can support both external dma controller via dmaengine

> > framework as well as ADMA which standard SD host controller

> > provides.

> >

> > Signed-off-by: Chunyan Zhang <zhang.chunyan@linaro.org>

> > Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>

> > ---

>

> Thanks for fixing this. However, this change should be part of the


Right, I actually used "--in-reply-to" with the parameter of
Message-ID of Rob's mail, but it seems not work as I expected that it
was expected a reply to Rob's mail for review.

> series (with a change log and a version number). I will send this as a

> part of my series after I get some Acks on the driver patches.


Ok, thanks.

Chunyan

>

> Thanks,

> Faiz

Patch

diff --git a/Documentation/devicetree/bindings/mmc/sdhci-omap.txt b/Documentation/devicetree/bindings/mmc/sdhci-omap.txt
index 72c4dec7e1db..4485dbceb373 100644
--- a/Documentation/devicetree/bindings/mmc/sdhci-omap.txt
+++ b/Documentation/devicetree/bindings/mmc/sdhci-omap.txt
@@ -14,6 +14,11 @@  Required properties:
 		 "ddr_1_8v-rev11", "ddr_1_8v" or "ddr_3_3v", "hs200_1_8v-rev11",
 		 "hs200_1_8v",
 - pinctrl-<n> : Pinctrl states as described in bindings/pinctrl/pinctrl-bindings.txt
+- dmas:		List of DMA specifiers with the controller specific format as described
+		in the generic DMA client binding. A tx and rx specifier is required.
+- dma-names:	List of DMA request names. These strings correspond 1:1 with the
+		DMA specifiers listed in dmas. The string naming is to be "tx"
+		and "rx" for TX and RX DMA requests, respectively.
 
 Example:
 	mmc1: mmc@4809c000 {
@@ -22,4 +27,6 @@  Example:
 		ti,hwmods = "mmc1";
 		bus-width = <4>;
 		vmmc-supply = <&vmmc>; /* phandle to regulator node */
+		dmas = <&sdma 61 &sdma 62>;
+		dma-names = "tx", "rx";
 	};