| Message ID | 20190125175606.6607-2-sudeep.holla@arm.com |
|---|---|
| State | Accepted |
| Commit | 88c2ccc0539136fd5d012462d2893ab12fa6873d |
| Headers | show |
| Series | [1/4] arm64: dts: juno/fast models: using GIC macros instead of hardcoded values | expand |
On 1/25/19 5:56 PM, Sudeep Holla wrote: > RTSM/FVP vexpress motherboard model MMCI requires dedicated interrupts > for CMD and PIO, which obviously should be expressed as a list. Current > form uses tuple and it works fine since interrupt-cells equal to 1. > > Cc: Liviu Dudau <liviu.dudau@arm.com> > Reported-by: Vladimir Murzin <vladimir.murzin@arm.com> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > --- > arch/arm64/boot/dts/arm/rtsm_ve-motherboard.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/arm/rtsm_ve-motherboard.dtsi b/arch/arm64/boot/dts/arm/rtsm_ve-motherboard.dtsi > index b25f3cbd3da8..102e93744edc 100644 > --- a/arch/arm64/boot/dts/arm/rtsm_ve-motherboard.dtsi > +++ b/arch/arm64/boot/dts/arm/rtsm_ve-motherboard.dtsi > @@ -86,7 +86,7 @@ > mmci@50000 { > compatible = "arm,pl180", "arm,primecell"; > reg = <0x050000 0x1000>; > - interrupts = <9 10>; > + interrupts = <9>, <10>; > cd-gpios = <&v2m_sysreg 0 0>; > wp-gpios = <&v2m_sysreg 1 0>; > max-frequency = <12000000>; > FWIW Reviewed-by: Vladimir Murzin <vladimir.murzin@arm.com>
On Fri, Jan 25, 2019 at 05:56:04PM +0000, Sudeep Holla wrote: > RTSM/FVP vexpress motherboard model MMCI requires dedicated interrupts > for CMD and PIO, which obviously should be expressed as a list. Current > form uses tuple and it works fine since interrupt-cells equal to 1. > > Cc: Liviu Dudau <liviu.dudau@arm.com> For the rest of the series: Acked-by: Liviu Dudau <liviu.dudau@arm.com> Best regards, Liviu > Reported-by: Vladimir Murzin <vladimir.murzin@arm.com> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > --- > arch/arm64/boot/dts/arm/rtsm_ve-motherboard.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/arm/rtsm_ve-motherboard.dtsi b/arch/arm64/boot/dts/arm/rtsm_ve-motherboard.dtsi > index b25f3cbd3da8..102e93744edc 100644 > --- a/arch/arm64/boot/dts/arm/rtsm_ve-motherboard.dtsi > +++ b/arch/arm64/boot/dts/arm/rtsm_ve-motherboard.dtsi > @@ -86,7 +86,7 @@ > mmci@50000 { > compatible = "arm,pl180", "arm,primecell"; > reg = <0x050000 0x1000>; > - interrupts = <9 10>; > + interrupts = <9>, <10>; > cd-gpios = <&v2m_sysreg 0 0>; > wp-gpios = <&v2m_sysreg 1 0>; > max-frequency = <12000000>; > -- > 2.17.1 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯
diff --git a/arch/arm64/boot/dts/arm/rtsm_ve-motherboard.dtsi b/arch/arm64/boot/dts/arm/rtsm_ve-motherboard.dtsi index b25f3cbd3da8..102e93744edc 100644 --- a/arch/arm64/boot/dts/arm/rtsm_ve-motherboard.dtsi +++ b/arch/arm64/boot/dts/arm/rtsm_ve-motherboard.dtsi @@ -86,7 +86,7 @@ mmci@50000 { compatible = "arm,pl180", "arm,primecell"; reg = <0x050000 0x1000>; - interrupts = <9 10>; + interrupts = <9>, <10>; cd-gpios = <&v2m_sysreg 0 0>; wp-gpios = <&v2m_sysreg 1 0>; max-frequency = <12000000>;
RTSM/FVP vexpress motherboard model MMCI requires dedicated interrupts for CMD and PIO, which obviously should be expressed as a list. Current form uses tuple and it works fine since interrupt-cells equal to 1. Cc: Liviu Dudau <liviu.dudau@arm.com> Reported-by: Vladimir Murzin <vladimir.murzin@arm.com> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> --- arch/arm64/boot/dts/arm/rtsm_ve-motherboard.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1