diff mbox series

[v5,1/5] misc: dt-bindings: Add Qualcomm Fastrpc bindings

Message ID 20190201130925.27066-2-srinivas.kandagatla@linaro.org
State Superseded
Headers show
Series [v5,1/5] misc: dt-bindings: Add Qualcomm Fastrpc bindings | expand

Commit Message

Srinivas Kandagatla Feb. 1, 2019, 1:09 p.m. UTC
The FastRPC driver implements an IPC (Inter-Processor Communication)
mechanism that allows for clients to transparently make remote method
invocations across DSP and APPS boundaries. This enables developers
to offload tasks to the DSP and free up the application processor for
other tasks.

Co-developed-by: Thierry Escande <thierry.escande@linaro.org>
Signed-off-by: Thierry Escande <thierry.escande@linaro.org>

Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

Reviewed-by: Rob Herring <robh@kernel.org>

---
 .../devicetree/bindings/misc/qcom,fastrpc.txt | 78 +++++++++++++++++++
 1 file changed, 78 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/misc/qcom,fastrpc.txt

-- 
2.20.1

Comments

Srinivas Kandagatla Feb. 8, 2019, 12:28 p.m. UTC | #1
On 08/02/2019 12:21, Greg KH wrote:
> On Fri, Feb 01, 2019 at 01:09:21PM +0000, Srinivas Kandagatla wrote:

>> The FastRPC driver implements an IPC (Inter-Processor Communication)

>> mechanism that allows for clients to transparently make remote method

>> invocations across DSP and APPS boundaries. This enables developers

>> to offload tasks to the DSP and free up the application processor for

>> other tasks.

>>

>> Co-developed-by: Thierry Escande<thierry.escande@linaro.org>

>> Signed-off-by: Thierry Escande<thierry.escande@linaro.org>

>> Signed-off-by: Srinivas Kandagatla<srinivas.kandagatla@linaro.org>

>> Reviewed-by: Rob Herring<robh@kernel.org>

>> ---

>>   .../devicetree/bindings/misc/qcom,fastrpc.txt | 78 +++++++++++++++++++

>>   1 file changed, 78 insertions(+)

>>   create mode 100644 Documentation/devicetree/bindings/misc/qcom,fastrpc.txt

> What changed from v4?  v2?  v3?

> 

I have done that in cover letter w.r.t previous versions,

Changes since v4(https://patchwork.kernel.org/cover/10779341/) :
- collected acks for DT from Rob.
- Removed unnecessary list safe iteration spotted by Greg KH.
- Removed unnecessary syslog spams.
- Added more checks to input validity.


> That needs to be somewhere in here, below the --- line or in the 00

> email at the least to give us some idea of what is different.

> 

> v6 please?

Sure, I can send v6 with full change log from RFC in cover letter along 
with some minor fixes.


thanks,
srini
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/misc/qcom,fastrpc.txt b/Documentation/devicetree/bindings/misc/qcom,fastrpc.txt
new file mode 100644
index 000000000000..2a1827ab50d2
--- /dev/null
+++ b/Documentation/devicetree/bindings/misc/qcom,fastrpc.txt
@@ -0,0 +1,78 @@ 
+Qualcomm Technologies, Inc. FastRPC Driver
+
+The FastRPC implements an IPC (Inter-Processor Communication)
+mechanism that allows for clients to transparently make remote method
+invocations across DSP and APPS boundaries. This enables developers
+to offload tasks to the DSP and free up the application processor for
+other tasks.
+
+- compatible:
+	Usage: required
+	Value type: <stringlist>
+	Definition: must be "qcom,fastrpc"
+
+- label
+	Usage: required
+	Value type: <string>
+	Definition: should specify the dsp domain name this fastrpc
+	corresponds to. must be one of this: "adsp", "mdsp", "sdsp", "cdsp"
+
+- #address-cells
+	Usage: required
+	Value type: <u32>
+	Definition: Must be 1
+
+- #size-cells
+	Usage: required
+	Value type: <u32>
+	Definition: Must be 0
+
+= COMPUTE BANKS
+Each subnode of the Fastrpc represents compute context banks available
+on the dsp.
+- All Compute context banks MUST contain the following properties:
+
+- compatible:
+	Usage: required
+	Value type: <stringlist>
+	Definition: must be "qcom,fastrpc-compute-cb"
+
+- reg
+	Usage: required
+	Value type: <u32>
+	Definition: Context Bank ID.
+
+- qcom,nsessions:
+	Usage: Optional
+	Value type: <u32>
+	Defination: A value indicating how many sessions can share this
+		    context bank. Defaults to 1 when this property
+		    is not specified.
+
+Example:
+
+adsp-pil {
+	compatible = "qcom,msm8996-adsp-pil";
+	...
+	smd-edge {
+		label = "lpass";
+		fastrpc {
+			compatible = "qcom,fastrpc";
+			qcom,smd-channels = "fastrpcsmd-apps-dsp";
+			label = "adsp";
+			#address-cells = <1>;
+			#size-cells = <0>;
+
+			cb@1 {
+				compatible = "qcom,fastrpc-compute-cb";
+				reg = <1>;
+			};
+
+			cb@2 {
+				compatible = "qcom,fastrpc-compute-cb";
+				reg = <2>;
+			};
+			...
+		};
+	};
+};