From patchwork Sun Mar 31 14:31:47 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 15786 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id B602723E33 for ; Sun, 31 Mar 2013 14:32:44 +0000 (UTC) Received: from mail-vc0-f174.google.com (mail-vc0-f174.google.com [209.85.220.174]) by fiordland.canonical.com (Postfix) with ESMTP id 740B3A194C9 for ; Sun, 31 Mar 2013 14:32:44 +0000 (UTC) Received: by mail-vc0-f174.google.com with SMTP id hx10so1662998vcb.19 for ; Sun, 31 Mar 2013 07:32:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:x-forwarded-to:x-forwarded-for:delivered-to:x-received :received-spf:x-received:from:to:cc:subject:date:message-id:x-mailer :in-reply-to:references:in-reply-to:references:x-gm-message-state; bh=tbArIdST0tEnhUK4AcKAPS+PQMcrq5DZl1x6J28siHM=; b=hJgbK/iaSFPvBtztTik8pE0uU4v74pcio+9uOBqFMG0Uejy97pElVMELrfg7Lyb1uZ 7RBjvdbYg5kH9HD2Xo/vAsSRKN5SFzr18KGLHaQEYg+IvSC19N7tIuJfFUK3Om11ySNx GyYTdq/biKoVMd2CQ1X3DpYbgLg2zYULfKKKlA8gH4eVhgYxqD1UaQ8Nly2cD+lW0GBZ IhDDl2sbC3mMbKqkVo2L0i3APdEKdt7WsoUM9p/fiFAi7LdgDQt9kXn9BQYHTQnu3vYq cerxDEgxMHlp6PL7L51BK31GnmTHgHV054zODTsb2B9LpaPdsxkB4Cm2VIuk3kic29WO KQBA== X-Received: by 10.52.233.225 with SMTP id tz1mr5939921vdc.54.1364740364000; Sun, 31 Mar 2013 07:32:44 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.59.4.204 with SMTP id cg12csp51862ved; Sun, 31 Mar 2013 07:32:43 -0700 (PDT) X-Received: by 10.68.220.230 with SMTP id pz6mr13756387pbc.46.1364740363109; Sun, 31 Mar 2013 07:32:43 -0700 (PDT) Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com [209.85.220.51]) by mx.google.com with ESMTPS id aj10si10072600pbd.315.2013.03.31.07.32.42 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 31 Mar 2013 07:32:43 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.51 is neither permitted nor denied by best guess record for domain of viresh.kumar@linaro.org) client-ip=209.85.220.51; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.51 is neither permitted nor denied by best guess record for domain of viresh.kumar@linaro.org) smtp.mail=viresh.kumar@linaro.org Received: by mail-pa0-f51.google.com with SMTP id jh10so944159pab.24 for ; Sun, 31 Mar 2013 07:32:42 -0700 (PDT) X-Received: by 10.68.232.72 with SMTP id tm8mr13570548pbc.108.1364740362745; Sun, 31 Mar 2013 07:32:42 -0700 (PDT) Received: from localhost ([122.167.73.68]) by mx.google.com with ESMTPS id ky10sm11366192pab.23.2013.03.31.07.32.36 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 31 Mar 2013 07:32:42 -0700 (PDT) From: Viresh Kumar To: tj@kernel.org Cc: linaro-kernel@lists.linaro.org, patches@linaro.org, robin.randhawa@arm.com, Steve.Bannister@arm.com, Liviu.Dudau@arm.com, charles.garcia-tobin@arm.com, arvind.chauhan@arm.com, davem@davemloft.net, airlied@redhat.com, axboe@kernel.dk, tglx@linutronix.de, peterz@infradead.org, mingo@redhat.com, rostedt@goodmis.org, linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org, Viresh Kumar , linux-fbdev@vger.kernel.org Subject: [PATCH V4 4/4] fbcon: queue work on unbound wq Date: Sun, 31 Mar 2013 20:01:47 +0530 Message-Id: <2a30b6c081a7899fbce88bddf20b94c348eb4654.1364740180.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 1.7.12.rc2.18.g61b472e In-Reply-To: References: In-Reply-To: References: X-Gm-Message-State: ALoCoQl/to0jzj8ITqZKldP9cmsqAUQJJD4wDdHRd0yEu4MAjdZ2VDX0fTgrm/mWB5v3oA9MIDP6 fbcon uses workqueues and it has no real dependency of scheduling these on the cpu which scheduled them. On a idle system, it is observed that and idle cpu wakes up many times just to service this work. It would be better if we can schedule it on a cpu which the scheduler believes to be the most appropriate one. This patch replaces system_wq with system_unbound_wq. Cc: Dave Airlie Cc: linux-fbdev@vger.kernel.org Signed-off-by: Viresh Kumar --- drivers/video/console/fbcon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c index 3cd6759..6c1f7c3 100644 --- a/drivers/video/console/fbcon.c +++ b/drivers/video/console/fbcon.c @@ -404,7 +404,7 @@ static void cursor_timer_handler(unsigned long dev_addr) struct fb_info *info = (struct fb_info *) dev_addr; struct fbcon_ops *ops = info->fbcon_par; - schedule_work(&info->queue); + queue_work(system_unbound_wq, &info->queue); mod_timer(&ops->cursor_timer, jiffies + HZ/5); }