| Message ID | 20190219145214.3811804-1-arnd@arndb.de |
|---|---|
| State | Accepted |
| Commit | f1685af78cc8d31a5563f2944de0936eb6923f4b |
| Headers | show |
| Series | ARM: pxa: remove CONFIG_SND_PXA2XX_AC97 in pxa_defconfig | expand |
Arnd Bergmann <arnd@arndb.de> writes: > The CONFIG_SND_PXA2XX_AC97 driver is for the old AC97 bus implementation, > and conflicts with all the new-style AC97 drivers after the conversion, > so the drivers we want all get turned off. > > Not disabling the symbol however does the right thing, and we get > the drivers that are selectively enabled here. > > Fixes: 25540f68c871 ("ASoC: pxa: change ac97 dependencies") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Yes, most certainly. Acked-by: Robert Jarzmik <robert.jarzmik@free.fr> Cheers. -- Robert
On Wed, Feb 27, 2019 at 11:01 PM Robert Jarzmik <robert.jarzmik@free.fr> wrote: > > Arnd Bergmann <arnd@arndb.de> writes: > > > The CONFIG_SND_PXA2XX_AC97 driver is for the old AC97 bus implementation, > > and conflicts with all the new-style AC97 drivers after the conversion, > > so the drivers we want all get turned off. > > > > Not disabling the symbol however does the right thing, and we get > > the drivers that are selectively enabled here. > > > > Fixes: 25540f68c871 ("ASoC: pxa: change ac97 dependencies") > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Yes, most certainly. > > Acked-by: Robert Jarzmik <robert.jarzmik@free.fr> Applied to arm/defconfig for 5.1 now, thanks for taking a look Arnd
diff --git a/arch/arm/configs/pxa_defconfig b/arch/arm/configs/pxa_defconfig index 6bb506edb1f5..7f0f1fda2584 100644 --- a/arch/arm/configs/pxa_defconfig +++ b/arch/arm/configs/pxa_defconfig @@ -482,7 +482,6 @@ CONFIG_SND_PCM_OSS=m CONFIG_SND_DYNAMIC_MINORS=y CONFIG_SND_VERBOSE_PRINTK=y CONFIG_SND_DEBUG=y -CONFIG_SND_PXA2XX_AC97=m CONFIG_SND_USB_AUDIO=m CONFIG_SND_SOC=m CONFIG_SND_ATMEL_SOC=m
The CONFIG_SND_PXA2XX_AC97 driver is for the old AC97 bus implementation, and conflicts with all the new-style AC97 drivers after the conversion, so the drivers we want all get turned off. Not disabling the symbol however does the right thing, and we get the drivers that are selectively enabled here. Fixes: 25540f68c871 ("ASoC: pxa: change ac97 dependencies") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- arch/arm/configs/pxa_defconfig | 1 - 1 file changed, 1 deletion(-) -- 2.20.0