| Message ID | 20190304200918.1444050-1-arnd@arndb.de |
|---|---|
| State | Accepted |
| Commit | deb63b0b812f0ef6c37484f23ee3de4b115f7bb2 |
| Headers | show |
| Series | [1/3] x86: apuv2: remove unused variable | expand |
On Mon, Mar 4, 2019 at 9:09 PM Arnd Bergmann <arnd@arndb.de> wrote: > The driver was newly introduced but the version that got merged > produces a harmless compiler warning: > > drivers/platform/x86/pcengines-apuv2.c: In function 'apu_board_init': > drivers/platform/x86/pcengines-apuv2.c:211:6: error: unused variable 'rc' [-Werror=unused-variable] > > Remove the evidently useless variable. > > Fixes: f8eb0235f659 ("x86: pcengines apuv2 gpio/leds/keys platform driver") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> As Torvalds did not yet pull the GPIO tree (maybe because of this and other bugs, who knows) I applied this to my GPIO tree for now. Yours, Linus Walleij
On 08.03.19 10:11, Linus Walleij wrote: > As Torvalds did not yet pull the GPIO tree (maybe because of this > and other bugs, who knows) I applied this to my GPIO tree for > now. Great. I actually like it better this way, so his pull will be clean and consistent. Did you also apply the kconfig fixes ? --mtx -- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering info@metux.net -- +49-151-27565287
On Fri, Mar 8, 2019 at 11:42 AM Enrico Weigelt, metux IT consult <lkml@metux.net> wrote: > On 08.03.19 10:11, Linus Walleij wrote: > > > As Torvalds did not yet pull the GPIO tree (maybe because of this > > and other bugs, who knows) I applied this to my GPIO tree for > > now. > > Great. I actually like it better this way, so his pull will be clean > and consistent. > > Did you also apply the kconfig fixes ? Yep! Yours, Linus Walleij
diff --git a/drivers/platform/x86/pcengines-apuv2.c b/drivers/platform/x86/pcengines-apuv2.c index dcb084f6b892..c1ca931e1fab 100644 --- a/drivers/platform/x86/pcengines-apuv2.c +++ b/drivers/platform/x86/pcengines-apuv2.c @@ -208,7 +208,6 @@ static struct platform_device * __init apu_create_pdev( static int __init apu_board_init(void) { - int rc; const struct dmi_system_id *id; id = dmi_first_match(apu_gpio_dmi_table);
The driver was newly introduced but the version that got merged produces a harmless compiler warning: drivers/platform/x86/pcengines-apuv2.c: In function 'apu_board_init': drivers/platform/x86/pcengines-apuv2.c:211:6: error: unused variable 'rc' [-Werror=unused-variable] Remove the evidently useless variable. Fixes: f8eb0235f659 ("x86: pcengines apuv2 gpio/leds/keys platform driver") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/platform/x86/pcengines-apuv2.c | 1 - 1 file changed, 1 deletion(-) -- 2.20.0