| Message ID | 20190305132332.3788205-1-arnd@arndb.de |
|---|---|
| State | Accepted |
| Commit | 6685d515157c7d00461f0d0e77fe172d03817c87 |
| Headers | show |
| Series | media: i2c: adv748x: select V4L2_FWNODE | expand |
Hi Arnd, Thank you for the patch. On Tue, Mar 05, 2019 at 02:23:13PM +0100, Arnd Bergmann wrote: > Building adv748x fails now unless V4L2_FWNODE is selected: > > drivers/media/i2c/adv748x/adv748x-core.o: In function `adv748x_probe': > adv748x-core.c:(.text+0x1b2c): undefined reference to `v4l2_fwnode_endpoint_parse' > > Fixes: 6a18865da8e3 ("media: i2c: adv748x: store number of CSI-2 lanes described in device tree") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/media/i2c/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig > index 6d32f8dcf83b..3f5dd80e14f8 100644 > --- a/drivers/media/i2c/Kconfig > +++ b/drivers/media/i2c/Kconfig > @@ -221,6 +221,7 @@ config VIDEO_ADV748X > depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API > depends on OF > select REGMAP_I2C > + select V4L2_FWNODE > ---help--- > V4L2 subdevice driver for the Analog Devices > ADV7481 and ADV7482 HDMI/Analog video decoders. -- Regards, Laurent Pinchart
Hi Arnd, Thanks for your work. On 2019-03-05 14:23:13 +0100, Arnd Bergmann wrote: > Building adv748x fails now unless V4L2_FWNODE is selected: > > drivers/media/i2c/adv748x/adv748x-core.o: In function `adv748x_probe': > adv748x-core.c:(.text+0x1b2c): undefined reference to `v4l2_fwnode_endpoint_parse' > > Fixes: 6a18865da8e3 ("media: i2c: adv748x: store number of CSI-2 lanes described in device tree") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> > --- > drivers/media/i2c/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig > index 6d32f8dcf83b..3f5dd80e14f8 100644 > --- a/drivers/media/i2c/Kconfig > +++ b/drivers/media/i2c/Kconfig > @@ -221,6 +221,7 @@ config VIDEO_ADV748X > depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API > depends on OF > select REGMAP_I2C > + select V4L2_FWNODE > ---help--- > V4L2 subdevice driver for the Analog Devices > ADV7481 and ADV7482 HDMI/Analog video decoders. > -- > 2.20.0 > -- Regards, Niklas Söderlund
diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig index 6d32f8dcf83b..3f5dd80e14f8 100644 --- a/drivers/media/i2c/Kconfig +++ b/drivers/media/i2c/Kconfig @@ -221,6 +221,7 @@ config VIDEO_ADV748X depends on VIDEO_V4L2 && I2C && VIDEO_V4L2_SUBDEV_API depends on OF select REGMAP_I2C + select V4L2_FWNODE ---help--- V4L2 subdevice driver for the Analog Devices ADV7481 and ADV7482 HDMI/Analog video decoders.
Building adv748x fails now unless V4L2_FWNODE is selected: drivers/media/i2c/adv748x/adv748x-core.o: In function `adv748x_probe': adv748x-core.c:(.text+0x1b2c): undefined reference to `v4l2_fwnode_endpoint_parse' Fixes: 6a18865da8e3 ("media: i2c: adv748x: store number of CSI-2 lanes described in device tree") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/media/i2c/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.20.0