From patchwork Thu Mar 7 03:05:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Aisheng Dong X-Patchwork-Id: 159786 Delivered-To: patch@linaro.org Received: by 2002:a02:5cc1:0:0:0:0:0 with SMTP id w62csp6933456jad; Wed, 6 Mar 2019 19:06:21 -0800 (PST) X-Google-Smtp-Source: APXvYqx3FsqSSAwF3ELAl67Y+ODigKSOhFl49ekfWWWygGw6FCiRTG1gwMCg/6uuJ8w9WUNfPq3L X-Received: by 2002:a62:1342:: with SMTP id b63mr10474236pfj.7.1551927981173; Wed, 06 Mar 2019 19:06:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551927981; cv=none; d=google.com; s=arc-20160816; b=JJ7GCZoWDmcCD7J0qCOQP1+Jeogwi+GV6GAMpIRFMXM02lZgPT57IWNj/M8WzpOIUp X2FhwiuglahzQ5slL0Cic3xarUlkfPgrO3RbC4oclsi7noa0SZysL4aCXmilGeE71SAU x3VdCSROaLvvO67QZyAOEnySqNxC0/zRQ+6stbTR0WbXofj7Jf2OumY+vXlxeYmS6kO+ jaEyFCHdepDwhoCqXKoZQO/9a8NIVvcYmX95iVZChLJDnKZ/gX70yVPyVn3e7Y/eMg0a lrhdiSB/u8Nmh+7ov1/RZCS/zj7wj8wzbL095e8d5lHkRcpOSAC+Y17yInnpHgTJWybh +EDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :content-language:accept-language:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature; bh=FiP2ezLpK6XSAsSiO5xQTjX6RmA2nf5oesAjR+S+NHg=; b=li01Axab8oGLk+AfIKLCnGjWdQYD//U4U7TT3dn+EOzZtvWeMgv16pwB8MpdKO2aCt fU3xKEl/naGahOARQVvbffJPUCoCEVcgCBks7fyO3JkmhTII+WLERfPPFv4a9vTZ4ja2 B1qtgcJaWqw0ciO6d6Dhp5VPguI/7NmZ7wlZw11VUOV+RXO3hH0vfrvMMX4fZ+/4umXN FsfjzpIV5mbx7O7IMQkyLWCt9XsH1HxGxzhmdKH3WyBR+0iGxTsZKF87xDvIceGR/tf7 Emi6bU+k07psYRa/IwlC9qcdfrGJpps8zQyc1rmiodAvhdUfNV1SIp//9Sw8R2Lmcyr9 4KUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nxp.com header.s=selector1 header.b=GdYw36Hv; spf=pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z13si2802232pgv.508.2019.03.06.19.06.20; Wed, 06 Mar 2019 19:06:21 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nxp.com header.s=selector1 header.b=GdYw36Hv; spf=pass (google.com: best guess record for domain of linux-gpio-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-gpio-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727517AbfCGDGU (ORCPT + 5 others); Wed, 6 Mar 2019 22:06:20 -0500 Received: from mail-eopbgr80048.outbound.protection.outlook.com ([40.107.8.48]:7237 "EHLO EUR04-VI1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726873AbfCGDGU (ORCPT ); Wed, 6 Mar 2019 22:06:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FiP2ezLpK6XSAsSiO5xQTjX6RmA2nf5oesAjR+S+NHg=; b=GdYw36Hvk2dOh6WEz8kKgPB96zx4N3j8zEYmUkQkNUg0UVk0HldXikEoGybtCGvRk8wUrFJwV8qPuW7PKsLQdSmHvYA/ZHgSy3KQPLfq5WLreelgO81iOlw4pLcQNRMxVqibRAnTRCKFW2HJzJIFz4N8k62WPKPQu3WzXs2mWLA= Received: from AM0PR04MB4211.eurprd04.prod.outlook.com (52.134.92.158) by AM0PR04MB6354.eurprd04.prod.outlook.com (10.255.182.79) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1686.18; Thu, 7 Mar 2019 03:05:30 +0000 Received: from AM0PR04MB4211.eurprd04.prod.outlook.com ([fe80::50ed:d1b5:c043:3b79]) by AM0PR04MB4211.eurprd04.prod.outlook.com ([fe80::50ed:d1b5:c043:3b79%2]) with mapi id 15.20.1686.018; Thu, 7 Mar 2019 03:05:30 +0000 From: Aisheng Dong To: "linux-gpio@vger.kernel.org" CC: "linux-arm-kernel@lists.infradead.org" , "linus.walleij@linaro.org" , "shawnguo@kernel.org" , "stefan@agner.ch" , Aisheng Dong , "dongas86@gmail.com" , dl-linux-imx , "kernel@pengutronix.de" , Fabio Estevam , "arnd@arndb.de" , Anders Roxell Subject: [PATCH 1/1] pinctrl: imx: fix scu link errors Thread-Topic: [PATCH 1/1] pinctrl: imx: fix scu link errors Thread-Index: AQHU1JKfgJI3MldPOkKmW1rMKvamuA== Date: Thu, 7 Mar 2019 03:05:30 +0000 Message-ID: <1551927501-14527-1-git-send-email-aisheng.dong@nxp.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: git-send-email 2.7.4 x-clientproxiedby: HK2PR03CA0044.apcprd03.prod.outlook.com (2603:1096:202:17::14) To AM0PR04MB4211.eurprd04.prod.outlook.com (2603:10a6:208:5b::30) authentication-results: spf=none (sender IP is ) smtp.mailfrom=aisheng.dong@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [119.31.174.66] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 18a354e6-e520-40cf-5f7a-08d6a2a9c1ba x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600127)(711020)(4605104)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM0PR04MB6354; x-ms-traffictypediagnostic: AM0PR04MB6354: x-microsoft-exchange-diagnostics: =?iso-8859-1?q?1=3BAM0PR04MB6354=3B23?= =?iso-8859-1?q?=3AUJa5tLEHyqCN8tKCpbAyi9+znmjHyg5Q5GV0+HYSuAFP6vt8?= =?iso-8859-1?q?EQBbxVWUgwmpS+Q72h5Icg/l+h0zVns+geoV3jZmJzk6y+RxB4U?= =?iso-8859-1?q?iQifMbPP+2o5/GyqwhNn6I538WIynp7yfb+p89AhZjv4jNRe6NM?= =?iso-8859-1?q?FZhReKHRdnQ9EV8m3NlABpMH+bV2B16XyKJ/3NpynbWsKcc5mdn?= =?iso-8859-1?q?SjrSA3aT8EvC5ZINjQeugvcAhmQy/YYQyII7lD2Ha/SV4Xl71jl?= =?iso-8859-1?q?wuIzVAihxuZOJ5uA1Uc8VV5YfihRTJE1jlI17WEib1zc+GlYOU/?= =?iso-8859-1?q?qv4rC7dpug4dFVKgt3ao4riF/c43n07BPsns8e5lF38zWEjcJ4Q?= =?iso-8859-1?q?WuXKKABj/7yXAlrIQEidg1xpsaeutHxc39ibX1QkGuBEOJo+1a1?= =?iso-8859-1?q?dkTFZ9ZSYbGeYKFgL9ps1n2Veoe5y0WzStcRlpVCBLWin9srZUa?= =?iso-8859-1?q?LHNJct20eiEOp10dsKoozJTTVlxhNXPJbvGCVqW68610ABpn3NV?= =?iso-8859-1?q?kdswkgfZ9VL/k+OWCg2usYVxh2IPYs5bhVlvKYSbQ3vUq3EOtCj?= =?iso-8859-1?q?iDvCBFtdwrxLGkmLUerf1N5Pg6lDzhBA6p7vUKqZfG/lQunOtyO?= =?iso-8859-1?q?r5yPZalSiAg2x3fAdBsa7r1qBuqF0cyVZpr8pnED4+2XMSRBCSi?= =?iso-8859-1?q?wK4dwYTzeCwB31tibyQ67zdxxlfpfixzASv9NiHNSDMbP4tEYRz?= =?iso-8859-1?q?kGYbrN9KFnM4s6eMUaREXRH16Ma3ZvXkfjGqAMtZNyavB6ft7xx?= =?iso-8859-1?q?YROJD1lRWzzLEXOiRvVWtkqZmp/ah3HB7U+8msk5TPmJRBF9Y10?= =?iso-8859-1?q?Lbfkv1dT989aPC3yk7kKvgC+NS+uPT7JRGpUO6L7lYzQjgx6tWk?= =?iso-8859-1?q?hidV70+y7MPT4TTw58cPc/cUiwGiUjXFIdQxVuMzgF2CqRlfdp1?= =?iso-8859-1?q?eSuVCaGu1MbIWofiX6aPlvHUDq2eSH/+tG7xoo35RT0VuNm9SNE?= =?iso-8859-1?q?3nEnuX1eGIkBDqsaVvjSziprNeU6q5j5Tizar9Dwpin9Iz0Fbao?= =?iso-8859-1?q?uUGCr/lCZ77Fg42gJgz7h3VYrj9JivZV3wGTwuKmQRdA5QIuaLW?= =?iso-8859-1?q?um3XTOp/8b84LIOs1WdQXvgFneaDF5o88uDThUy45zP8/PrBpQT?= =?iso-8859-1?q?w5fyThnmQri4qD9EvZ+tSOZ3DSHrT4XHMeliimiDTu739KbTFXN?= =?iso-8859-1?q?0uMuN3xx6jfdGnMap26NIOuPUIl3IvNm++aMGmfDZyEkwd?= x-microsoft-antispam-prvs: x-forefront-prvs: 096943F07A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(376002)(136003)(366004)(346002)(39860400002)(199004)(189003)(478600001)(53936002)(186003)(68736007)(7736002)(36756003)(97736004)(386003)(2616005)(8676002)(256004)(105586002)(81166006)(81156014)(6512007)(6506007)(2351001)(6436002)(476003)(106356001)(50226002)(99286004)(71190400001)(71200400001)(5660300002)(25786009)(52116002)(2906002)(44832011)(6486002)(316002)(486006)(26005)(54906003)(6916009)(6116002)(3846002)(86362001)(14454004)(8936002)(305945005)(4326008)(5640700003)(102836004)(2501003)(66066001); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR04MB6354; H:AM0PR04MB4211.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 5cL4AjIURlyN7DHtNlXnfIOnli/6duF2qXVhQswVs70Qt+6dqq2zfOzbRFlRTfuyZmHJzyZEKQR+hdpDYait3XocdTrf4DhylvfC3P1q9oBpg/RtJi5QH6pktesaYeee7s6x6TwzQV7FOcS19GosgDgMwQ6rA5PpXearUm92N1qvm41Ym+RbXdAJBjJpkP00eWcHhiFrR1lJ0ijx8RNE8tOa8AEITx2gU/jnOF0be9NXiKSuIV9upDMW37oZ89OkScZqb3c53LfB0Rt34xHtOroD+8B+YTjLt1kn3ONCS2pcuCeAoo7//O3tXnpmNDSgfYSMBuXSUGVioYwQQDeLDvRnlS8o3PmSK8aMUdQr/4r/966AGD5Fp0KVcF8oTQwi6nyD5xtIOZiaUmAClwU9jdQKKHbv0z53rehwBUGgsOg= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 18a354e6-e520-40cf-5f7a-08d6a2a9c1ba X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Mar 2019 03:05:30.4994 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6354 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org From: Anders Roxell Currently PINCTRL_IMX8QM and PINCTRL_IMX8QXP will select PINCTRL_IMX_SCU. However, PINCTRL_IMX_SCU may not be valid due to it depends on IMX_MBOX. Then we may meet the following link errors: ld: drivers/pinctrl/freescale/pinctrl-scu.o: in function `imx_pinctrl_sc_ipc_init': pinctrl-scu.c:(.text+0x10): undefined reference to `imx_scu_get_handle' ld: pinctrl-scu.c:(.text+0x10): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `imx_scu_get_handle' ld: drivers/pinctrl/freescale/pinctrl-scu.o: in function `imx_pinconf_get_scu': pinctrl-scu.c:(.text+0xa0): undefined reference to `imx_scu_call_rpc' ld: pinctrl-scu.c:(.text+0xa0): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `imx_scu_call_rpc' ld: drivers/pinctrl/freescale/pinctrl-scu.o: in function `imx_pinconf_set_scu': pinctrl-scu.c:(.text+0x1b4): undefined reference to `imx_scu_call_rpc' ld: pinctrl-scu.c:(.text+0x1b4): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `imx_scu_call_rpc' ld: drivers/pinctrl/freescale/pinctrl-imx8qxp.o: in function `imx8qxp_pinctrl_probe': pinctrl-imx8qxp.c:(.text+0x28): undefined reference to `imx_pinctrl_probe' ld: pinctrl-imx8qxp.c:(.text+0x28): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `imx_pinctrl_probe' Rework so that PINCTRL_IMX8QM and PINCTRL_IMX8QXP depends on IMX_SCU as well in case they're wrongly enabled. Suggested-by: Arnd Bergmann Signed-off-by: Anders Roxell Signed-off-by: Dong Aisheng --- drivers/pinctrl/freescale/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.7.4 diff --git a/drivers/pinctrl/freescale/Kconfig b/drivers/pinctrl/freescale/Kconfig index e6dff31..0d83878 100644 --- a/drivers/pinctrl/freescale/Kconfig +++ b/drivers/pinctrl/freescale/Kconfig @@ -138,14 +138,14 @@ config PINCTRL_IMX8MQ config PINCTRL_IMX8QM bool "IMX8QM pinctrl driver" - depends on ARCH_MXC && ARM64 + depends on IMX_SCU && ARCH_MXC && ARM64 select PINCTRL_IMX_SCU help Say Y here to enable the imx8qm pinctrl driver config PINCTRL_IMX8QXP bool "IMX8QXP pinctrl driver" - depends on ARCH_MXC && ARM64 + depends on IMX_SCU && ARCH_MXC && ARM64 select PINCTRL_IMX_SCU help Say Y here to enable the imx8qxp pinctrl driver