| Message ID | 20190320130502.16667-1-rrichter@marvell.com |
|---|---|
| State | New |
| Headers | show |
| Series | efi/arm: Show SMBIOS bank/device location in cper and ghes error logs | expand |
On 20.03.19 13:16:13, Robert Richter wrote: > diff --git a/drivers/firmware/efi/arm-runtime.c b/drivers/firmware/efi/arm-runtime.c > index 4a0dfe4ab829..c250b767030e 100644 > --- a/drivers/firmware/efi/arm-runtime.c > +++ b/drivers/firmware/efi/arm-runtime.c > @@ -162,14 +162,10 @@ void efi_virtmap_unload(void) > static int __init arm_dmi_init(void) > { > /* > - * On arm64/ARM, DMI depends on UEFI, and dmi_scan_machine() needs to > + * On arm64/ARM, DMI depends on UEFI, and dmi_setup() needs to > * be called early because dmi_id_init(), which is an arch_initcall > * itself, depends on dmi_scan_machine() having been called already. > */ > - dmi_scan_machine(); > - dmi_memdev_walk(); > - if (dmi_available) > - dmi_set_dump_stack_arch_desc(); This went wrong in the last stage of a comment rework. A dmi_setup() should be here. Will resubmit. Sorry. -Robert > return 0; > }
diff --git a/drivers/firmware/efi/arm-runtime.c b/drivers/firmware/efi/arm-runtime.c index 0c1af675c338..4a0dfe4ab829 100644 --- a/drivers/firmware/efi/arm-runtime.c +++ b/drivers/firmware/efi/arm-runtime.c @@ -167,6 +167,7 @@ static int __init arm_dmi_init(void) * itself, depends on dmi_scan_machine() having been called already. */ dmi_scan_machine(); + dmi_memdev_walk(); if (dmi_available) dmi_set_dump_stack_arch_desc(); return 0;
Run dmi_memdev_walk() for arch arm* as other archs do. This improves error logging as the memory device handle is translated now to the DIMM entry's name provided by the DMI handle. Before: {1}[Hardware Error]: DIMM location: not present. DMI handle: 0x0038 After: {1}[Hardware Error]: DIMM location: N0 DIMM_A0 Signed-off-by: Marcin Benka <mbenka@marvell.com> Signed-off-by: Robert Richter <rrichter@marvell.com> --- drivers/firmware/efi/arm-runtime.c | 1 + 1 file changed, 1 insertion(+) -- 2.20.1