diff mbox series

[5/6] arm64: dts: qcom: pms405: add spmi regulators

Message ID 20190324163209.17312-6-vkoul@kernel.org
State New
Headers show
Series arm64: dts: qcom: qcs404: ethernet and other updates | expand

Commit Message

Vinod Koul March 24, 2019, 4:32 p.m. UTC
From: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>


The PMS405 sports 5 SMPS and 13 LDO regulators.

Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>

Signed-off-by: Khasim Syed Mohammed <khasim.mohammed@linaro.org>

Signed-off-by: Vinod Koul <vkoul@kernel.org>

---
 arch/arm64/boot/dts/qcom/pms405.dtsi | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

-- 
2.20.1

Comments

Bjorn Andersson March 24, 2019, 4:57 p.m. UTC | #1
On Sun 24 Mar 09:32 PDT 2019, Vinod Koul wrote:

> From: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>

> 

> The PMS405 sports 5 SMPS and 13 LDO regulators.

> 

> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>

> Signed-off-by: Khasim Syed Mohammed <khasim.mohammed@linaro.org>

> Signed-off-by: Vinod Koul <vkoul@kernel.org>

> ---

>  arch/arm64/boot/dts/qcom/pms405.dtsi | 20 ++++++++++++++++++++

>  1 file changed, 20 insertions(+)

> 

> diff --git a/arch/arm64/boot/dts/qcom/pms405.dtsi b/arch/arm64/boot/dts/qcom/pms405.dtsi

> index 1bb836d1e8aa..8da4dee1db9b 100644

> --- a/arch/arm64/boot/dts/qcom/pms405.dtsi

> +++ b/arch/arm64/boot/dts/qcom/pms405.dtsi

> @@ -131,4 +131,24 @@

>  			interrupts = <0x0 0x61 0x1 IRQ_TYPE_NONE>;

>  		};

>  	};

> +

> +	pms405_1: pms405@1 {

> +		compatible = "qcom,spmi-pmic";

> +		reg = <0x1 SPMI_USID>;

> +		#address-cells = <1>;

> +		#size-cells = <0>;

> +

> +		regulators {


Label the regulators node and keep the compatible here.  s3-supply and
pms405_s3 are board specific, so define these in the qcs404-evb.dtsi
instead.

Also double check the EVB schematics for the name of the line coming out
of S3; I would assume vdd_apc or something like that.

Regards,
Bjorn

> +			compatible = "qcom,pms405-regulators";

> +			vdd_s3-supply = <&pms405_s3>;

> +

> +			pms405_s3: s3 {

> +				regulator-always-on;

> +				regulator-boot-on;

> +				regulator-name = "vdd_cpu";

> +				regulator-min-microvolt = <1048000>;

> +				regulator-max-microvolt = <1352000>;

> +			};

> +		};

> +	};

>  };

> -- 

> 2.20.1

>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/pms405.dtsi b/arch/arm64/boot/dts/qcom/pms405.dtsi
index 1bb836d1e8aa..8da4dee1db9b 100644
--- a/arch/arm64/boot/dts/qcom/pms405.dtsi
+++ b/arch/arm64/boot/dts/qcom/pms405.dtsi
@@ -131,4 +131,24 @@ 
 			interrupts = <0x0 0x61 0x1 IRQ_TYPE_NONE>;
 		};
 	};
+
+	pms405_1: pms405@1 {
+		compatible = "qcom,spmi-pmic";
+		reg = <0x1 SPMI_USID>;
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		regulators {
+			compatible = "qcom,pms405-regulators";
+			vdd_s3-supply = <&pms405_s3>;
+
+			pms405_s3: s3 {
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-name = "vdd_cpu";
+				regulator-min-microvolt = <1048000>;
+				regulator-max-microvolt = <1352000>;
+			};
+		};
+	};
 };