From patchwork Tue Mar 26 10:31:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomi Valkeinen X-Patchwork-Id: 161193 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp5039159jan; Tue, 26 Mar 2019 03:33:24 -0700 (PDT) X-Google-Smtp-Source: APXvYqyj10HCFNhW5FjTXfxTaplmHU32IEAGmVsue5aG0rwLL/ShsyKJDRCodzYaUUhC3YSaErg9 X-Received: by 2002:a63:bd42:: with SMTP id d2mr11586609pgp.319.1553596404487; Tue, 26 Mar 2019 03:33:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553596404; cv=none; d=google.com; s=arc-20160816; b=RTMsycULK+rFW+k+mdrjiOUtNG5bTJ5D6XNeE+/8udzVKkR1NAc5QUufaGa2DmfZLl oGk+wvqmUYRh8wzI3E7qSdCR/3XlbQmGSfi2ZvXuQ/YYT+SDllN3pVPp7i3LtS2WOc4M egBx++nNIlu0hsSYq9PpAwv0IzPNCq5Hcdn6tC74WoOXD5r2nUOy4ZKCA3OAg2Pp50o1 VTpehRGJdEZdv86rdLwUOzJ6CKHvOz2lCaVyhVrWksZqd8XeQc0q1laP5NYIKEyV5C41 acYYGl12tlCyF4pkLgpzd1t+CaqCDHShjlI9NNWEABBdEKQDHwDZZtDCKeWSngUzl+My vwpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:cc:list-subscribe :list-help:list-post:list-archive:list-unsubscribe:list-id :precedence:mime-version:references:in-reply-to:message-id:date :subject:to:from:delivered-to; bh=AD75nBhV3txtbuxsRhjTpOUFOEFTJrHZN+VADjTYda0=; b=J+ax0b/SbaiXT11l8zo3qfpC2VHSN4KJW3YI9KIqaBUq6b4JhigaIwtjP6p/IuYg79 2Llbt3LBtPbis56MGBMV9pda5kcv5XhiJQz0ZKhM1tKBuI51WevW4lPjyubtqxDB8WlZ 5iKepc0JuN28oT2EhsVd+E7nDXJMFhBxCAYSw8wf1WfbnfZUEhAo9S2CaJnJIS0W965X No3zdO/LaTBpUu9zhmJ2Ju0T2VXyaU07rtEx+w+uTkXobEwHZ3YV9/iH+vHnEO7c2Spx oSSkreiA1wD7q4TVX16bbDRICezLHlwcT2lQjYJiba5dgk2ADrAdWgJsCyeHoca2GxFZ 3KtA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from gabe.freedesktop.org (gabe.freedesktop.org. [131.252.210.177]) by mx.google.com with ESMTPS id 61si16756172plq.154.2019.03.26.03.33.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 26 Mar 2019 03:33:24 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) client-ip=131.252.210.177; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of dri-devel-bounces@lists.freedesktop.org designates 131.252.210.177 as permitted sender) smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org; dmarc=fail (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0D9736E7F2; Tue, 26 Mar 2019 10:33:22 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) by gabe.freedesktop.org (Postfix) with ESMTPS id 449286E7F0 for ; Tue, 26 Mar 2019 10:33:19 +0000 (UTC) Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id x2QAXGfc044107; Tue, 26 Mar 2019 05:33:16 -0500 Received: from DLEE112.ent.ti.com (dlee112.ent.ti.com [157.170.170.23]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x2QAXGhX022438 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 26 Mar 2019 05:33:16 -0500 Received: from DLEE100.ent.ti.com (157.170.170.30) by DLEE112.ent.ti.com (157.170.170.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Tue, 26 Mar 2019 05:33:16 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Tue, 26 Mar 2019 05:33:15 -0500 Received: from deskari.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id x2QAWN2L071249; Tue, 26 Mar 2019 05:33:13 -0500 From: Tomi Valkeinen To: Andrzej Hajda , Laurent Pinchart , , Lucas Stach , Andrey Gusakov , Philipp Zabel , Andrey Smirnov , Jyri Sarha , Peter Ujfalusi , Benoit Parrot Subject: [PATCHv2 19/22] drm/bridge: tc358767: copy the mode data, instead of storing the pointer Date: Tue, 26 Mar 2019 12:31:43 +0200 Message-ID: <20190326103146.24795-20-tomi.valkeinen@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190326103146.24795-1-tomi.valkeinen@ti.com> References: <20190326103146.24795-1-tomi.valkeinen@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1553596396; bh=Mg8a+Ef+AE8FV7gpcCtx0I5JJgvwtNOCus0ientVzuw=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=i/3rCJbvpgzC8XyfouruE+0+TwLiUXevlr13AkoQ0ewyHiQqGelaU2MWdNm1vRmNH Xyh7wUaGV/F/r3HYuAUlXkSurJPBPRyWTL/WBjZqkVspJE8qScRh3X7E9QcvainV5j jPromiZFPnE1g8WQWdN+4N4JWLS9u/SB8eTYOP8M= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomi Valkeinen Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" In tc_bridge_mode_set callback, we store the pointer to the given drm_display_mode, and use the mode later. Storing a pointer in such a way looks very suspicious to me, and I have observed odd issues where the timings were apparently (at least mostly) zero. Do a copy of the drm_display_mode instead to ensure we don't refer to freed/modified data. Signed-off-by: Tomi Valkeinen --- drivers/gpu/drm/bridge/tc358767.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/bridge/tc358767.c b/drivers/gpu/drm/bridge/tc358767.c index 114d535c296b..8732d5b05453 100644 --- a/drivers/gpu/drm/bridge/tc358767.c +++ b/drivers/gpu/drm/bridge/tc358767.c @@ -205,7 +205,7 @@ struct tc_data { /* display edid */ struct edid *edid; /* current mode */ - const struct drm_display_mode *mode; + struct drm_display_mode mode; u32 rev; u8 assr; @@ -1021,12 +1021,12 @@ static int tc_stream_enable(struct tc_data *tc) /* PXL PLL setup */ if (tc_test_pattern) { ret = tc_pxl_pll_en(tc, clk_get_rate(tc->refclk), - 1000 * tc->mode->clock); + 1000 * tc->mode.clock); if (ret) goto err; } - ret = tc_set_video_mode(tc, tc->mode); + ret = tc_set_video_mode(tc, &tc->mode); if (ret) goto err; @@ -1166,7 +1166,7 @@ static void tc_bridge_mode_set(struct drm_bridge *bridge, { struct tc_data *tc = bridge_to_tc(bridge); - tc->mode = mode; + tc->mode = *mode; } static int tc_connector_get_modes(struct drm_connector *connector)