From patchwork Mon Apr 1 03:27:05 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 161513 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp4874551jan; Sun, 31 Mar 2019 20:27:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqyM5T620A6nlv/GyOVbZtiaE0hnaet7OEqnH25NwnQuomk7bpdRS6qG0Z7Ougx9bfu/v9JQ X-Received: by 2002:a65:5cc8:: with SMTP id b8mr4549753pgt.36.1554089251680; Sun, 31 Mar 2019 20:27:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1554089251; cv=none; d=google.com; s=arc-20160816; b=iA4616A8eYheD2ILInJ6bBnj1cwxkYAYniCqB57WQiCsARXjabxhia1OWg33K9TsOo cfJu73M/I26sQdBJ9eaOVqfEIU2iHC7BYcU/zdN1U5q+KDgqQVvD76PaZWlFdwV/Thqi IkFPVJkljoTY6bTa5MRxasUXUPxckl7nr5zINK7aRLcJDCiHIVoi7gQkFG4fsBkPqGCE KItGoQXzzTopqZEe9HwfY7I7L1K9p1lnfeRjabGbxlR7p2ptRk4ZrBRkHr428/HYwj6k hKqpqU/GzARh4p3ABJJqIbMzrmCck1WK7sc76pYgdI/2aaLM7yo6TQOmY+Oj1V8js3yb LYyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:references:in-reply-to:message-id:date :to:from:dkim-signature:delivered-to; bh=QkkmkS898c+WFxD2eFQzLBVzWt7gVN4kZQ+VXB9rPRI=; b=OpV1h+uB1YKLaqKDnaAb1N5A+1ayYW76XKYY8to1LqeAFX+AFJyecSAnkb+JWR0itW 0yRCikkhG4L3gqfRYY2xsTIfjEoTTLWpTjzlEXKGK9F8Vx8Gq+XuKSsIGTfg16C86LJK oTEUAXvuYIEk+B4X4VoOAkQhQEmgRU0GzjIz41C2IWjpSDUUEtKiBOIv74eTVmq/EtUK EkclrgCuq1S+eMQYWOm/VZwAHDstqtfDdvsQ2we9JwxNA/42zcBJzGB3UdxF5aFyga5k /NBExEhxKq+OXFWppfpdBFmT3PB/pc0R/SYc6/T1I83Yb5/xQLcXKgeHyzc19viRX6Yr rTfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=LgFn0eh1; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from ml01.01.org (ml01.01.org. [2001:19d0:306:5::1]) by mx.google.com with ESMTPS id t15si8071424pgq.235.2019.03.31.20.27.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 31 Mar 2019 20:27:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) client-ip=2001:19d0:306:5::1; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=LgFn0eh1; spf=pass (google.com: best guess record for domain of edk2-devel-bounces@lists.01.org designates 2001:19d0:306:5::1 as permitted sender) smtp.mailfrom=edk2-devel-bounces@lists.01.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from [127.0.0.1] (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 5034E211EDB3A; Sun, 31 Mar 2019 20:27:31 -0700 (PDT) X-Original-To: edk2-devel@lists.01.org Delivered-To: edk2-devel@lists.01.org Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::544; helo=mail-pg1-x544.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 89351211E011B for ; Sun, 31 Mar 2019 20:27:30 -0700 (PDT) Received: by mail-pg1-x544.google.com with SMTP id z9so3996765pgu.10 for ; Sun, 31 Mar 2019 20:27:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=xM4ttDr0FC3tm4+Ki+HNyFrnkjWXEw61mH+nCchvQJs=; b=LgFn0eh1F6hvzDav5jcJfg6zpAaW5cxAATWzWCrV88TCodOMxCjbB1ecP5lLeZAGu/ d1Lsiy6GB0+TUt8PTVKVhJmZxjTqIconrjOrFnEbyZN4DwsAEtWUs7MH+cGdc/cfc2kb dBr4uCqumx9yXbgxxlmbXUeLrRVPjgolg96Ud89P4nz+WdW86Yn/LtpOpjwM+hwcJ+w4 gyv4Kf1sERIEy8zfXlTfKzkbh8FQs1Z//zKtB4Kx5dwYgggCczbY9YVyItm7Gm4p/aA/ 3va0oLxB0XPFktvCttTJMjbJV1EQMtajXmFm6xIl6wKqoPa5ob4ZQKLxJ8KrRqZ1D4uV Eicw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=xM4ttDr0FC3tm4+Ki+HNyFrnkjWXEw61mH+nCchvQJs=; b=OlnOKc8vQAhNZnN81cBx62mOtau7/l6zHeaA6YeTLF1miatvORcV3fn7s5YtTAcJWL rgPiEAYl1z/6mutF1OCsY007HPFwJNh0sHN+qxtbgf2jYg/P4GGkInsiEwKbTJAuAFqt ah9Feb9fsA1WEtJImcpV29O7eRas87x+Wn1snXtLXrL7T9LBhZzRfWKYbizDS7cIRLjS sYfesDYuDBzTNDDL/FzcDWNR7qphuf9LBy9AUNMSE+S6lrPooxc+W2NbnlM4CibkMB1r bvIcbaphd7cWB4amSotDgMwggQxL/l+623khF7K1NfoNz9WuPKuVRR4taZL/EgnrxzjI 5WdQ== X-Gm-Message-State: APjAAAUgdOSC5p5OlcQioleiHQcJeriVWBUlpCBQD4nt3ONsSP5mu155 bmGnXnAyGFTknMsYL/rW+gklDQU2p4Frpw== X-Received: by 2002:a62:4481:: with SMTP id m1mr61366691pfi.253.1554089249722; Sun, 31 Mar 2019 20:27:29 -0700 (PDT) Received: from mba13.imgcgcw.net ([147.50.13.10]) by smtp.gmail.com with ESMTPSA id 16sm12758092pfz.106.2019.03.31.20.27.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 31 Mar 2019 20:27:29 -0700 (PDT) From: Ard Biesheuvel To: edk2-devel@lists.01.org Date: Mon, 1 Apr 2019 10:27:05 +0700 Message-Id: <20190401032709.14787-4-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190401032709.14787-1-ard.biesheuvel@linaro.org> References: <20190401032709.14787-1-ard.biesheuvel@linaro.org> Subject: [edk2] [PATCH v4 3/7] MdeModulePkg/PciBusDxe: dispatch option ROMs for foreign architectures X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ruiyu Ni , Vincent Zimmer , Eric Dong , Jaben Carsey , Brian Richardson , Liming Gao , Michael D Kinney , Star Zeng MIME-Version: 1.0 Errors-To: edk2-devel-bounces@lists.01.org Sender: "edk2-devel" Delete the explicit machine type check for option ROM images, and instead, rely on the LoadImage() boot service to decide whether an option ROM can be dispatched or not. This permits platforms to ship with emulators to execute option ROMs that are not native to the processor architecture. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c | 7 ------- 1 file changed, 7 deletions(-) -- 2.17.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c b/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c index c75ef1a82505..54cf4251cc86 100644 --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c @@ -699,13 +699,6 @@ ProcessOpRomImage ( goto NextImage; } - // - // Skip the EFI PCI Option ROM image if its machine type is not supported - // - if (!EFI_IMAGE_MACHINE_TYPE_SUPPORTED (EfiRomHeader->EfiMachineType)) { - goto NextImage; - } - // // Ignore the EFI PCI Option ROM image if it is an EFI application //