[v3,19/26] compat_ioctl: remove HIDIO translation

Message ID	20190416202701.127745-8-arnd@arndb.de
State	Superseded
Headers	show Delivered-To: patch@linaro.org Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; From: Arnd Bergmann <arnd@arndb.de> To: Alexander Viro <viro@zeniv.linux.org.uk> Cc: linux-fsdevel@vger.kernel.org, y2038@lists.linaro.org, linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de> Subject: [PATCH v3 19/26] compat_ioctl: remove HIDIO translation Date: Tue, 16 Apr 2019 22:25:40 +0200 Message-Id: <20190416202701.127745-8-arnd@arndb.de> In-Reply-To: <20190416202701.127745-1-arnd@arndb.de> References: <20190416202013.4034148-1-arnd@arndb.de> <20190416202701.127745-1-arnd@arndb.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk
Series	compat_ioctl: cleanups \| expand [v3,00/26] compat_ioctl: cleanups [v3,01/26] compat_ioctl: pppoe: fix PPPOEIOCSFWD handling [v3,02/26] compat_ioctl: move simple ppp command handling into driver [v3,03/26] compat_ioctl: avoid unused function warning for do_ioctl [v3,04/26] compat_ioctl: move PPPIOCSCOMPRESS32 to ppp-generic.c [v3,05/26] compat_ioctl: move PPPIOCSPASS32/PPPIOCSACTIVE32 to ppp_generic.c [v3,07/26] compat_ioctl: move rtc handling into rtc-dev.c [v3,08/26] compat_ioctl: add compat_ptr_ioctl() [v3,09/26] compat_ioctl: move drivers to compat_ptr_ioctl [v3,10/26] compat_ioctl: use correct compat_ptr() translation in drivers [v3,12/26] compat_ioctl: move more drivers to compat_ptr_ioctl [v3,13/26] compat_ioctl: move tape handling into drivers [v3,14/26] compat_ioctl: move ATYFB_CLK handling to atyfb driver [v3,15/26] compat_ioctl: move isdn/capi ioctl translation into driver [v3,16/26] compat_ioctl: move rfcomm handlers into driver [v3,17/26] compat_ioctl: move hci_sock handlers into driver [v3,18/26] compat_ioctl: remove HCIUART handling [v3,19/26] compat_ioctl: remove HIDIO translation [v3,20/26] compat_ioctl: remove translation for sound ioctls [v3,21/26] compat_ioctl: remove IGNORE_IOCTL() [v3,22/26] compat_ioctl: remove /dev/random commands [v3,23/26] compat_ioctl: remove joystick ioctl translation [v3,24/26] compat_ioctl: remove PCI ioctl translation [v3,25/26] compat_ioctl: remove /dev/raw ioctl translation [v3,26/26] compat_ioctl: remove last RAID handling code

Message ID

20190416202701.127745-8-arnd@arndb.de

State

Superseded

Headers

Received-SPF: pass (google.com: best guess record for domain of
	linux-kernel-owner@vger.kernel.org designates 209.132.180.67
	as permitted sender) client-ip=209.132.180.67; 
From: Arnd Bergmann <arnd@arndb.de>
To: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org, y2038@lists.linaro.org,
	linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: [PATCH v3 19/26] compat_ioctl: remove HIDIO translation
Date: Tue, 16 Apr 2019 22:25:40 +0200
Message-Id: <20190416202701.127745-8-arnd@arndb.de>
In-Reply-To: <20190416202701.127745-1-arnd@arndb.de>
References: <20190416202013.4034148-1-arnd@arndb.de>
	<20190416202701.127745-1-arnd@arndb.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Series

compat_ioctl: cleanups | expand

Commit Message

Arnd Bergmann April 16, 2019, 8:25 p.m. UTC

The two drivers implementing these both gained proper compat_ioctl()
handlers a long time ago with commits bb6c8d8fa9b5 ("HID: hiddev:
Add 32bit ioctl compatibilty") and ae5e49c79c05 ("HID: hidraw: add
compatibility ioctl() for 32-bit applications."), so the lists in
fs/compat_ioctl.c are no longer used.

It appears that the lists were also incomplete, so the translation
didn't actually work correctly when it was still in use.

Remove them as cleanup.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 fs/compat_ioctl.c | 17 -----------------
 1 file changed, 17 deletions(-)

-- 
2.20.0

diff --git a/fs/compat_ioctl.c b/fs/compat_ioctl.c
index 9e96b8b63578..5d13336e9eaa 100644
--- a/fs/compat_ioctl.c
+++ b/fs/compat_ioctl.c
@@ -581,23 +581,6 @@  COMPATIBLE_IOCTL(PCIIOC_CONTROLLER)
 COMPATIBLE_IOCTL(PCIIOC_MMAP_IS_IO)
 COMPATIBLE_IOCTL(PCIIOC_MMAP_IS_MEM)
 COMPATIBLE_IOCTL(PCIIOC_WRITE_COMBINE)
-/* hiddev */
-COMPATIBLE_IOCTL(HIDIOCGVERSION)
-COMPATIBLE_IOCTL(HIDIOCAPPLICATION)
-COMPATIBLE_IOCTL(HIDIOCGDEVINFO)
-COMPATIBLE_IOCTL(HIDIOCGSTRING)
-COMPATIBLE_IOCTL(HIDIOCINITREPORT)
-COMPATIBLE_IOCTL(HIDIOCGREPORT)
-COMPATIBLE_IOCTL(HIDIOCSREPORT)
-COMPATIBLE_IOCTL(HIDIOCGREPORTINFO)
-COMPATIBLE_IOCTL(HIDIOCGFIELDINFO)
-COMPATIBLE_IOCTL(HIDIOCGUSAGE)
-COMPATIBLE_IOCTL(HIDIOCSUSAGE)
-COMPATIBLE_IOCTL(HIDIOCGUCODE)
-COMPATIBLE_IOCTL(HIDIOCGFLAG)
-COMPATIBLE_IOCTL(HIDIOCSFLAG)
-COMPATIBLE_IOCTL(HIDIOCGCOLLECTIONINDEX)
-COMPATIBLE_IOCTL(HIDIOCGCOLLECTIONINFO)
 /* joystick */
 COMPATIBLE_IOCTL(JSIOCGVERSION)
 COMPATIBLE_IOCTL(JSIOCGAXES)

[v3,19/26] compat_ioctl: remove HIDIO translation

Commit Message

Patch