From patchwork Mon Apr 22 16:49:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 162615 Delivered-To: patch@linaro.org Received: by 2002:a02:c6d8:0:0:0:0:0 with SMTP id r24csp2801485jan; Mon, 22 Apr 2019 09:51:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqw0GEKGAk7VEctFUdPGnY1Uuqw08nfW7VDL3sCPG4RAS7F3UDp4joNlpF99YPOiDndD4oV+ X-Received: by 2002:a25:5b41:: with SMTP id p62mr17207895ybb.322.1555951887047; Mon, 22 Apr 2019 09:51:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1555951887; cv=none; d=google.com; s=arc-20160816; b=yWwqXVdhDNJ5gHE0t/AEmFC0g7DeZAcyc+KTFm3+yKEcRu3u8L/gJNIuO7sE3OoiIB zBADSvuFSJOH/c5x/KQlo2yyiVRkxIcoa8a+LKcNd4/ge06PSorLH4QONj+++4BBtZ6R 0+i3r7UHcVV/vKQIK5jJ0ryGea0915+E7IMHkzAKpX4tVMIrMC4c7gt0SMlxs6BHAJW/ ZteRd91eDv78vLt23iYCcRkVvn7+QyGV4aPZ95u3jnFOxTW/i9FaYwUwPNPmP0Ee4JWP 55LNGn0/bHTxmz1e2MY847vRYltlA53zUjtVwNfSQcUaQkJhgr6XopnpMt3ZnNLgUqiB R/Bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-unsubscribe:list-id :precedence:subject:references:in-reply-to:message-id:date:to:from; bh=tll2TEOPgJsZGJ6yWYRZaeaITHeWVNRp9XBqtywrWQM=; b=MNRIBkiTluIMP8maQ2QeV2cCt0aD1NFe4JJ1jD3YglvIIuDFRxOhHKqBh3vRf2vOn2 fcADN6FUsjdMplHNozgCiowFkwXCSazu94ia3tTE5qP7v8dF9EcaH6ibE3GeRTLz3Pjh sw+M1z3tLvkCc2kpvS4WZb/+xaBNpZrg/Sn2/N6KpOUmZPojuzqLaOWELTcncxaojEPu 8JGCBed9vi/dWmBcN0Oed2e9HttW6ThfEJ9WdTcpDUI/sjhxve9oc7OoDLC2h32nNZ5m f8gPzm7/4cT/WdOQbPC8blAucMdD8OJ4U1NUdnfd8BZ0xQjjKaocuwGlVD3RGvWa+n5s vxWg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org. [192.237.175.120]) by mx.google.com with ESMTPS id 190si6787982ybt.125.2019.04.22.09.51.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 22 Apr 2019 09:51:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hIc8s-0004wZ-Uw; Mon, 22 Apr 2019 16:50:06 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hIc8r-0004pv-V7 for xen-devel@lists.xenproject.org; Mon, 22 Apr 2019 16:50:05 +0000 X-Inumbo-ID: ad9151e3-651e-11e9-92d7-bc764e045a96 Received: from foss.arm.com (unknown [217.140.101.70]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTP id ad9151e3-651e-11e9-92d7-bc764e045a96; Mon, 22 Apr 2019 16:50:04 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 93589374; Mon, 22 Apr 2019 09:50:04 -0700 (PDT) Received: from e108454-lin.cambridge.arm.com (e108454-lin.cambridge.arm.com [10.1.196.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 835A63F557; Mon, 22 Apr 2019 09:50:03 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xenproject.org Date: Mon, 22 Apr 2019 17:49:27 +0100 Message-Id: <20190422164937.21350-11-julien.grall@arm.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190422164937.21350-1-julien.grall@arm.com> References: <20190422164937.21350-1-julien.grall@arm.com> Subject: [Xen-devel] [PATCH 10/20] xen/arm32: head: Correctly report the HW CPU ID X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Oleksandr_Tyshchenko@epam.com, Julien Grall , sstabellini@kernel.org, Andrii_Anisov@epam.com MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" There are no reason to consider the HW CPU ID will be 0 when the processor is part of a uniprocessor system. At best, this will result to conflicting output as the rest of Xen use the value directly read from MPIDR. So remove the zeroing and logic to check if the CPU is part of a uniprocessor system. Signed-off-by: Julien Grall Reviewed-by: Andrii Anisov --- xen/arch/arm/arm32/head.S | 8 -------- 1 file changed, 8 deletions(-) diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S index 9f40face98..d42a13556c 100644 --- a/xen/arch/arm/arm32/head.S +++ b/xen/arch/arm/arm32/head.S @@ -124,16 +124,8 @@ GLOBAL(init_secondary) mov r12, #1 /* r12 := is_secondary_cpu */ common_start: - mov r7, #0 /* r7 := CPU ID. Initialy zero until we - * find that multiprocessor extensions are - * present and the system is SMP */ mrc CP32(r1, MPIDR) - tst r1, #MPIDR_SMP /* Multiprocessor extension supported? */ - beq 1f - tst r1, #MPIDR_UP /* Uniprocessor system? */ - bne 1f bic r7, r1, #(~MPIDR_HWID_MASK) /* Mask out flags to get CPU ID */ -1: /* Non-boot CPUs wait here until __cpu_up is ready for them */ teq r12, #0