| Message ID | 20190423211116.261111-1-ndesaulniers@google.com |
|---|---|
| State | Accepted |
| Commit | 33dda8c32714c1a8f318450af4d1f9f123e2ed24 |
| Headers | show |
| Series | powerpc: vdso: drop unnecessary cc-ldoption | expand |
On Tue, Apr 23, 2019 at 2:11 PM Nick Desaulniers <ndesaulniers@google.com> wrote: > > Towards the goal of removing cc-ldoption, it seems that --hash-style= > was added to binutils 2.17.50.0.2 in 2006. The minimal required version > of binutils for the kernel according to > Documentation/process/changes.rst is 2.20. > > Link: https://gcc.gnu.org/ml/gcc/2007-01/msg01141.html > Cc: clang-built-linux@googlegroups.com > Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com> > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> > --- > arch/powerpc/kernel/vdso32/Makefile | 5 ++--- > arch/powerpc/kernel/vdso64/Makefile | 5 ++--- > 2 files changed, 4 insertions(+), 6 deletions(-) > > diff --git a/arch/powerpc/kernel/vdso32/Makefile b/arch/powerpc/kernel/vdso32/Makefile > index ce199f6e4256..06f54d947057 100644 > --- a/arch/powerpc/kernel/vdso32/Makefile > +++ b/arch/powerpc/kernel/vdso32/Makefile > @@ -26,9 +26,8 @@ GCOV_PROFILE := n > KCOV_INSTRUMENT := n > UBSAN_SANITIZE := n > > -ccflags-y := -shared -fno-common -fno-builtin > -ccflags-y += -nostdlib -Wl,-soname=linux-vdso32.so.1 \ > - $(call cc-ldoption, -Wl$(comma)--hash-style=both) > +ccflags-y := -shared -fno-common -fno-builtin -nostdlib \ > + -Wl,-soname=linux-vdso32.so.1 -Wl,--hash-style=both > asflags-y := -D__VDSO32__ -s > > obj-y += vdso32_wrapper.o > diff --git a/arch/powerpc/kernel/vdso64/Makefile b/arch/powerpc/kernel/vdso64/Makefile > index 28e7d112aa2f..32ebb3522ea1 100644 > --- a/arch/powerpc/kernel/vdso64/Makefile > +++ b/arch/powerpc/kernel/vdso64/Makefile > @@ -12,9 +12,8 @@ GCOV_PROFILE := n > KCOV_INSTRUMENT := n > UBSAN_SANITIZE := n > > -ccflags-y := -shared -fno-common -fno-builtin > -ccflags-y += -nostdlib -Wl,-soname=linux-vdso64.so.1 \ > - $(call cc-ldoption, -Wl$(comma)--hash-style=both) > +ccflags-y := -shared -fno-common -fno-builtin -nostdlib \ > + -Wl,-soname=linux-vdso64.so.1 -Wl,--hash-style=both > asflags-y := -D__VDSO64__ -s > > obj-y += vdso64_wrapper.o > -- > 2.21.0.593.g511ec345e18-goog > bumping for review -- Thanks, ~Nick Desaulniers
Nick Desaulniers's on May 1, 2019 6:25 am: > On Tue, Apr 23, 2019 at 2:11 PM Nick Desaulniers > <ndesaulniers@google.com> wrote: >> >> Towards the goal of removing cc-ldoption, it seems that --hash-style= >> was added to binutils 2.17.50.0.2 in 2006. The minimal required version >> of binutils for the kernel according to >> Documentation/process/changes.rst is 2.20. >> >> Link: https://gcc.gnu.org/ml/gcc/2007-01/msg01141.html >> Cc: clang-built-linux@googlegroups.com >> Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com> >> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> >> --- >> arch/powerpc/kernel/vdso32/Makefile | 5 ++--- >> arch/powerpc/kernel/vdso64/Makefile | 5 ++--- >> 2 files changed, 4 insertions(+), 6 deletions(-) >> >> diff --git a/arch/powerpc/kernel/vdso32/Makefile b/arch/powerpc/kernel/vdso32/Makefile >> index ce199f6e4256..06f54d947057 100644 >> --- a/arch/powerpc/kernel/vdso32/Makefile >> +++ b/arch/powerpc/kernel/vdso32/Makefile >> @@ -26,9 +26,8 @@ GCOV_PROFILE := n >> KCOV_INSTRUMENT := n >> UBSAN_SANITIZE := n >> >> -ccflags-y := -shared -fno-common -fno-builtin >> -ccflags-y += -nostdlib -Wl,-soname=linux-vdso32.so.1 \ >> - $(call cc-ldoption, -Wl$(comma)--hash-style=both) >> +ccflags-y := -shared -fno-common -fno-builtin -nostdlib \ >> + -Wl,-soname=linux-vdso32.so.1 -Wl,--hash-style=both >> asflags-y := -D__VDSO32__ -s >> >> obj-y += vdso32_wrapper.o >> diff --git a/arch/powerpc/kernel/vdso64/Makefile b/arch/powerpc/kernel/vdso64/Makefile >> index 28e7d112aa2f..32ebb3522ea1 100644 >> --- a/arch/powerpc/kernel/vdso64/Makefile >> +++ b/arch/powerpc/kernel/vdso64/Makefile >> @@ -12,9 +12,8 @@ GCOV_PROFILE := n >> KCOV_INSTRUMENT := n >> UBSAN_SANITIZE := n >> >> -ccflags-y := -shared -fno-common -fno-builtin >> -ccflags-y += -nostdlib -Wl,-soname=linux-vdso64.so.1 \ >> - $(call cc-ldoption, -Wl$(comma)--hash-style=both) >> +ccflags-y := -shared -fno-common -fno-builtin -nostdlib \ >> + -Wl,-soname=linux-vdso64.so.1 -Wl,--hash-style=both >> asflags-y := -D__VDSO64__ -s >> >> obj-y += vdso64_wrapper.o >> -- >> 2.21.0.593.g511ec345e18-goog >> > > bumping for review This looks like a good cleanup. Reviewed-by: Nicholas Piggin <npiggin@gmail.com>
diff --git a/arch/powerpc/kernel/vdso32/Makefile b/arch/powerpc/kernel/vdso32/Makefile index ce199f6e4256..06f54d947057 100644 --- a/arch/powerpc/kernel/vdso32/Makefile +++ b/arch/powerpc/kernel/vdso32/Makefile @@ -26,9 +26,8 @@ GCOV_PROFILE := n KCOV_INSTRUMENT := n UBSAN_SANITIZE := n -ccflags-y := -shared -fno-common -fno-builtin -ccflags-y += -nostdlib -Wl,-soname=linux-vdso32.so.1 \ - $(call cc-ldoption, -Wl$(comma)--hash-style=both) +ccflags-y := -shared -fno-common -fno-builtin -nostdlib \ + -Wl,-soname=linux-vdso32.so.1 -Wl,--hash-style=both asflags-y := -D__VDSO32__ -s obj-y += vdso32_wrapper.o diff --git a/arch/powerpc/kernel/vdso64/Makefile b/arch/powerpc/kernel/vdso64/Makefile index 28e7d112aa2f..32ebb3522ea1 100644 --- a/arch/powerpc/kernel/vdso64/Makefile +++ b/arch/powerpc/kernel/vdso64/Makefile @@ -12,9 +12,8 @@ GCOV_PROFILE := n KCOV_INSTRUMENT := n UBSAN_SANITIZE := n -ccflags-y := -shared -fno-common -fno-builtin -ccflags-y += -nostdlib -Wl,-soname=linux-vdso64.so.1 \ - $(call cc-ldoption, -Wl$(comma)--hash-style=both) +ccflags-y := -shared -fno-common -fno-builtin -nostdlib \ + -Wl,-soname=linux-vdso64.so.1 -Wl,--hash-style=both asflags-y := -D__VDSO64__ -s obj-y += vdso64_wrapper.o
Towards the goal of removing cc-ldoption, it seems that --hash-style= was added to binutils 2.17.50.0.2 in 2006. The minimal required version of binutils for the kernel according to Documentation/process/changes.rst is 2.20. Link: https://gcc.gnu.org/ml/gcc/2007-01/msg01141.html Cc: clang-built-linux@googlegroups.com Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> --- arch/powerpc/kernel/vdso32/Makefile | 5 ++--- arch/powerpc/kernel/vdso64/Makefile | 5 ++--- 2 files changed, 4 insertions(+), 6 deletions(-) -- 2.21.0.593.g511ec345e18-goog