diff mbox series

ARM: multi_v7_defconfig: Enable panic and disk LED triggers

Message ID 20190502110247.681-1-manivannan.sadhasivam@linaro.org
State New
Headers show
Series ARM: multi_v7_defconfig: Enable panic and disk LED triggers | expand

Commit Message

Manivannan Sadhasivam May 2, 2019, 11:02 a.m. UTC
Most development boards and devices have one or more LEDs. It is
useful during debugging if they can be wired to show different
behaviours such as disk or cpu activity or a load-average dependent
heartbeat. Enable panic and disk activity triggers so they can be tied
to LED activity during debugging as well.

There was a similar patch which added these triggers for ARM64 as well:
https://patchwork.kernel.org/patch/10042681/

Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

---
 arch/arm/configs/multi_v7_defconfig | 2 ++
 1 file changed, 2 insertions(+)

-- 
2.17.1

Comments

Amit Kucheria May 2, 2019, 4:43 p.m. UTC | #1
On Thu, May 2, 2019 at 4:33 PM Manivannan Sadhasivam
<manivannan.sadhasivam@linaro.org> wrote:
>

> Most development boards and devices have one or more LEDs. It is

> useful during debugging if they can be wired to show different

> behaviours such as disk or cpu activity or a load-average dependent

> heartbeat. Enable panic and disk activity triggers so they can be tied

> to LED activity during debugging as well.

>

> There was a similar patch which added these triggers for ARM64 as well:

> https://patchwork.kernel.org/patch/10042681/

>

> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org>


> ---

>  arch/arm/configs/multi_v7_defconfig | 2 ++

>  1 file changed, 2 insertions(+)

>

> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig

> index 2e9fa5312616..466ccc305a05 100644

> --- a/arch/arm/configs/multi_v7_defconfig

> +++ b/arch/arm/configs/multi_v7_defconfig

> @@ -821,6 +821,8 @@ CONFIG_LEDS_TRIGGER_GPIO=y

>  CONFIG_LEDS_TRIGGER_DEFAULT_ON=y

>  CONFIG_LEDS_TRIGGER_TRANSIENT=y

>  CONFIG_LEDS_TRIGGER_CAMERA=y

> +CONFIG_LEDS_TRIGGER_PANIC=y

> +CONFIG_LEDS_TRIGGER_DISK=y

>  CONFIG_EDAC=y

>  CONFIG_EDAC_HIGHBANK_MC=y

>  CONFIG_EDAC_HIGHBANK_L2=y

> --

> 2.17.1

>
diff mbox series

Patch

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 2e9fa5312616..466ccc305a05 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -821,6 +821,8 @@  CONFIG_LEDS_TRIGGER_GPIO=y
 CONFIG_LEDS_TRIGGER_DEFAULT_ON=y
 CONFIG_LEDS_TRIGGER_TRANSIENT=y
 CONFIG_LEDS_TRIGGER_CAMERA=y
+CONFIG_LEDS_TRIGGER_PANIC=y
+CONFIG_LEDS_TRIGGER_DISK=y
 CONFIG_EDAC=y
 CONFIG_EDAC_HIGHBANK_MC=y
 CONFIG_EDAC_HIGHBANK_L2=y