[18/18] arm64: defconfig: enable build of IPA code

Message ID 20190512012508.10608-19-elder@linaro.org
State New
Headers show
Series
  • net: introduce Qualcomm IPA driver
Related show

Commit Message

Alex Elder May 12, 2019, 1:25 a.m.
Add CONFIG_IPA to the 64-bit Arm defconfig.

Signed-off-by: Alex Elder <elder@linaro.org>

---
 arch/arm64/configs/defconfig | 1 +
 1 file changed, 1 insertion(+)

-- 
2.20.1

Comments

Arnd Bergmann May 15, 2019, 8:23 a.m. | #1
On Sun, May 12, 2019 at 3:25 AM Alex Elder <elder@linaro.org> wrote:

> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig

> index 2d9c39033c1a..4f4d803e563d 100644

> --- a/arch/arm64/configs/defconfig

> +++ b/arch/arm64/configs/defconfig

> @@ -268,6 +268,7 @@ CONFIG_SMSC911X=y

>  CONFIG_SNI_AVE=y

>  CONFIG_SNI_NETSEC=y

>  CONFIG_STMMAC_ETH=m

> +CONFIG_IPA=y

>  CONFIG_MDIO_BUS_MUX_MMIOREG=y

>  CONFIG_AT803X_PHY=m

>  CONFIG_MARVELL_PHY=m


Since the device is not needed for booting, please make this
CONFIG_IPA=m instead to keep the kernel image a little smaller.

     Arnd
Alex Elder May 15, 2019, 12:49 p.m. | #2
On 5/15/19 3:23 AM, Arnd Bergmann wrote:
> On Sun, May 12, 2019 at 3:25 AM Alex Elder <elder@linaro.org> wrote:

> 

>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig

>> index 2d9c39033c1a..4f4d803e563d 100644

>> --- a/arch/arm64/configs/defconfig

>> +++ b/arch/arm64/configs/defconfig

>> @@ -268,6 +268,7 @@ CONFIG_SMSC911X=y

>>  CONFIG_SNI_AVE=y

>>  CONFIG_SNI_NETSEC=y

>>  CONFIG_STMMAC_ETH=m

>> +CONFIG_IPA=y

>>  CONFIG_MDIO_BUS_MUX_MMIOREG=y

>>  CONFIG_AT803X_PHY=m

>>  CONFIG_MARVELL_PHY=m

> 

> Since the device is not needed for booting, please make this

> CONFIG_IPA=m instead to keep the kernel image a little smaller.

> 

>      Arnd

> 


Oops, yes, that was my intention but I forgot to fix that
before I sent it out.   This code works as a module, but
in order to make the whole system allow the module to be both
removed and re-inserted safely, I need some work to be done
on the modem end and that's beyond my direct control.  I have
been testing with it as a kernel built-in driver in the mean
time.

In any case, it is my intention to have it be normally built
as a module and I will ensure that when I send out future
revisions of this series.

					-Alex

Patch

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 2d9c39033c1a..4f4d803e563d 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -268,6 +268,7 @@  CONFIG_SMSC911X=y
 CONFIG_SNI_AVE=y
 CONFIG_SNI_NETSEC=y
 CONFIG_STMMAC_ETH=m
+CONFIG_IPA=y
 CONFIG_MDIO_BUS_MUX_MMIOREG=y
 CONFIG_AT803X_PHY=m
 CONFIG_MARVELL_PHY=m