From patchwork Tue May 14 12:21:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 164145 Delivered-To: patch@linaro.org Received: by 2002:a92:9e1a:0:0:0:0:0 with SMTP id q26csp2551992ili; Tue, 14 May 2019 05:23:04 -0700 (PDT) X-Google-Smtp-Source: APXvYqxdU79LU+6fcJHlRvBtgJTJt3U3XqpoPuOyWLYTH0KDQhUC0OZFb/EwUc9ZLZgVi9S3RhuG X-Received: by 2002:a05:660c:404:: with SMTP id c4mr3360895itk.60.1557836584032; Tue, 14 May 2019 05:23:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557836584; cv=none; d=google.com; s=arc-20160816; b=pyfFn+Uz15xo7JvRyHUYeZlVkCeq8eMc5oWjw/FRUTWxT9XZTg/r2scJLspN2L0IRC BjBP0asiKEqYgOAQ39rfompj/cKFiFNk3brNEvFfQzDrrD27D8J+TvSeFi9pEbHkkdyQ AbTy5ZYtCH8q7MZJa2ua29b/FEdFWbilEibLZaUiDflYtOAC9nRO6EPPrKwXepVj0n9q 8fv4ApyTRwdxFpFEJcrvSlFU/98JRH0JjdbqzjqcTxNy2NwDdArvCxMD1BSLDnF4NfK1 7Owfg+WQHTY742q40X6xpjWg62/C6LE7BqAE2Ya38xXoGgbHlp0qZxiKGNcqjIidGU6o g5VQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-unsubscribe:list-id :precedence:subject:references:in-reply-to:message-id:date:to:from; bh=gWiIjnb7FKVA+rv1YIQ9lWA/2IPZtXuIP6zSBI8grJU=; b=Zz0BcLt4AfVfVJppCbznZqSO2xi3TihBwKuf3wAL61Skzqymu3YqddKVENJBLAlTYe UCZCdc/c2OHdkLJ7ju4uRnXg9hG3tcAK7MxuBZXTQpazHlPQpwgtZ3lDNukDgMkXagHW XOVYWk2rlNMPDdUsK3awHIuPiQzL+WFq9/4xoHPPfPjmwLGY8FH+sMVKSTTuy3jD6orL DJJUIIVMz0UsGpLENfHC8fXdBJxkRPl4kpglz8qj1GrgT5g0Zm1TaqDw414tubxrdahu RGr5H5hvPqjTYzpBwF0i4yOxw+hFmadZQ6XWOeiCQYCPYNOBADOZ9S4KqclSPyc7p8LQ Y3rA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org. [192.237.175.120]) by mx.google.com with ESMTPS id n186si9014243iof.2.2019.05.14.05.23.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 14 May 2019 05:23:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hQWRi-00009R-7q; Tue, 14 May 2019 12:22:14 +0000 Received: from us1-rack-dfw2.inumbo.com ([104.130.134.6]) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hQWRf-00005W-Rd for xen-devel@lists.xenproject.org; Tue, 14 May 2019 12:22:11 +0000 X-Inumbo-ID: e591c939-7642-11e9-8980-bc764e045a96 Received: from foss.arm.com (unknown [217.140.101.70]) by us1-rack-dfw2.inumbo.com (Halon) with ESMTP id e591c939-7642-11e9-8980-bc764e045a96; Tue, 14 May 2019 12:22:10 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 338F2341; Tue, 14 May 2019 05:22:10 -0700 (PDT) Received: from e108454-lin.cambridge.arm.com (e108454-lin.cambridge.arm.com [10.1.196.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 009753F71E; Tue, 14 May 2019 05:22:08 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xenproject.org Date: Tue, 14 May 2019 13:21:27 +0100 Message-Id: <20190514122136.28215-19-julien.grall@arm.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190514122136.28215-1-julien.grall@arm.com> References: <20190514122136.28215-1-julien.grall@arm.com> Subject: [Xen-devel] [PATCH MM-PART2 v2 10/19] xen/arm32: head: Correctly report the HW CPU ID X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Oleksandr_Tyshchenko@epam.com, Julien Grall , Stefano Stabellini , Andrii Anisov MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" There are no reason to consider the HW CPU ID will be 0 when the processor is part of a uniprocessor system. At best, this will result to conflicting output as the rest of Xen use the value directly read from MPIDR. So remove the zeroing and logic to check if the CPU is part of a uniprocessor system. Signed-off-by: Julien Grall Reviewed-by: Andrii Anisov --- Changes in v2: - Add Andrii's reviewed-by --- xen/arch/arm/arm32/head.S | 8 -------- 1 file changed, 8 deletions(-) diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S index 9f40face98..d42a13556c 100644 --- a/xen/arch/arm/arm32/head.S +++ b/xen/arch/arm/arm32/head.S @@ -124,16 +124,8 @@ GLOBAL(init_secondary) mov r12, #1 /* r12 := is_secondary_cpu */ common_start: - mov r7, #0 /* r7 := CPU ID. Initialy zero until we - * find that multiprocessor extensions are - * present and the system is SMP */ mrc CP32(r1, MPIDR) - tst r1, #MPIDR_SMP /* Multiprocessor extension supported? */ - beq 1f - tst r1, #MPIDR_UP /* Uniprocessor system? */ - bne 1f bic r7, r1, #(~MPIDR_HWID_MASK) /* Mask out flags to get CPU ID */ -1: /* Non-boot CPUs wait here until __cpu_up is ready for them */ teq r12, #0