| Message ID | 20190521141034.8808-1-vkoul@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | dmaengine: xilinx_dma: Remove set but unused ‘tail_desc’ | expand |
> -----Original Message----- > From: Vinod Koul <vkoul@kernel.org> > Sent: Tuesday, May 21, 2019 7:41 PM > To: dmaengine@vger.kernel.org > Cc: Vinod Koul <vkoul@kernel.org>; Michal Simek <michals@xilinx.com>; > Radhey Shyam Pandey <radheys@xilinx.com>; Andrea Merello > <andrea.merello@gmail.com>; Appana Durga Kedareswara Rao > <appanad@xilinx.com> > Subject: [PATCH] dmaengine: xilinx_dma: Remove set but unused ‘tail_desc’ > > We get a compiler warn about variable ‘tail_desc’ set but not used > > drivers/dma/xilinx/xilinx_dma.c:1102:42: warning: > variable ‘tail_desc’ set but not used [-Wunused-but-set-variable] > struct xilinx_dma_tx_descriptor *desc, *tail_desc; > > So remove it. > > Signed-off-by: Vinod Koul <vkoul@kernel.org> Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com> Thanks! > --- > drivers/dma/xilinx/xilinx_dma.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c > index c43c1a154604..34564224e675 100644 > --- a/drivers/dma/xilinx/xilinx_dma.c > +++ b/drivers/dma/xilinx/xilinx_dma.c > @@ -1099,7 +1099,7 @@ static void xilinx_dma_start(struct xilinx_dma_chan > *chan) > static void xilinx_vdma_start_transfer(struct xilinx_dma_chan *chan) > { > struct xilinx_vdma_config *config = &chan->config; > - struct xilinx_dma_tx_descriptor *desc, *tail_desc; > + struct xilinx_dma_tx_descriptor *desc; > u32 reg, j; > struct xilinx_vdma_tx_segment *segment, *last = NULL; > int i = 0; > @@ -1116,8 +1116,6 @@ static void xilinx_vdma_start_transfer(struct > xilinx_dma_chan *chan) > > desc = list_first_entry(&chan->pending_list, > struct xilinx_dma_tx_descriptor, node); > - tail_desc = list_last_entry(&chan->pending_list, > - struct xilinx_dma_tx_descriptor, node); > > /* Configure the hardware using info in the config structure */ > if (chan->has_vflip) { > -- > 2.20.1
On 21-05-19, 14:20, Radhey Shyam Pandey wrote: > > -----Original Message----- > > From: Vinod Koul <vkoul@kernel.org> > > Sent: Tuesday, May 21, 2019 7:41 PM > > To: dmaengine@vger.kernel.org > > Cc: Vinod Koul <vkoul@kernel.org>; Michal Simek <michals@xilinx.com>; > > Radhey Shyam Pandey <radheys@xilinx.com>; Andrea Merello > > <andrea.merello@gmail.com>; Appana Durga Kedareswara Rao > > <appanad@xilinx.com> > > Subject: [PATCH] dmaengine: xilinx_dma: Remove set but unused ‘tail_desc’ > > > > We get a compiler warn about variable ‘tail_desc’ set but not used > > > > drivers/dma/xilinx/xilinx_dma.c:1102:42: warning: > > variable ‘tail_desc’ set but not used [-Wunused-but-set-variable] > > struct xilinx_dma_tx_descriptor *desc, *tail_desc; > > > > So remove it. > > > > Signed-off-by: Vinod Koul <vkoul@kernel.org> > > Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com> Thanks applied now -- ~Vinod
diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c index c43c1a154604..34564224e675 100644 --- a/drivers/dma/xilinx/xilinx_dma.c +++ b/drivers/dma/xilinx/xilinx_dma.c @@ -1099,7 +1099,7 @@ static void xilinx_dma_start(struct xilinx_dma_chan *chan) static void xilinx_vdma_start_transfer(struct xilinx_dma_chan *chan) { struct xilinx_vdma_config *config = &chan->config; - struct xilinx_dma_tx_descriptor *desc, *tail_desc; + struct xilinx_dma_tx_descriptor *desc; u32 reg, j; struct xilinx_vdma_tx_segment *segment, *last = NULL; int i = 0; @@ -1116,8 +1116,6 @@ static void xilinx_vdma_start_transfer(struct xilinx_dma_chan *chan) desc = list_first_entry(&chan->pending_list, struct xilinx_dma_tx_descriptor, node); - tail_desc = list_last_entry(&chan->pending_list, - struct xilinx_dma_tx_descriptor, node); /* Configure the hardware using info in the config structure */ if (chan->has_vflip) {
We get a compiler warn about variable ‘tail_desc’ set but not used drivers/dma/xilinx/xilinx_dma.c:1102:42: warning: variable ‘tail_desc’ set but not used [-Wunused-but-set-variable] struct xilinx_dma_tx_descriptor *desc, *tail_desc; So remove it. Signed-off-by: Vinod Koul <vkoul@kernel.org> --- drivers/dma/xilinx/xilinx_dma.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- 2.20.1