From patchwork Wed May 22 01:15:02 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chunyan Zhang X-Patchwork-Id: 164759 Delivered-To: patch@linaro.org Received: by 2002:a92:9e1a:0:0:0:0:0 with SMTP id q26csp250632ili; Tue, 21 May 2019 18:15:52 -0700 (PDT) X-Google-Smtp-Source: APXvYqxsJkcqfX7WqAVQP7Xy0x2xQlNfXvV2cOour0qzP+gt7GuhoLIHV5a4lvob/kce9/fY2UCx X-Received: by 2002:a63:d150:: with SMTP id c16mr86378489pgj.439.1558487752498; Tue, 21 May 2019 18:15:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558487752; cv=none; d=google.com; s=arc-20160816; b=g0b4Un/KFcZoQb4p/5J0CrFLeNTbNs24Kl/lAwQvuc45Zq3wlUM5tevl3R3TAw8JCe mQxWNW33MHNUtuQeNikrNKcXawYotqg9p8Gw97XXUzNxZp9nZ2FgztK0qH7gIW3FCj14 qbLFKREUZUcQlCIyeQLba+cvvxbkg3QjWveJXPxQYqn93JDmaB1LQ2/jpBLGMqH2+Y+c L7wjn6owS4qHxzPhdc1m3MWbuKBi3xbOoC0meKmkOtgp2iEKFqS5jWh/kux805u4BcYe Ur80jV2m0QIlPYOUZ+NKkJEPvddy1tT8/aTfGRrYw1aKpgor2LZO1VoeJ+gByQS11QmO Nu8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=6fbG5fDEzG6AzVFaygO2qy/CXt0Isxn5KLkAJO5SWss=; b=QDiTHpX+zjbPg+nnBYSXLGI/UH6pMHzdAE1JdSsijwQn8+2AirH1IcsH7QGOzGUSQZ 4AlM8POPm7oCHqgaAnwfXlGdKZ3A2NnwT590ZqKMAqe1ldEx9J3UwIDE+bkj6nuNc+6J czUxIUuHslhv9lFbbh1r4whc/8D8zH8gf3xv+fDYiYgvTIBHX0k3CNTRiSPyEKTcDAVf HiVmmHC9qlp77PcoIWwpBEYSG/oCvc22rAlk87VvYU9faPnU5rbAVC0HkQxyuqo93L/A N6gMzF/8KjIV5N3dM86m+o4MBX1Mi8DP7rAt2o9sKaGU9yB+78mftUytR9TpEaGUWKmq p3/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="jfN/IPbd"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k22si23835121pls.290.2019.05.21.18.15.52; Tue, 21 May 2019 18:15:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="jfN/IPbd"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728259AbfEVBPt (ORCPT + 30 others); Tue, 21 May 2019 21:15:49 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:39470 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728207AbfEVBPs (ORCPT ); Tue, 21 May 2019 21:15:48 -0400 Received: by mail-pf1-f195.google.com with SMTP id z26so376573pfg.6 for ; Tue, 21 May 2019 18:15:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6fbG5fDEzG6AzVFaygO2qy/CXt0Isxn5KLkAJO5SWss=; b=jfN/IPbdiNMb5JRj2CnP/eCgdcf+GAIPN3VeuSPPh8A3Z/LLdTYhT+cSzxiZC5unq3 yZIl3VixybtlbHWsvdnbH922uzO1jUHnvWVjH4WoMf5Nk5C6X0YK8xbiwVkV4I3V2aJR JDqFc4zZoFum0ETZzckdxYA4ywVQmSifOeoHSz9OicminnX2tLgKTK3LSTkClyKWvOJY kAks3r64S0qPczI3NGUDqwbXSehZSaosHHmtgE+rbGmlMcdPfdX8IKr2kL2jGYjFFU+u CHpc7PATBAtA8AMfyylhide8JfBbCzqDn+AnT+Wwgq5PiASu07b5d0gBpPzTiTdOUAOt Pf6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6fbG5fDEzG6AzVFaygO2qy/CXt0Isxn5KLkAJO5SWss=; b=Hjt/k0waSrlL/zoKyCmahcEd63JxjuhKq5xm85decNluQLwVjVGnlDKyTJuIZgz0v/ CK93tl5n/bjaIfWhkp+swkSrfxRaoFiob78mzV5UnTQ5imNK46nOZx9XyrkLHSwlpwL5 haaCi1D06Yo6/D4xhp1ZT2U95jbrbkfgRI4cSgKDbMZT5LosF4xOZrjLOFVZea5cm0wx SXPF4xqzUVb+K9F3zF/7tMS4r78jc8u4DaB/1bZ+zBqtUCXTM0fWCpnlKRFTabnxfFJb lsXvQpyaOL4qYJAgibRTbWGK7GFyWpgOrfGyvvMIbVVkA6M4XTA3S5iGTz6hx3VgbfAb 0QOg== X-Gm-Message-State: APjAAAV8rKC1sgCoVPPIO2f87cgtvhL+VIywVX+ADFPbfBuybIavxjMF TRLxAMYCY5SuBIIyxEkMaAmiBg== X-Received: by 2002:a63:1f04:: with SMTP id f4mr87297936pgf.423.1558487747679; Tue, 21 May 2019 18:15:47 -0700 (PDT) Received: from ubt.spreadtrum.com ([117.18.48.82]) by smtp.gmail.com with ESMTPSA id e184sm31756061pfa.169.2019.05.21.18.15.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 21 May 2019 18:15:47 -0700 (PDT) From: Chunyan Zhang To: Stephen Boyd Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Orson Zhai , Chunyan Zhang , Baolin Wang Subject: [PATCH v2 2/3] clk: sprd: Check error only for devm_regmap_init_mmio() Date: Wed, 22 May 2019 09:15:02 +0800 Message-Id: <20190522011504.19342-3-zhang.chunyan@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190522011504.19342-1-zhang.chunyan@linaro.org> References: <20190522011504.19342-1-zhang.chunyan@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function devm_regmap_init_mmio() wouldn't return NULL pointer for now, so only need to ensure the return value is not an error code. Signed-off-by: Chunyan Zhang --- drivers/clk/sprd/common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1 Reviewed-by: Baolin Wang diff --git a/drivers/clk/sprd/common.c b/drivers/clk/sprd/common.c index 9ce690999eaa..a5bdca1de5d0 100644 --- a/drivers/clk/sprd/common.c +++ b/drivers/clk/sprd/common.c @@ -58,7 +58,7 @@ int sprd_clk_regmap_init(struct platform_device *pdev, regmap = devm_regmap_init_mmio(&pdev->dev, base, &sprdclk_regmap_config); - if (IS_ERR_OR_NULL(regmap)) { + if (IS_ERR(regmap)) { pr_err("failed to init regmap\n"); return PTR_ERR(regmap); }