From patchwork Mon May 27 20:55:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Lezcano X-Patchwork-Id: 165226 Delivered-To: patch@linaro.org Received: by 2002:a92:9e1a:0:0:0:0:0 with SMTP id q26csp7616590ili; Mon, 27 May 2019 13:55:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqzINY9aLe1FM2pmPTfSL2Se7uDc571EIzxi8zBTJ7alWIQAMo7icFVXs6n3pnnGcWxkeWUD X-Received: by 2002:a17:90a:be0b:: with SMTP id a11mr860961pjs.88.1558990555278; Mon, 27 May 2019 13:55:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1558990555; cv=none; d=google.com; s=arc-20160816; b=t9CNdX4L9Bfwga1LXyeRSCUUfIa82CrjDBw6wRJxsHo/VfTMkZQkPMDMpRhHe3j+4x ge97dhLtWbkc36/i9qik8qniMyHwqEwniPAmLNWhRFNNmZDU7526/MtPG/U7aIQvm5lo yD6DoQi9esTKYDS98iNLNS4Cw7mmJy+W1bFQSZ5j7Ga1AgiEADIrcIdWlFajqsLU6akz X/K86qzF3eqAhu0MD5EESQx3bnVIz54rjlZwe/ejgG4S4SQ8bldqdoTCKkR+DsqDl7oO yEEixz5VeHZu5o9bkyjnzaySShB+2JvWwQuNdg5Qyj2qL+zZy+3sc23AYGCHrn0+rIir iVjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=q6ZhvfBGbl+6q1sQb52SrU1ERF5WJa7s4b+iAbTaZGw=; b=nXHSlWVwwZL+YGtQPwyMYGJewkvXOLu23G4ked8bt9S4dMT3RKtlXloWaZIPYNcQ9m XuAeTgu/cQDkxwsqHrCuXA0obBdM369nkRzmWYgc23fbKT1i8oka+kZkMzm1PQ14ozbX aCtcutHYJjG/RcFlsN3lMCP/cAE9qNMTDtpiUCO+ijYIePxZRLReNgy6cHtxV41Fp7at XOFlF4BAZqVizutpmJRZNws5pVNhKfXwwKG+JmtHPN+/HzsJqzFN0Fu89POGSQKROFE1 yu9hoKrjwJjCAK3IGx5npAFJ27EJsD9SmImFpx/3nXggZWD7EZmPyk+q28GUS5V1oKxx b7hg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ajP3I39P; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l27si17850333pgm.172.2019.05.27.13.55.54; Mon, 27 May 2019 13:55:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ajP3I39P; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727364AbfE0Uzv (ORCPT + 30 others); Mon, 27 May 2019 16:55:51 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:39454 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727298AbfE0Uzq (ORCPT ); Mon, 27 May 2019 16:55:46 -0400 Received: by mail-wr1-f66.google.com with SMTP id e2so9189084wrv.6 for ; Mon, 27 May 2019 13:55:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=q6ZhvfBGbl+6q1sQb52SrU1ERF5WJa7s4b+iAbTaZGw=; b=ajP3I39Puo+dxnCTFyLhawYAzrXoh5nwu6fXrQNgJH/tlhYbHwYcsyAQudHZJKB2I7 +G7y9/LeTb8SFvTP0SZ7RQeLDs1lX34oTsxuB7/ytrN/mKEPcelK6iNTUQnacS9rAwmz 7XZBY7quoXZRrLw8QcAR+6g1htYZKkiqllAXNj7kA1ZbHurIe1KDN/4NMR7xXbG7dV5B vs4HdwqM7xaIrPesWIuvUVh7gRDLSnX14AGsTDBrjAczicTDfitLTFMwYmLs44BSHuQH v18eb3XeA4mCJXuxc5UBRAYwWUkaOyUHQI/s/tkOjrXiyDocLWP9MsBZPvD1s0IKt38x XW5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=q6ZhvfBGbl+6q1sQb52SrU1ERF5WJa7s4b+iAbTaZGw=; b=E/YJscFZuewGRGUO/SyAmZ/28j3NkYszGJuZSnNCspFHT4941eZcCChYj+WdBH+0lb Ld7g/QHheEKo/5e8058C0H8RnTQfiXl3pePaNQwTmH65XTR2B1aWRepmJJcjWSpgq8Gr Ne5l5jBylMAfP2ZPJJaM+VFDzD2+y8uUvJoxGad5ykPT043nqCnjAzsjb6sQOoimscn/ el5CKbv/Vpzp2Ix7PXoBZFvj4DeYaTTHWvOIV1ZBNPdoOr95Ahwc6mQeGXsug0r8MCX5 uAtllZIzvJiT2oh6N8KjwQ4Uben4K+KMAxHFCR0l8NEE7vJYAXGQHxoYOkmtGp+2Ye7g xfCw== X-Gm-Message-State: APjAAAV86Jav/7jb9JZKdgyiyrjH2ZEIW16AwgGUFHX7ZlEiEmgP4iLs MpOUvY/PX7Pogx8I9pPLnBlmzWzLW2Y= X-Received: by 2002:a5d:49d0:: with SMTP id t16mr13357007wrs.324.1558990544988; Mon, 27 May 2019 13:55:44 -0700 (PDT) Received: from clegane.local (30.94.129.77.rev.sfr.net. [77.129.94.30]) by smtp.gmail.com with ESMTPSA id a1sm388565wmj.23.2019.05.27.13.55.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 May 2019 13:55:44 -0700 (PDT) From: Daniel Lezcano To: tglx@linutronix.de Cc: linux-kernel@vger.kernel.org, andriy.shevchenko@linux.intel.com Subject: [PATCH V3 3/8] genirq/timings: Optimize the period detection speed Date: Mon, 27 May 2019 22:55:16 +0200 Message-Id: <20190527205521.12091-4-daniel.lezcano@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190527205521.12091-1-daniel.lezcano@linaro.org> References: <20190527205521.12091-1-daniel.lezcano@linaro.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If we have a minimal period and if there is a period which is a multiple of it but lesser than the max period then it will be detected before and the minimal period will be never reached. 1 2 1 2 1 2 1 2 1 2 1 2 <-----> <-----> <-----> <-> <-> <-> <-> <-> <-> In our case, the minimum period is 2 and the maximum period is 5. That means all repeating pattern of 2 will be detected as repeating pattern of 4, it is pointless to go up to 2 when searching for the period as it will always fail. Remove one loop iteration by increasing the minimal period to 3. Signed-off-by: Daniel Lezcano --- kernel/irq/timings.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1 diff --git a/kernel/irq/timings.c b/kernel/irq/timings.c index 19d2fad379ee..1d1c411d4cae 100644 --- a/kernel/irq/timings.c +++ b/kernel/irq/timings.c @@ -261,7 +261,7 @@ void irq_timings_disable(void) #define EMA_ALPHA_VAL 64 #define EMA_ALPHA_SHIFT 7 -#define PREDICTION_PERIOD_MIN 2 +#define PREDICTION_PERIOD_MIN 3 #define PREDICTION_PERIOD_MAX 5 #define PREDICTION_FACTOR 4 #define PREDICTION_MAX 10 /* 2 ^ PREDICTION_MAX useconds */