diff mbox series

[RFC,32/57] drivers: s390-crypto: Use class_device_find_by_name() helper

Message ID 1559577023-558-33-git-send-email-suzuki.poulose@arm.com
State New
Headers show
Series [RFC,01/57] drivers: s390/cio: Use driver_for_each_device | expand

Commit Message

Suzuki K Poulose June 3, 2019, 3:49 p.m. UTC 
Use the new class_find_device_by_name() helper.

Cc: Harald Freudenberger <freude@linux.ibm.com>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>

---
 drivers/s390/crypto/zcrypt_api.c | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)

-- 
2.7.4

Comments

Harald Freudenberger June 4, 2019, 6:45 a.m. UTC | #1 
On 03.06.19 17:49, Suzuki K Poulose wrote:
> Use the new class_find_device_by_name() helper.

>

> Cc: Harald Freudenberger <freude@linux.ibm.com>

> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>

> Cc: Heiko Carstens <heiko.carstens@de.ibm.com>

> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>

> ---

>  drivers/s390/crypto/zcrypt_api.c | 12 ++----------

>  1 file changed, 2 insertions(+), 10 deletions(-)

>

> diff --git a/drivers/s390/crypto/zcrypt_api.c b/drivers/s390/crypto/zcrypt_api.c

> index 1058b4b..16cad8e 100644

> --- a/drivers/s390/crypto/zcrypt_api.c

> +++ b/drivers/s390/crypto/zcrypt_api.c

> @@ -133,12 +133,6 @@ struct zcdn_device {

>  static int zcdn_create(const char *name);

>  static int zcdn_destroy(const char *name);

>  

> -/* helper function, matches the name for find_zcdndev_by_name() */

> -static int __match_zcdn_name(struct device *dev, const void *data)

> -{

> -	return strcmp(dev_name(dev), (const char *)data) == 0;

> -}

> -

>  /* helper function, matches the devt value for find_zcdndev_by_devt() */

>  static int __match_zcdn_devt(struct device *dev, const void *data)

>  {

> @@ -152,10 +146,8 @@ static int __match_zcdn_devt(struct device *dev, const void *data)

>   */

>  static inline struct zcdn_device *find_zcdndev_by_name(const char *name)

>  {

> -	struct device *dev =

> -		class_find_device(zcrypt_class, NULL,

> -				  (void *) name,

> -				  __match_zcdn_name);

> +	struct device *dev = class_find_device_by_name(zcrypt_class,

> +							NULL, (void *) name);

>  

>  	return dev ? to_zcdn_dev(dev) : NULL;

>  }

fine with me, thanks
acked-by: Harald Freudenberger <freude@linux.ibm.com>
diff mbox series

Patch

diff --git a/drivers/s390/crypto/zcrypt_api.c b/drivers/s390/crypto/zcrypt_api.c
index 1058b4b..16cad8e 100644
--- a/drivers/s390/crypto/zcrypt_api.c
+++ b/drivers/s390/crypto/zcrypt_api.c
@@ -133,12 +133,6 @@  struct zcdn_device {
 static int zcdn_create(const char *name);
 static int zcdn_destroy(const char *name);
 
-/* helper function, matches the name for find_zcdndev_by_name() */
-static int __match_zcdn_name(struct device *dev, const void *data)
-{
-	return strcmp(dev_name(dev), (const char *)data) == 0;
-}
-
 /* helper function, matches the devt value for find_zcdndev_by_devt() */
 static int __match_zcdn_devt(struct device *dev, const void *data)
 {
@@ -152,10 +146,8 @@  static int __match_zcdn_devt(struct device *dev, const void *data)
  */
 static inline struct zcdn_device *find_zcdndev_by_name(const char *name)
 {
-	struct device *dev =
-		class_find_device(zcrypt_class, NULL,
-				  (void *) name,
-				  __match_zcdn_name);
+	struct device *dev = class_find_device_by_name(zcrypt_class,
+							NULL, (void *) name);
 
 	return dev ? to_zcdn_dev(dev) : NULL;
 }