| Message ID | 1559577023-558-38-git-send-email-suzuki.poulose@arm.com |
|---|---|
| State | New |
| Headers | show |
| Series | [RFC,01/57] drivers: s390/cio: Use driver_for_each_device | expand |
On 03.06.19 17:50, Suzuki K Poulose wrote: > Use the generic helper to find a device matching the devt. > > Cc: Harald Freudenberger <freude@linux.ibm.com> > Cc: Heiko Carstens <heiko.carstens@de.ibm.com> > Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> > --- > drivers/s390/crypto/zcrypt_api.c | 11 +---------- > 1 file changed, 1 insertion(+), 10 deletions(-) > > diff --git a/drivers/s390/crypto/zcrypt_api.c b/drivers/s390/crypto/zcrypt_api.c > index 16cad8e..99c9b77 100644 > --- a/drivers/s390/crypto/zcrypt_api.c > +++ b/drivers/s390/crypto/zcrypt_api.c > @@ -133,12 +133,6 @@ struct zcdn_device { > static int zcdn_create(const char *name); > static int zcdn_destroy(const char *name); > > -/* helper function, matches the devt value for find_zcdndev_by_devt() */ > -static int __match_zcdn_devt(struct device *dev, const void *data) > -{ > - return dev->devt == *((dev_t *) data); > -} > - > /* > * Find zcdn device by name. > * Returns reference to the zcdn device which needs to be released > @@ -159,10 +153,7 @@ static inline struct zcdn_device *find_zcdndev_by_name(const char *name) > */ > static inline struct zcdn_device *find_zcdndev_by_devt(dev_t devt) > { > - struct device *dev = > - class_find_device(zcrypt_class, NULL, > - (void *) &devt, > - __match_zcdn_devt); > + struct device *dev = class_find_device_by_devt(zcrypt_class, NULL, devt); > > return dev ? to_zcdn_dev(dev) : NULL; > } fine with me, thanks acked-by: Harald Freudenberger <freude@linux.ibm.com>
diff --git a/drivers/s390/crypto/zcrypt_api.c b/drivers/s390/crypto/zcrypt_api.c index 16cad8e..99c9b77 100644 --- a/drivers/s390/crypto/zcrypt_api.c +++ b/drivers/s390/crypto/zcrypt_api.c @@ -133,12 +133,6 @@ struct zcdn_device { static int zcdn_create(const char *name); static int zcdn_destroy(const char *name); -/* helper function, matches the devt value for find_zcdndev_by_devt() */ -static int __match_zcdn_devt(struct device *dev, const void *data) -{ - return dev->devt == *((dev_t *) data); -} - /* * Find zcdn device by name. * Returns reference to the zcdn device which needs to be released @@ -159,10 +153,7 @@ static inline struct zcdn_device *find_zcdndev_by_name(const char *name) */ static inline struct zcdn_device *find_zcdndev_by_devt(dev_t devt) { - struct device *dev = - class_find_device(zcrypt_class, NULL, - (void *) &devt, - __match_zcdn_devt); + struct device *dev = class_find_device_by_devt(zcrypt_class, NULL, devt); return dev ? to_zcdn_dev(dev) : NULL; }
Use the generic helper to find a device matching the devt. Cc: Harald Freudenberger <freude@linux.ibm.com> Cc: Heiko Carstens <heiko.carstens@de.ibm.com> Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> --- drivers/s390/crypto/zcrypt_api.c | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) -- 2.7.4