| Message ID | 20190608195317.6336-3-manivannan.sadhasivam@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | None | expand |
Am 08.06.19 um 21:53 schrieb Manivannan Sadhasivam: > Add devicetree binding for Actions Semi Owl SoC's SD/MMC/SDIO controller. > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > --- > .../devicetree/bindings/mmc/owl-mmc.txt | 37 +++++++++++++++++++ > 1 file changed, 37 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mmc/owl-mmc.txt Rob, should this be YAML now? > > diff --git a/Documentation/devicetree/bindings/mmc/owl-mmc.txt b/Documentation/devicetree/bindings/mmc/owl-mmc.txt > new file mode 100644 > index 000000000000..a702f8d66cec > --- /dev/null > +++ b/Documentation/devicetree/bindings/mmc/owl-mmc.txt > @@ -0,0 +1,37 @@ > +Actions Semi Owl SoCs SD/MMC/SDIO controller > + > +Required properties: > +- compatible: should be "actions,owl-mmc" > +- reg: offset and length of the register set for the device. > +- interrupts: single interrupt specifier. > +- clocks: single clock specifier of the controller clock. > +- resets: phandle to the reset line. > +- dma-names: should be "mmc". > +- dmas: single DMA channel specifier I recall the main blocker for MMC being regulators, i.e. the I²C attached multi-function PMIC. Yet I don't see any such required property here, nor any patch series implementing it. Seems like this relies on U-Boot having initialized SD/eMMC? Do you intend to make them optional or did you want to hold off merging this one until the rest is done? > + > +Optional properties: > +- pinctrl-names: pinctrl state names "default" must be defined. > +- pinctrl-0: phandle referencing pin configuration of the controller. > +- bus-width: see mmc.txt > +- cap-sd-highspeed: see mmc.txt > +- cap-mmc-highspeed: see mmc.txt > +- sd-uhs-sdr12: see mmc.txt > +- sd-uhs-sdr25: see mmc.txt > +- sd-uhs-sdr50: see mmc.txt > +- non-removable: see mmc.txt I'm not convinced duplicating common properties is a good idea here, in particular pinctrl. Regards, Andreas > + > +Example: > + > + mmc0: mmc@e0330000 { > + compatible = "actions,owl-mmc"; > + reg = <0x0 0xe0330000 0x0 0x4000>; > + interrupts = <GIC_SPI 42 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cmu CLK_SD0>; > + resets = <&cmu RESET_SD0>; > + dmas = <&dma 2>; > + dma-names = "mmc"; > + pinctrl-names = "default"; > + pinctrl-0 = <&mmc0_default>; > + bus-width = <4>; > + cap-sd-highspeed; > + }; > -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Mary Higgins, Sri Rasiah HRB 21284 (AG Nürnberg)
diff --git a/Documentation/devicetree/bindings/mmc/owl-mmc.txt b/Documentation/devicetree/bindings/mmc/owl-mmc.txt new file mode 100644 index 000000000000..a702f8d66cec --- /dev/null +++ b/Documentation/devicetree/bindings/mmc/owl-mmc.txt @@ -0,0 +1,37 @@ +Actions Semi Owl SoCs SD/MMC/SDIO controller + +Required properties: +- compatible: should be "actions,owl-mmc" +- reg: offset and length of the register set for the device. +- interrupts: single interrupt specifier. +- clocks: single clock specifier of the controller clock. +- resets: phandle to the reset line. +- dma-names: should be "mmc". +- dmas: single DMA channel specifier + +Optional properties: +- pinctrl-names: pinctrl state names "default" must be defined. +- pinctrl-0: phandle referencing pin configuration of the controller. +- bus-width: see mmc.txt +- cap-sd-highspeed: see mmc.txt +- cap-mmc-highspeed: see mmc.txt +- sd-uhs-sdr12: see mmc.txt +- sd-uhs-sdr25: see mmc.txt +- sd-uhs-sdr50: see mmc.txt +- non-removable: see mmc.txt + +Example: + + mmc0: mmc@e0330000 { + compatible = "actions,owl-mmc"; + reg = <0x0 0xe0330000 0x0 0x4000>; + interrupts = <GIC_SPI 42 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&cmu CLK_SD0>; + resets = <&cmu RESET_SD0>; + dmas = <&dma 2>; + dma-names = "mmc"; + pinctrl-names = "default"; + pinctrl-0 = <&mmc0_default>; + bus-width = <4>; + cap-sd-highspeed; + };
Add devicetree binding for Actions Semi Owl SoC's SD/MMC/SDIO controller. Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> --- .../devicetree/bindings/mmc/owl-mmc.txt | 37 +++++++++++++++++++ 1 file changed, 37 insertions(+) create mode 100644 Documentation/devicetree/bindings/mmc/owl-mmc.txt -- 2.17.1