From patchwork Tue Jun 11 18:58:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnaldo Carvalho de Melo X-Patchwork-Id: 166482 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp2722778ilk; Tue, 11 Jun 2019 12:02:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqxfGXpujSJh3STpX0fCg0JNNqyNEQuCFMKP0dEXZo6V6WKV3Ai6QSXsaBYKrlVuNjrHFZZm X-Received: by 2002:a17:902:7c8e:: with SMTP id y14mr9030894pll.298.1560279773455; Tue, 11 Jun 2019 12:02:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560279773; cv=none; d=google.com; s=arc-20160816; b=A0V1d0ZuWa8Tq0+0UmKthzalamzA6FCEvFLRwx3BGQtyShgpPsdARyHv/ykde/2MqH Ns5Gy4eB46OkaX+MdGyKnnlDILHJ3dGKAWF+6Y1o+vz9ymEKYgOssAHaVJx7oL6omwID RlcWbGkqYMFtkFYdAWLcDcLw3vYPkwsYGMKvaoMNKCPASiiqkZBF3sZzpFiZX0MxUCPo +I9ACbZ9ZJ4j5k+hSMzuG2/W48ZW//ycxOtvgcTA10PljGM2VCM9+eBs0r6wPq642qvv V11mYJDl+aoMGP9FuYo3PGjh15YfiTymSdDP9CeQFIOfcv1Ik3GtmBGkP1WIsH5sfyj7 Tf3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=rO2c5jB8HZvdtcXQ/XEhDT2+awz+qSKMhjugUwaA8Ak=; b=Ai4bmMLphxY5Y7OZsY8TbAIuRpwcOiCBFbSU5or+FQ1sWTPPoQhR8M14qEnLYY5pK4 1o+LhNzEfHN5qz91nBsKpm65Mrczjbzx6PCdFZasplSvVLXAKuXFY+4PWixhQ2nHXl5e 8KODAYGabbp4xR/R8NxGvTRWmDMsZQebaKSbC2yCdhj11xz84Nfek37ixuheUXfXky7X iGZxRXdUVlS6u+iPPoqf1kP0QqOdXCcq/aLFr84KLQXC7c9YVe2th5PmO/FoDq+EV4qc JHYD4NCHb+A9va/+qaowzFnwDNNyd98UKXrEomPGzMbnZUflLFeKS8TIdbcD8BxpTQT0 v8vg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Ct+X2nkM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b5si13640852ple.81.2019.06.11.12.02.52; Tue, 11 Jun 2019 12:02:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Ct+X2nkM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392412AbfFKTCv (ORCPT + 30 others); Tue, 11 Jun 2019 15:02:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:38958 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392400AbfFKTCu (ORCPT ); Tue, 11 Jun 2019 15:02:50 -0400 Received: from quaco.ghostprotocols.net (unknown [179.97.35.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DC760217D6; Tue, 11 Jun 2019 19:02:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560279769; bh=0ajeEWj5kL5FMCTtxzGBql20ziWbMwbq/JZumNCct3c=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ct+X2nkMHyJmr2I63v+3KoX/2VoBmQZ4lUbjMqTbHB0iXFXuV5DAFRb807M5OG0L5 RGFnkDzj0Usswof7BTgF2GybozydRXEGhkevJdRejIbgBb7u1vjsMn46BfDHKoM//2 t6GQAnP1Va2uMdEXbd/4AE5UpxGJRWABMAFIXljE= From: Arnaldo Carvalho de Melo To: Ingo Molnar , Thomas Gleixner Cc: Jiri Olsa , Namhyung Kim , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Mathieu Poirier , Leo Yan , Alexander Shishkin , Jiri Olsa , Peter Zijlstra , Suzuki Poulouse , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, Arnaldo Carvalho de Melo Subject: [PATCH 46/85] perf cs-etm: Get rid of unused cpu in struct cs_etm_queue Date: Tue, 11 Jun 2019 15:58:32 -0300 Message-Id: <20190611185911.11645-47-acme@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190611185911.11645-1-acme@kernel.org> References: <20190611185911.11645-1-acme@kernel.org> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Mathieu Poirier Nowadays the synthesize code is using the packet's cpu information, making cs_etm_queue::cpu useless. As such simply remove it. Signed-off-by: Mathieu Poirier Tested-by: Leo Yan Cc: Alexander Shishkin Cc: Jiri Olsa Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Suzuki Poulouse Cc: coresight@lists.linaro.org Cc: linux-arm-kernel@lists.infradead.org Link: http://lkml.kernel.org/r/20190524173508.29044-11-mathieu.poirier@linaro.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/cs-etm.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) -- 2.20.1 diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c index 9e8212c74055..531bbb355ba4 100644 --- a/tools/perf/util/cs-etm.c +++ b/tools/perf/util/cs-etm.c @@ -79,7 +79,6 @@ struct cs_etm_queue { struct auxtrace_buffer *buffer; unsigned int queue_nr; pid_t pid, tid; - int cpu; u64 offset; const unsigned char *buf; size_t buf_len, buf_used; @@ -599,7 +598,6 @@ static int cs_etm__setup_queue(struct cs_etm_auxtrace *etm, queue->priv = etmq; etmq->etm = etm; etmq->queue_nr = queue_nr; - etmq->cpu = queue->cpu; etmq->tid = queue->tid; etmq->pid = -1; etmq->offset = 0; @@ -831,11 +829,8 @@ static void cs_etm__set_pid_tid_cpu(struct cs_etm_auxtrace *etm, etmq->thread = machine__find_thread(etm->machine, -1, etmq->tid); - if (etmq->thread) { + if (etmq->thread) etmq->pid = etmq->thread->pid_; - if (queue->cpu == -1) - etmq->cpu = etmq->thread->cpu; - } } static int cs_etm__synth_instruction_sample(struct cs_etm_queue *etmq,