| Message ID | 20190618112227.3322313-1-arnd@arndb.de |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] ipsec: select crypto ciphers for xfrm_algo | expand |
On Tue, Jun 18, 2019 at 01:22:13PM +0200, Arnd Bergmann wrote: > kernelci.org reports failed builds on arc because of what looks > like an old missed 'select' statement: > > net/xfrm/xfrm_algo.o: In function `xfrm_probe_algs': > xfrm_algo.c:(.text+0x1e8): undefined reference to `crypto_has_ahash' > > I don't see this in randconfig builds on other architectures, but > it's fairly clear we want to select the hash code for it, like we > do for all its other users. As Herbert points out, CRYPTO_BLKCIPHER > is also required even though it has not popped up in build tests. > > Fixes: 17bc19702221 ("ipsec: Use skcipher and ahash when probing algorithms") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > net/xfrm/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) Acked-by: Herbert Xu <herbert@gondor.apana.org.au> -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
On Tue, Jun 18, 2019 at 01:22:13PM +0200, Arnd Bergmann wrote: > kernelci.org reports failed builds on arc because of what looks > like an old missed 'select' statement: > > net/xfrm/xfrm_algo.o: In function `xfrm_probe_algs': > xfrm_algo.c:(.text+0x1e8): undefined reference to `crypto_has_ahash' > > I don't see this in randconfig builds on other architectures, but > it's fairly clear we want to select the hash code for it, like we > do for all its other users. As Herbert points out, CRYPTO_BLKCIPHER > is also required even though it has not popped up in build tests. > > Fixes: 17bc19702221 ("ipsec: Use skcipher and ahash when probing algorithms") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Applied, thanks a lot!
diff --git a/net/xfrm/Kconfig b/net/xfrm/Kconfig index c967fc3c38c8..51bb6018f3bf 100644 --- a/net/xfrm/Kconfig +++ b/net/xfrm/Kconfig @@ -15,6 +15,8 @@ config XFRM_ALGO tristate select XFRM select CRYPTO + select CRYPTO_HASH + select CRYPTO_BLKCIPHER if INET config XFRM_USER
kernelci.org reports failed builds on arc because of what looks like an old missed 'select' statement: net/xfrm/xfrm_algo.o: In function `xfrm_probe_algs': xfrm_algo.c:(.text+0x1e8): undefined reference to `crypto_has_ahash' I don't see this in randconfig builds on other architectures, but it's fairly clear we want to select the hash code for it, like we do for all its other users. As Herbert points out, CRYPTO_BLKCIPHER is also required even though it has not popped up in build tests. Fixes: 17bc19702221 ("ipsec: Use skcipher and ahash when probing algorithms") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- net/xfrm/Kconfig | 2 ++ 1 file changed, 2 insertions(+) -- 2.20.0