From patchwork Thu Jun 20 07:35:28 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 167301 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp1725371ilk; Thu, 20 Jun 2019 00:36:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqxz863Ot3DTn3cCmKhAqB26ZcFezBMHJ+gGQ91z28xCrs5PcwudjBG31/P7VKiVP2EJW8tb X-Received: by 2002:a65:42c4:: with SMTP id l4mr11610539pgp.436.1561016159990; Thu, 20 Jun 2019 00:35:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561016159; cv=none; d=google.com; s=arc-20160816; b=bLiR69ilj1lZhVF7KqKlxhodVjSqA1gw28B5gxnW7WzwV6N6Ch9Ocb5jZ1sA0foSWv r/55xIeabJBWt8XLpEC4TsRWhuIJPuuRnf3h19xUNYsA7DdVnsgGzq4HqSBqKU9FMEmE 0KhDRxyfEqCp1dDpA55hIkx3WuJVrPo0dusxZkXybaB0h65ypMrNAl2lGBEGHV/q6lTr Uzx8GyNLbHavsHBWYn6HqgmIXU18PK43DyQXHUbDEqNu/38RuwUsZIbnVLSosLtTaxxF Er34nDdrK+bMm14UtJ6KdHRfg+KqsUMDMxuInWt6L14eZZwIshxTTvtiq+drlzVyPrIB L8YA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Q7XNmBdwQm+dBsBPtwMr7szEH/wj3wd0LWW4VkxG2rw=; b=pTdN6v/91ta/92OXjvC4paBmYDKxE6hUG61z2XBrXGlAaNGDY8qApTTaqOLkNkRzjb 69rizHxjvYPsRAXtkO1L2LXjV2c107+dp1J1XsedgFWS8eQyAmE5L1HPDlrYG/ARuu46 46INTy5geBw5dtufCqY1j5hOdG+F3UVjPvMP3wgcYCmfkdvn0mjWTPl3pi3/3nHyHwKu U4nfKojQGXEIsN2p8c43m4AOknfoGSAaWWLyA2Krh8bZqa6yXgiqmMZfB0IG5bqrVGKn 38to2FXOyLI5xJ7v6nKKXp0YrfqEyQ2/NvM7zcoXN5jkJzmku2rJmSmfoYTKGjeupWme gCXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HjYvJ6ue; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i9si5151353pgl.452.2019.06.20.00.35.59; Thu, 20 Jun 2019 00:35:59 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=HjYvJ6ue; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730821AbfFTHf6 (ORCPT + 30 others); Thu, 20 Jun 2019 03:35:58 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:38063 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730561AbfFTHf5 (ORCPT ); Thu, 20 Jun 2019 03:35:57 -0400 Received: by mail-pg1-f193.google.com with SMTP id v11so1119346pgl.5 for ; Thu, 20 Jun 2019 00:35:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Q7XNmBdwQm+dBsBPtwMr7szEH/wj3wd0LWW4VkxG2rw=; b=HjYvJ6ue2K2Acl/XwIMFG3LHfXLqVjFsrxV67UxP8KH2GSwObFwnvbfpZyMD1NVQH4 SyUPOY9JU/nZjYMODPgrHgRDQ+00ktkf+EoKIjac623Mq2g09LeSvxN51bxZmEfatMS7 AiSbIfUHeXKPfzOEulyD+h/bViuv54b1RsyuaSd0ck6WJwN4PWOSs6Sa85sfI0ZAlBIg +DWJQy/4FceijhaW9op0Z9DMT7R1t2mlIsEgFj0kzUiWa0OnnoINoUXqKfN/R8yKA7jE Vl6ZtmFOPXAihgnJNWhHahSaCD+cuAZhZyf9U1lFnRpxRexhokxGdlt+Nybl5qTEB731 yfwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Q7XNmBdwQm+dBsBPtwMr7szEH/wj3wd0LWW4VkxG2rw=; b=Vbs0bLflP5RVkOlFzI3X8gcIrTN2xEm7xD+6fnp8n8Lmha8aCLxZxkZLhiRVmPdpwl Usnsh5mvgazcoQ5+NUinNcHJ95uK+GpuZfJ/iTOnMepX25yIgIEB7oCC2W9ZYoROMgK1 TtfxDSZusuDO+yNhsHOu26bvru4AvU7raUyAfk0olKajjKPFg5z1+GQQjKplZ1/a+qqt q6tEeDBWQd44A3v+N8sycfKeoklHSIg+lirGaxK/OOEq0ItIbnfTk1jXi1Z4fWsoGaXC dOITYq2iZRaI3bJrGoLHsP3cUuspuA/yXEIAziXasdVhv4j/emU5gWTVER9yReBymsnP s+jQ== X-Gm-Message-State: APjAAAUm0UHoRfa0BXPknLNMx+g9ryQMlRKhd+ZHcTLyyqRqea/CI8u5 9gMePX1E80JfROsKMG8bVCeCJA== X-Received: by 2002:a17:90a:26a1:: with SMTP id m30mr1668273pje.59.1561016156058; Thu, 20 Jun 2019 00:35:56 -0700 (PDT) Received: from localhost ([122.172.66.84]) by smtp.gmail.com with ESMTPSA id e16sm27403448pga.11.2019.06.20.00.35.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Jun 2019 00:35:55 -0700 (PDT) From: Viresh Kumar To: Rafael Wysocki Cc: Viresh Kumar , linux-pm@vger.kernel.org, Vincent Guittot , Qais.Yousef@arm.com, mka@chromium.org, juri.lelli@gmail.com, Ulf Hansson , linux-kernel@vger.kernel.org Subject: [PATCH V4 5/6] cpufreq: Register notifiers with the PM QoS framework Date: Thu, 20 Jun 2019 13:05:28 +0530 Message-Id: <8290454213d8f3749b8091b8e4e53995efa0da87.1561014965.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.21.0.rc0.269.g1a574e7a288b In-Reply-To: References: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This registers the notifiers for min/max frequency constraints with the PM QoS framework. The constraints are also taken into consideration in cpufreq_set_policy(). This also relocates cpufreq_policy_put_kobj() as it is required to be called from cpufreq_policy_alloc() now. reeval_frequency_limits() is updated to have proper locking in place and avoid calling cpufreq_set_policy() for inactive policies. No constraints are added until now though. Reviewed-by: Matthias Kaehlcke Reviewed-by: Ulf Hansson Signed-off-by: Viresh Kumar --- drivers/cpufreq/cpufreq.c | 135 ++++++++++++++++++++++++++++++-------- include/linux/cpufreq.h | 3 + 2 files changed, 109 insertions(+), 29 deletions(-) -- 2.21.0.rc0.269.g1a574e7a288b diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 0a73de7aae54..b47a6c094171 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -26,6 +26,7 @@ #include #include #include +#include #include #include #include @@ -999,7 +1000,7 @@ static void add_cpu_dev_symlink(struct cpufreq_policy *policy, unsigned int cpu) { struct device *dev = get_cpu_device(cpu); - if (!dev) + if (unlikely(!dev)) return; if (cpumask_test_and_set_cpu(cpu, policy->real_cpus)) @@ -1117,14 +1118,20 @@ static int cpufreq_add_policy_cpu(struct cpufreq_policy *policy, unsigned int cp static void reeval_frequency_limits(struct cpufreq_policy *policy) { - struct cpufreq_policy new_policy = *policy; + struct cpufreq_policy new_policy; - pr_debug("updating policy for CPU %u\n", policy->cpu); + down_write(&policy->rwsem); + + if (!policy_is_inactive(policy)) { + new_policy = *policy; + pr_debug("updating policy for CPU %u\n", policy->cpu); - new_policy.min = policy->user_policy.min; - new_policy.max = policy->user_policy.max; + new_policy.min = policy->user_policy.min; + new_policy.max = policy->user_policy.max; + cpufreq_set_policy(policy, &new_policy); + } - cpufreq_set_policy(policy, &new_policy); + up_write(&policy->rwsem); } static void handle_update(struct work_struct *work) @@ -1136,11 +1143,55 @@ static void handle_update(struct work_struct *work) reeval_frequency_limits(policy); } +static int cpufreq_notifier_min(struct notifier_block *nb, unsigned long freq, + void *data) +{ + struct cpufreq_policy *policy = container_of(nb, struct cpufreq_policy, nb_min); + + schedule_work(&policy->update); + return 0; +} + +static int cpufreq_notifier_max(struct notifier_block *nb, unsigned long freq, + void *data) +{ + struct cpufreq_policy *policy = container_of(nb, struct cpufreq_policy, nb_max); + + schedule_work(&policy->update); + return 0; +} + +static void cpufreq_policy_put_kobj(struct cpufreq_policy *policy) +{ + struct kobject *kobj; + struct completion *cmp; + + down_write(&policy->rwsem); + cpufreq_stats_free_table(policy); + kobj = &policy->kobj; + cmp = &policy->kobj_unregister; + up_write(&policy->rwsem); + kobject_put(kobj); + + /* + * We need to make sure that the underlying kobj is + * actually not referenced anymore by anybody before we + * proceed with unloading. + */ + pr_debug("waiting for dropping of refcount\n"); + wait_for_completion(cmp); + pr_debug("wait complete\n"); +} + static struct cpufreq_policy *cpufreq_policy_alloc(unsigned int cpu) { struct cpufreq_policy *policy; + struct device *dev = get_cpu_device(cpu); int ret; + if (!dev) + return NULL; + policy = kzalloc(sizeof(*policy), GFP_KERNEL); if (!policy) return NULL; @@ -1157,7 +1208,7 @@ static struct cpufreq_policy *cpufreq_policy_alloc(unsigned int cpu) ret = kobject_init_and_add(&policy->kobj, &ktype_cpufreq, cpufreq_global_kobject, "policy%u", cpu); if (ret) { - pr_err("%s: failed to init policy->kobj: %d\n", __func__, ret); + dev_err(dev, "%s: failed to init policy->kobj: %d\n", __func__, ret); /* * The entire policy object will be freed below, but the extra * memory allocated for the kobject name needs to be freed by @@ -1167,6 +1218,25 @@ static struct cpufreq_policy *cpufreq_policy_alloc(unsigned int cpu) goto err_free_real_cpus; } + policy->nb_min.notifier_call = cpufreq_notifier_min; + policy->nb_max.notifier_call = cpufreq_notifier_max; + + ret = dev_pm_qos_add_notifier(dev, &policy->nb_min, + DEV_PM_QOS_MIN_FREQUENCY); + if (ret) { + dev_err(dev, "Failed to register MIN QoS notifier: %d (%*pbl)\n", + ret, cpumask_pr_args(policy->cpus)); + goto err_kobj_remove; + } + + ret = dev_pm_qos_add_notifier(dev, &policy->nb_max, + DEV_PM_QOS_MAX_FREQUENCY); + if (ret) { + dev_err(dev, "Failed to register MAX QoS notifier: %d (%*pbl)\n", + ret, cpumask_pr_args(policy->cpus)); + goto err_min_qos_notifier; + } + INIT_LIST_HEAD(&policy->policy_list); init_rwsem(&policy->rwsem); spin_lock_init(&policy->transition_lock); @@ -1177,6 +1247,11 @@ static struct cpufreq_policy *cpufreq_policy_alloc(unsigned int cpu) policy->cpu = cpu; return policy; +err_min_qos_notifier: + dev_pm_qos_remove_notifier(dev, &policy->nb_min, + DEV_PM_QOS_MIN_FREQUENCY); +err_kobj_remove: + cpufreq_policy_put_kobj(policy); err_free_real_cpus: free_cpumask_var(policy->real_cpus); err_free_rcpumask: @@ -1189,30 +1264,9 @@ static struct cpufreq_policy *cpufreq_policy_alloc(unsigned int cpu) return NULL; } -static void cpufreq_policy_put_kobj(struct cpufreq_policy *policy) -{ - struct kobject *kobj; - struct completion *cmp; - - down_write(&policy->rwsem); - cpufreq_stats_free_table(policy); - kobj = &policy->kobj; - cmp = &policy->kobj_unregister; - up_write(&policy->rwsem); - kobject_put(kobj); - - /* - * We need to make sure that the underlying kobj is - * actually not referenced anymore by anybody before we - * proceed with unloading. - */ - pr_debug("waiting for dropping of refcount\n"); - wait_for_completion(cmp); - pr_debug("wait complete\n"); -} - static void cpufreq_policy_free(struct cpufreq_policy *policy) { + struct device *dev = get_cpu_device(policy->cpu); unsigned long flags; int cpu; @@ -1224,6 +1278,11 @@ static void cpufreq_policy_free(struct cpufreq_policy *policy) per_cpu(cpufreq_cpu_data, cpu) = NULL; write_unlock_irqrestore(&cpufreq_driver_lock, flags); + dev_pm_qos_remove_notifier(dev, &policy->nb_max, + DEV_PM_QOS_MAX_FREQUENCY); + dev_pm_qos_remove_notifier(dev, &policy->nb_min, + DEV_PM_QOS_MIN_FREQUENCY); + cpufreq_policy_put_kobj(policy); free_cpumask_var(policy->real_cpus); free_cpumask_var(policy->related_cpus); @@ -2285,6 +2344,8 @@ int cpufreq_set_policy(struct cpufreq_policy *policy, struct cpufreq_policy *new_policy) { struct cpufreq_governor *old_gov; + struct device *cpu_dev = get_cpu_device(policy->cpu); + unsigned long min, max; int ret; pr_debug("setting new policy for CPU %u: %u - %u kHz\n", @@ -2299,11 +2360,27 @@ int cpufreq_set_policy(struct cpufreq_policy *policy, if (new_policy->min > new_policy->max) return -EINVAL; + /* + * PM QoS framework collects all the requests from users and provide us + * the final aggregated value here. + */ + min = dev_pm_qos_read_value(cpu_dev, DEV_PM_QOS_MIN_FREQUENCY); + max = dev_pm_qos_read_value(cpu_dev, DEV_PM_QOS_MAX_FREQUENCY); + + if (min > new_policy->min) + new_policy->min = min; + if (max < new_policy->max) + new_policy->max = max; + /* verify the cpu speed can be set within this limit */ ret = cpufreq_driver->verify(new_policy); if (ret) return ret; + /* + * The notifier-chain shall be removed once all the users of + * CPUFREQ_ADJUST are moved to use the QoS framework. + */ /* adjust if necessary - all reasons */ blocking_notifier_call_chain(&cpufreq_policy_notifier_list, CPUFREQ_ADJUST, new_policy); diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h index d01a74fbc4db..d8622cf3f46c 100644 --- a/include/linux/cpufreq.h +++ b/include/linux/cpufreq.h @@ -147,6 +147,9 @@ struct cpufreq_policy { /* Pointer to the cooling device if used for thermal mitigation */ struct thermal_cooling_device *cdev; + + struct notifier_block nb_min; + struct notifier_block nb_max; }; struct cpufreq_freqs {