diff mbox series

[bpf-next] libbpf: fix max() type mismatch for 32bit

Message ID 20190625202700.28030-1-ivan.khoronzhuk@linaro.org
State Superseded
Headers show
Series [bpf-next] libbpf: fix max() type mismatch for 32bit | expand

Commit Message

Ivan Khoronzhuk June 25, 2019, 8:27 p.m. UTC
It fixes build error for 32bit caused by type mismatch
size_t/unsigned long.

Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>

---
 tools/lib/bpf/libbpf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.17.1

Comments

Song Liu June 25, 2019, 8:59 p.m. UTC | #1
On Tue, Jun 25, 2019 at 1:28 PM Ivan Khoronzhuk
<ivan.khoronzhuk@linaro.org> wrote:
>

> It fixes build error for 32bit caused by type mismatch

> size_t/unsigned long.

>

> Signed-off-by: Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org>


Acked-by: Song Liu <songliubraving@fb.com>


> ---

>  tools/lib/bpf/libbpf.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

>

> diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c

> index 68f45a96769f..5186b7710430 100644

> --- a/tools/lib/bpf/libbpf.c

> +++ b/tools/lib/bpf/libbpf.c

> @@ -778,7 +778,7 @@ static struct bpf_map *bpf_object__add_map(struct bpf_object *obj)

>         if (obj->nr_maps < obj->maps_cap)

>                 return &obj->maps[obj->nr_maps++];

>

> -       new_cap = max(4ul, obj->maps_cap * 3 / 2);

> +       new_cap = max((size_t)4, obj->maps_cap * 3 / 2);

>         new_maps = realloc(obj->maps, new_cap * sizeof(*obj->maps));

>         if (!new_maps) {

>                 pr_warning("alloc maps for object failed\n");

> --

> 2.17.1

>
diff mbox series

Patch

diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
index 68f45a96769f..5186b7710430 100644
--- a/tools/lib/bpf/libbpf.c
+++ b/tools/lib/bpf/libbpf.c
@@ -778,7 +778,7 @@  static struct bpf_map *bpf_object__add_map(struct bpf_object *obj)
 	if (obj->nr_maps < obj->maps_cap)
 		return &obj->maps[obj->nr_maps++];
 
-	new_cap = max(4ul, obj->maps_cap * 3 / 2);
+	new_cap = max((size_t)4, obj->maps_cap * 3 / 2);
 	new_maps = realloc(obj->maps, new_cap * sizeof(*obj->maps));
 	if (!new_maps) {
 		pr_warning("alloc maps for object failed\n");