From patchwork Tue May 14 13:46:29 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 16897 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f70.google.com (mail-la0-f70.google.com [209.85.215.70]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 5499925D00 for ; Tue, 14 May 2013 13:47:10 +0000 (UTC) Received: by mail-la0-f70.google.com with SMTP id ee20sf508142lab.5 for ; Tue, 14 May 2013 06:46:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:x-beenthere:x-received:received-spf:x-received :x-forwarded-to:x-forwarded-for:delivered-to:x-received:received-spf :mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:x-gm-message-state:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-google-group-id:list-post:list-help:list-archive:list-unsubscribe :content-type; bh=VeerpyM7RnLgaSra7rbSpWarN9Bil84SJ1Vn/tMDDCw=; b=UcorBe+NVzz0vP8BCXhwUVYU7sJ3xwV2eXZzP9gXdoVBpNpXv4XoNhPYmfbucjf9Su 2GCMdo0NjyI6WgL1AkoaMXCMFRIVOIiLY6dLnjhkxRxDbLNpd21P2a3EAZYiJdTavRSh 2N8+ln2oqPFZbazibUA/Az2d1nvXK4j7fuwWZauetq//8VMREZeHAOnjFdoojYYpL4Fk CS1dX1o7BX8QcSBFaghWfV0FfzLexvx0VPBSui5tHKgaso3z1WCpdM569HnkH7eYC+m/ eXE0dAEML8l6xDhh9AWVK9aA9lFRnI3HaCvpRwKDxOntr7Wn5IMqo3iHENPs4DvWovr6 szIQ== X-Received: by 10.180.85.5 with SMTP id d5mr858356wiz.0.1368539193769; Tue, 14 May 2013 06:46:33 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.180.183.237 with SMTP id ep13ls147519wic.2.gmail; Tue, 14 May 2013 06:46:33 -0700 (PDT) X-Received: by 10.180.37.133 with SMTP id y5mr6617330wij.20.1368539193441; Tue, 14 May 2013 06:46:33 -0700 (PDT) Received: from mail-ve0-x22c.google.com (mail-ve0-x22c.google.com [2607:f8b0:400c:c01::22c]) by mx.google.com with ESMTPS id fz14si3474839wic.6.2013.05.14.06.46.32 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 14 May 2013 06:46:33 -0700 (PDT) Received-SPF: neutral (google.com: 2607:f8b0:400c:c01::22c is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=2607:f8b0:400c:c01::22c; Received: by mail-ve0-f172.google.com with SMTP id b10so597654vea.31 for ; Tue, 14 May 2013 06:46:32 -0700 (PDT) X-Received: by 10.220.89.198 with SMTP id f6mr22027012vcm.45.1368539192059; Tue, 14 May 2013 06:46:32 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.217.15 with SMTP id hk15csp63456vcb; Tue, 14 May 2013 06:46:30 -0700 (PDT) X-Received: by 10.60.56.19 with SMTP id w19mr15485393oep.99.1368539190522; Tue, 14 May 2013 06:46:30 -0700 (PDT) Received: from mail-ob0-x22d.google.com (mail-ob0-x22d.google.com [2607:f8b0:4003:c01::22d]) by mx.google.com with ESMTPS id so3si14839998oeb.25.2013.05.14.06.46.30 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 14 May 2013 06:46:30 -0700 (PDT) Received-SPF: neutral (google.com: 2607:f8b0:4003:c01::22d is neither permitted nor denied by best guess record for domain of viresh.kumar@linaro.org) client-ip=2607:f8b0:4003:c01::22d; Received: by mail-ob0-f173.google.com with SMTP id eh20so564733obb.18 for ; Tue, 14 May 2013 06:46:30 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.60.120.34 with SMTP id kz2mr16616261oeb.17.1368539189900; Tue, 14 May 2013 06:46:29 -0700 (PDT) Received: by 10.182.79.35 with HTTP; Tue, 14 May 2013 06:46:29 -0700 (PDT) In-Reply-To: <5191148E.7050205@wwwdotorg.org> References: <7e12acada8adcba5f4eb72f6c49e38aaf00a294f.1368434974.git.viresh.kumar@linaro.org> <5191148E.7050205@wwwdotorg.org> Date: Tue, 14 May 2013 19:16:29 +0530 Message-ID: Subject: Re: [PATCH V1 resend] cpufreq: Raname index as data in cpufreq_frequency_table From: Viresh Kumar To: rjw@sisk.pl, Stephen Warren Cc: linaro-kernel@lists.linaro.org, patches@linaro.org, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, robin.randhawa@arm.com, Steve.Bannister@arm.com, Liviu.Dudau@arm.com, charles.garcia-tobin@arm.com, arvind.chauhan@arm.com, Sekhar Nori , Ben Dooks , Kukjin Kim , Simon Horman , Magnus Damm , Ralf Baechle , Arnd Bergmann , Benjamin Herrenschmidt , Paul Mackerras , Olof Johansson , Srinidhi Kasagar , Linus Walleij X-Gm-Message-State: ALoCoQnng44t1wqB58CcQEsTsH1TQ0dICH0JIfalhvGxK0n4cNpcpvyjgufdLUC3SJJPAa4bHtlu X-Original-Sender: viresh.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 2607:f8b0:400c:c01::22c is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , On 13 May 2013 21:57, Stephen Warren wrote: > On 05/13/2013 06:57 AM, Viresh Kumar wrote: >> "Index" field of struct cpufreq_frequency_table was never index and isn't used >> at all by cpufreq core. And is only useful for cpufreq drivers for their >> personal use. >> >> Many people now a days blindly set it in ascending order with the assumption >> that core is using it for some work. >> >> This patch renames it to "data" as that's what its purpose it. All users of the >> same are fixed too. > >> diff --git a/drivers/cpufreq/tegra-cpufreq.c b/drivers/cpufreq/tegra-cpufreq.c > >> -/* Frequency table index must be sequential starting at 0 */ >> +/* Frequency table data must be sequential starting at 0 */ > > I assume that comment is due to the assumption you're trying to remove. > Should the comment be removed/corrected now? Perhaps the .data field > isn't even needed any more in this driver? > >> static struct cpufreq_frequency_table freq_table[] = { >> { 0, 216000 }, >> { 1, 312000 }, This must address your concerns: @Rafael: I have attached both patches now for you to apply. From: Viresh Kumar Date: Tue, 14 May 2013 19:08:50 +0530 Subject: [PATCH 1/2] cpufreq: tegra: Remove irrelevant comment Tegra cpufreq driver doesn't use .index field of cpufreq_frequency_table and so comment mentioning order of .index is irrelevant. Remove it. Signed-off-by: Viresh Kumar --- drivers/cpufreq/tegra-cpufreq.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/cpufreq/tegra-cpufreq.c b/drivers/cpufreq/tegra-cpufreq.c index c74c0e1..293ed2c 100644 --- a/drivers/cpufreq/tegra-cpufreq.c +++ b/drivers/cpufreq/tegra-cpufreq.c @@ -28,7 +28,6 @@ #include #include -/* Frequency table index must be sequential starting at 0 */ static struct cpufreq_frequency_table freq_table[] = { { 0, 216000 }, { 1, 312000 },