[Branch,~linaro-validation/lava-dispatcher/trunk] Rev 600: document the need for a dhclient call

Message ID 20130514193112.30495.71815.launchpad@ackee.canonical.com
State Accepted
Headers show

Commit Message

Antonio Terceiro May 14, 2013, 7:31 p.m.
------------------------------------------------------------
revno: 600
committer: Antonio Terceiro <antonio.terceiro@linaro.org>
branch nick: trunk
timestamp: Tue 2013-05-14 16:30:02 -0300
message:
  document the need for a dhclient call
modified:
  lava_dispatcher/device/highbank.py


--
lp:lava-dispatcher
https://code.launchpad.net/~linaro-validation/lava-dispatcher/trunk

You are subscribed to branch lp:lava-dispatcher.
To unsubscribe from this branch go to https://code.launchpad.net/~linaro-validation/lava-dispatcher/trunk/+edit-subscription

Patch

=== modified file 'lava_dispatcher/device/highbank.py'
--- lava_dispatcher/device/highbank.py	2013-05-14 18:09:20 +0000
+++ lava_dispatcher/device/highbank.py	2013-05-14 19:30:02 +0000
@@ -248,6 +248,13 @@ 
         device = "eth0"
         runner.run("DEVICE=%s configure_networking" % device)
 
+        # we call dhclient even though configure_networking above already
+        # picked up a IP address. configure_networking brings the interface up,
+        # but does not configure DNS properly. dhclient needs the interface to
+        # be up, and will set DNS correctly. In the end we are querying DHCP
+        # twice, but with a properly configured DHCP server (i.e. one that will
+        # give the same address for a given MAC address), this should not be a
+        # problem.
         runner.run("mkdir -p /var/run")
         runner.run("mkdir -p /var/lib/dhcp")
         runner.run("dhclient -v -1")