From patchwork Wed May 15 06:25:36 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 16913 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ve0-f197.google.com (mail-ve0-f197.google.com [209.85.128.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id DBE6825D00 for ; Wed, 15 May 2013 06:26:15 +0000 (UTC) Received: by mail-ve0-f197.google.com with SMTP id ox1sf1557778veb.4 for ; Tue, 14 May 2013 23:25:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:x-beenthere:x-received:received-spf:x-received :x-forwarded-to:x-forwarded-for:delivered-to:x-received:received-spf :mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:x-gm-message-state:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :x-google-group-id:list-post:list-help:list-archive:list-unsubscribe :content-type; bh=ZgfVtkbyGEM4L2fNl90fUJ3NA3LE2Z0jXpOMBgjowwo=; b=NSRVrS7d/7fy/6/1gt71rh5G11obHteZ+m07Y3Qttw7QQZ9zXyGayfhGnwd95JENKb um/6Nk+i/Upz3ZuhzNIGIqCk8JydPsuLN60zJ5ah+drr2OoPJ/U8/9W1TKNHZQnHveop APSmZuZgisUBg/VLZ2q3bZ/R5+8/cMB9aO/sHlPlLi2UB4/SlyQ0zuFtJ683ivjUccXK 5uWHjWuog4AbhtokT6VJNzca9TtecciwsSp/vm4FbZJeL4WyxY71ubflD7VMutwSLY0f qBsunqnT3J5XTcUvUw5SDRFG5TcNvvFSxSvuoVmy7r7khN4r2xRdvhGd3/SKeE7bnZnp F1Pg== X-Received: by 10.224.10.6 with SMTP id n6mr22740315qan.4.1368599139281; Tue, 14 May 2013 23:25:39 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.49.1.81 with SMTP id 17ls554345qek.79.gmail; Tue, 14 May 2013 23:25:39 -0700 (PDT) X-Received: by 10.52.29.19 with SMTP id f19mr20224466vdh.100.1368599139035; Tue, 14 May 2013 23:25:39 -0700 (PDT) Received: from mail-vc0-f174.google.com (mail-vc0-f174.google.com [209.85.220.174]) by mx.google.com with ESMTPS id r5si787635vdw.98.2013.05.14.23.25.38 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 14 May 2013 23:25:38 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.220.174 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.220.174; Received: by mail-vc0-f174.google.com with SMTP id hr11so1500180vcb.33 for ; Tue, 14 May 2013 23:25:38 -0700 (PDT) X-Received: by 10.52.53.36 with SMTP id y4mr19563171vdo.51.1368599138531; Tue, 14 May 2013 23:25:38 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.220.217.15 with SMTP id hk15csp5071vcb; Tue, 14 May 2013 23:25:37 -0700 (PDT) X-Received: by 10.60.60.73 with SMTP id f9mr6834730oer.43.1368599136882; Tue, 14 May 2013 23:25:36 -0700 (PDT) Received: from mail-ob0-x22e.google.com (mail-ob0-x22e.google.com [2607:f8b0:4003:c01::22e]) by mx.google.com with ESMTPS id yw5si847745obb.38.2013.05.14.23.25.36 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 14 May 2013 23:25:36 -0700 (PDT) Received-SPF: neutral (google.com: 2607:f8b0:4003:c01::22e is neither permitted nor denied by best guess record for domain of viresh.kumar@linaro.org) client-ip=2607:f8b0:4003:c01::22e; Received: by mail-ob0-f174.google.com with SMTP id un3so1548979obb.33 for ; Tue, 14 May 2013 23:25:36 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.60.58.99 with SMTP id p3mr18106075oeq.23.1368599136396; Tue, 14 May 2013 23:25:36 -0700 (PDT) Received: by 10.182.180.16 with HTTP; Tue, 14 May 2013 23:25:36 -0700 (PDT) In-Reply-To: <51926325.2050805@wwwdotorg.org> References: <7e12acada8adcba5f4eb72f6c49e38aaf00a294f.1368434974.git.viresh.kumar@linaro.org> <5191148E.7050205@wwwdotorg.org> <51926325.2050805@wwwdotorg.org> Date: Wed, 15 May 2013 11:55:36 +0530 Message-ID: Subject: Re: [PATCH V1 resend] cpufreq: Raname index as data in cpufreq_frequency_table From: Viresh Kumar To: Stephen Warren Cc: rjw@sisk.pl, linaro-kernel@lists.linaro.org, patches@linaro.org, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, robin.randhawa@arm.com, Steve.Bannister@arm.com, Liviu.Dudau@arm.com, charles.garcia-tobin@arm.com, arvind.chauhan@arm.com, Sekhar Nori , Ben Dooks , Kukjin Kim , Simon Horman , Magnus Damm , Ralf Baechle , Arnd Bergmann , Benjamin Herrenschmidt , Paul Mackerras , Olof Johansson , Srinidhi Kasagar , Linus Walleij X-Gm-Message-State: ALoCoQmADlChCarmyq/TUlbDDTO2mbFIZ46n09KbaLjGRTRx0+oVcTNASpxzYbcF0O2dx5rm9BGi X-Original-Sender: viresh.kumar@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.220.174 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , On 14 May 2013 21:45, Stephen Warren wrote: > On 05/14/2013 07:46 AM, Viresh Kumar wrote: > ... >> This must address your concerns: >> @Rafael: I have attached both patches now for you to apply. >> >> From: Viresh Kumar >> Date: Tue, 14 May 2013 19:08:50 +0530 >> Subject: [PATCH 1/2] cpufreq: tegra: Remove irrelevant comment >> >> Tegra cpufreq driver doesn't use .index field of cpufreq_frequency_table and so >> comment mentioning order of .index is irrelevant. Remove it. > >> diff --git a/drivers/cpufreq/tegra-cpufreq.c b/drivers/cpufreq/tegra-cpufreq.c > >> -/* Frequency table index must be sequential starting at 0 */ >> static struct cpufreq_frequency_table freq_table[] = { >> { 0, 216000 }, >> { 1, 312000 }, > > Does the .index/.data field even need to be filled in any more? No. But i didn't wanted to write following code: { .frequency = *** }, as earlier one was fine too. Ack whichever version you want (Attached too): -----------x-----------------x----------------- From: Viresh Kumar Date: Tue, 14 May 2013 19:08:50 +0530 Subject: [PATCH] cpufreq: tegra: Don't initialize .index field of cpufreq_frequency_table Tegra cpufreq driver doesn't use .index field of cpufreq_frequency_table and so we don't need to initialize it. Don't initialize it. Signed-off-by: Viresh Kumar Acked-by: Stephen Warren --- drivers/cpufreq/tegra-cpufreq.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/cpufreq/tegra-cpufreq.c b/drivers/cpufreq/tegra-cpufreq.c index c74c0e1..81561be 100644 --- a/drivers/cpufreq/tegra-cpufreq.c +++ b/drivers/cpufreq/tegra-cpufreq.c @@ -28,17 +28,16 @@ #include #include -/* Frequency table index must be sequential starting at 0 */ static struct cpufreq_frequency_table freq_table[] = { - { 0, 216000 }, - { 1, 312000 }, - { 2, 456000 }, - { 3, 608000 }, - { 4, 760000 }, - { 5, 816000 }, - { 6, 912000 }, - { 7, 1000000 }, - { 8, CPUFREQ_TABLE_END }, + { .frequency = 216000 }, + { .frequency = 312000 }, + { .frequency = 456000 }, + { .frequency = 608000 }, + { .frequency = 760000 }, + { .frequency = 816000 }, + { .frequency = 912000 }, + { .frequency = 1000000 }, + { .frequency = CPUFREQ_TABLE_END }, }; #define NUM_CPUS 2