From patchwork Fri Jul 26 17:50:18 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 169914 Delivered-To: patch@linaro.org Received: by 2002:a92:4782:0:0:0:0:0 with SMTP id e2csp364892ilk; Fri, 26 Jul 2019 11:02:12 -0700 (PDT) X-Google-Smtp-Source: APXvYqw7vUVw/fBBS4iNvHyYstsxZGJHfmS4sZDUSMtGzmqywJ2N7GKK1uO9AGjyfkW0Mo3NZuSQ X-Received: by 2002:a17:906:af86:: with SMTP id mj6mr28681089ejb.157.1564164131966; Fri, 26 Jul 2019 11:02:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1564164131; cv=none; d=google.com; s=arc-20160816; b=FsW9kNVhWTiEJhGd7WDzMCRWpXiAl6G9plqo50IOldTYsOEnYo3IoJSi2ktjGhJUFk QwIj0ucl1CPKGoLJc+LN2pFcuK1afVVivG3C69SqNEK6SEcGN3GU2Ts16BQGkhYsxP2D kU7dkgLPskQczVV7e+GvldtsK+AAT/+XdEUe6DwB153kh4pBATKqyUHBcaBeTSgK9Hg5 4OSHjfWttTJmb+HA8rqcHnP2lJjflgTcjLI/oiJpFZ0ScZZrbnV0n0Yzl+268RM274m1 4DwkyM0JPGeXN0idNvJ/PAYqixXwmfUI8geN2TVRUqdT9SIAzz1GQU6sxPq0BxscOeQ9 pw4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:to:from:dkim-signature; bh=4oQFd4eolp/sR05iPY07hrdPVedFpqTSb74q9tevE6Q=; b=qSZm0BrVsiEJe/nrAJNLHA/0eOoTShVIQTDlB3Kh8pAeTW8PpCpn5VyeC0VDJSZE8S Fj0DNHV3c27g3FuqYrAoSsc8h+gidIk/3dpldQ1HDfcYaMAlFCuQ52zGqVrq/ia9f9z8 gmhQjNV3ndv5H0StgFqfkzjkTR3lddxrMyAJYqnrB61m9bP/nHF/dJlB9c0Hwy+ybz5K Tlp5UUUofkcZy1WnHmAQ7pt/pIInFdk7wgzClLchL3frkDt3ZjUQAqjkd/DFXUm4+uYp GkzwMst8ZPSDXahS24cXLsA8fB69kLpFJtdjRbvX80HpZo3+Vah8yHjbGziCsQ45BGfT pbkg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=sebaT5Ca; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id i3si12286207eda.107.2019.07.26.11.02.11 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 26 Jul 2019 11:02:11 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@linaro.org header.s=google header.b=sebaT5Ca; spf=pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+patch=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from localhost ([::1]:42634 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hr4Xh-000715-8A for patch@linaro.org; Fri, 26 Jul 2019 14:02:09 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59399) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hr4No-00072A-UA for qemu-devel@nongnu.org; Fri, 26 Jul 2019 13:51:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hr4Nl-0001C9-CI for qemu-devel@nongnu.org; Fri, 26 Jul 2019 13:51:55 -0400 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]:39977) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hr4Nl-000104-3L for qemu-devel@nongnu.org; Fri, 26 Jul 2019 13:51:53 -0400 Received: by mail-pg1-x544.google.com with SMTP id w10so25119004pgj.7 for ; Fri, 26 Jul 2019 10:51:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=4oQFd4eolp/sR05iPY07hrdPVedFpqTSb74q9tevE6Q=; b=sebaT5CasiTw2aM3248r1KuO5rtFcs1xBcJSCI0q1O9VXVe8TaJ5Jd4Xof3DPSkguy SdwPX+1iUc6OEXijV+TlXieOtSH9CiMnH1cGu8E6VElNAFU3DJEYnFwmcTj4gWP9mmUK /wPf2JdJDkvHEmeOaTfp+7hzDOgFzA/rI4rVIP6vSTsOnuaRjvABIpedUTv8GtfLknum oHRT/y2drBf5b/EDjQld8UII+U8bZ1Kbn/SQkkAPoe4cwsg5wFLzJpvvDBeONpw1ohv9 85Klm4DDg8PXU7dbUnp8pnDjroZ3PAPrhHCZY9+1N0/7tnJA7b4VtDlNkYd9c+OuztrL Acag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=4oQFd4eolp/sR05iPY07hrdPVedFpqTSb74q9tevE6Q=; b=DEs1nBHbmqVrESg3rs7bnP+O1Cyo757KEy+t7vVQPX/KFIO/25j4TvSt//NmnMjJ2B r9wPZH+uYwJGCqBoM+zN4GHoQEzSk6VhhT/tyG0M/bCLj7/6e9olFW+u2KvUDTik/6qo cuaTatRSBXJAmdFkz84o1URYOQlNWQkJuvL/MBHCdEAF7RYKynrir+veBLFqLxcSwVnz Xrk7YBQX4B9mVGgCjykw67cfgVDLuSXvB5w1qx76WwBEWkNpZMM58O/XMvlg36bVTgJi yOFDg6Beh4agwqIaVkCUlAaAI7MvAakWiYpVqYyQ8PzmyJf7PqVfvIW1TqPAPLAcsT0+ UpUQ== X-Gm-Message-State: APjAAAVMUbDH/56Sk5Ifcxd+DIKzv4yBpHq3v9fRlHjO8ypZ/96eQn53 +yuoD98xxkgIlvG1F1XfCiJTY09mRgI= X-Received: by 2002:a17:90a:d996:: with SMTP id d22mr99375160pjv.86.1564163498255; Fri, 26 Jul 2019 10:51:38 -0700 (PDT) Received: from localhost.localdomain (97-126-117-207.tukw.qwest.net. [97.126.117.207]) by smtp.gmail.com with ESMTPSA id o24sm104287919pfp.135.2019.07.26.10.51.37 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 26 Jul 2019 10:51:37 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Date: Fri, 26 Jul 2019 10:50:18 -0700 Message-Id: <20190726175032.6769-54-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190726175032.6769-1-richard.henderson@linaro.org> References: <20190726175032.6769-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::544 Subject: [Qemu-devel] [PATCH 53/67] target/arm: Convert T16 adjust sp (immediate) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org, alex.bennee@linaro.org Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org Sender: "Qemu-devel" Signed-off-by: Richard Henderson --- target/arm/translate.c | 15 ++------------- target/arm/t16.decode | 9 +++++++++ 2 files changed, 11 insertions(+), 13 deletions(-) -- 2.17.1 diff --git a/target/arm/translate.c b/target/arm/translate.c index 23f5f982f5..8dd88419fe 100644 --- a/target/arm/translate.c +++ b/target/arm/translate.c @@ -10648,19 +10648,8 @@ static void disas_thumb_insn(DisasContext *s, uint32_t insn) /* misc */ op = (insn >> 8) & 0xf; switch (op) { - case 0: - /* - * 0b1011_0000_xxxx_xxxx - * - ADD (SP plus immediate) - * - SUB (SP minus immediate) - */ - tmp = load_reg(s, 13); - val = (insn & 0x7f) * 4; - if (insn & (1 << 7)) - val = -(int32_t)val; - tcg_gen_addi_i32(tmp, tmp, val); - store_sp_checked(s, tmp); - break; + case 0: /* add/sub (sp, immediate), in decodetree */ + goto illegal_op; case 2: /* sign/zero extend. */ ARCH(6); diff --git a/target/arm/t16.decode b/target/arm/t16.decode index 69d3894ba7..ddf12ada11 100644 --- a/target/arm/t16.decode +++ b/target/arm/t16.decode @@ -156,6 +156,15 @@ ADD_rrri 0100 0100 . .... ... @addsub_2h s=0 CMP_rrri 0100 0101 . .... ... @addsub_2h s=1 MOV_rrri 0100 0110 . .... ... @addsub_2h s=0 +# Adjust SP (immediate) + +%imm7_0x4 0:7 !function=times_4 +@addsub_sp_i .... .... . ....... \ + &s_rri_rot s=0 rd=13 rn=13 rot=0 imm=%imm7_0x4 + +ADD_rri 1011 0000 0 ....... @addsub_sp_i +SUB_rri 1011 0000 1 ....... @addsub_sp_i + # Branch and exchange @branchr .... .... . rm:4 ... &r