| Message ID | 20190728154728.11126-1-yamada.masahiro@socionext.com |
|---|---|
| State | Accepted |
| Commit | 541be05095437a7e5e08e7d13a13e03ec0994ae7 |
| Headers | show |
| Series | linux/coff.h: add include guard | expand |
On Mon, 29 Jul 2019 00:47:28 +0900 Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > Add a header include guard just in case. > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > --- > > Looks like this file is unused at least in the kernel tree, > but I am not it is OK to delete it. arch/alpha/boot/tools/objstrip.c includes it but I don't think it's actually needed. Yes, it would be nice to kill coff.h.
Hi Andrew, On Wed, Jul 31, 2019 at 4:52 AM Andrew Morton <akpm@linux-foundation.org> wrote: > > On Mon, 29 Jul 2019 00:47:28 +0900 Masahiro Yamada <yamada.masahiro@socionext.com> wrote: > > > Add a header include guard just in case. > > > > Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > --- > > > > Looks like this file is unused at least in the kernel tree, > > but I am not it is OK to delete it. > > arch/alpha/boot/tools/objstrip.c includes it but I don't think it's > actually needed. Yes, it would be nice to kill coff.h. After some consideration, I think it is better to keep it until we dump the alpha support entirely. The following line in arch/alpha/boot/tools/objstrip.c references a macro in <linux/coff.h>: if (!(aout->fh.f_flags & COFF_F_EXEC)) { I was not able to build objstrip.c anyway, but I think it is better to keep the can of worms closed for now. Could you apply this as-is please? My motivation is to allow Kbuild to detect missing include guard: https://patchwork.kernel.org/patch/11063011/ Before I enable this checker, I want to fix as many headers as possible. -- Best Regards Masahiro Yamada
diff --git a/include/uapi/linux/coff.h b/include/uapi/linux/coff.h index e4a79f80b9a0..ab5c7e847eed 100644 --- a/include/uapi/linux/coff.h +++ b/include/uapi/linux/coff.h @@ -11,6 +11,9 @@ more information about COFF, then O'Reilly has a very excellent book. */ +#ifndef _UAPI_LINUX_COFF_H +#define _UAPI_LINUX_COFF_H + #define E_SYMNMLEN 8 /* Number of characters in a symbol name */ #define E_FILNMLEN 14 /* Number of characters in a file name */ #define E_DIMNUM 4 /* Number of array dimensions in auxiliary entry */ @@ -350,3 +353,5 @@ struct COFF_reloc { /* For new sections we haven't heard of before */ #define COFF_DEF_SECTION_ALIGNMENT 4 + +#endif /* _UAPI_LINUX_COFF_H */
Add a header include guard just in case. Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> --- Looks like this file is unused at least in the kernel tree, but I am not it is OK to delete it. I am just adding the include guard for the header compile-testing. include/uapi/linux/coff.h | 5 +++++ 1 file changed, 5 insertions(+) -- 2.17.1