From patchwork Mon Aug 12 17:29:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 171104 Delivered-To: patch@linaro.org Received: by 2002:a92:d204:0:0:0:0:0 with SMTP id y4csp3120220ily; Mon, 12 Aug 2019 10:31:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqxPtpgcBA5ztgFM3cGHvYzYOmJL+0NGyyHIwesBJa29N6cn+/HoaNdYo7kVWUZSyD7qSb79 X-Received: by 2002:a6b:720e:: with SMTP id n14mr37551547ioc.139.1565631106549; Mon, 12 Aug 2019 10:31:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1565631106; cv=none; d=google.com; s=arc-20160816; b=ppoMaAcOpM64GFaUxJfJuupFc2gUpRW7czovNa8lj4KeYm1kLMGJQoAB3EgWM1LCXv M5lJOO+qbshd75+fv9N1N4r7zh/Wj7J9/5nEn8RUpuUM8+2Bywgxav7vWfiZjoqfF3D2 OmVE2xdH3cwLhzvt8G2WHPPJxPOi8kalyz2FHTgUwfgccEGjIuiiHM8Wj5en7VaxrPJG Lp8+Dyt3P/v9nWhdWh9pJLyrzuhShYLIU0+zp+KfqGo7e59j2sI5pwZoxcAR4C7PajJ3 z/WN9m873GDo3t5PJMYCH9Ja3K0rfHfq1G3AriIRUyKqnNwUwjtLQZIvD3lK5sKaZQPx B9ZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version:cc :list-subscribe:list-help:list-post:list-unsubscribe:list-id :precedence:subject:references:in-reply-to:message-id:date:to:from; bh=kj7gDaBmW9ApnLebCTiEuDAfZEM4LqTFeRGWXdqnJxk=; b=chBbErb5q1XjknikunR30oKJTi/hBQ30FeWSoj8PR0vS8rrk5i7/b4mLyo/fk0IAEh N50qYCAK/0paf/8Gw+U0ZxJPcFEgXMlRJaRhS2YkbGQQvpamssUIn8h8J0MwrR6W+Aru WNrbKOcStlCvvYouHYVHPCodmQKKKvy6J0A3vIcd4WnzW/8bELnduXbsGL1CVG3v4Npf 0lCL0yE7hY1vqSfFJB7B+u9WS+3b8UYubbQMAsK5gC+QzvT9jVssMbwPcFINDQ3RJST7 BJ0o5DP4yar1lNklwRTI2Ydo20ibrhM3YG973CM8rxBMEBUlnYAw71Its5IXmmBP/FG4 JMtg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Return-Path: Received: from lists.xenproject.org (lists.xenproject.org. [192.237.175.120]) by mx.google.com with ESMTPS id u21si20754815iob.131.2019.08.12.10.31.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 12 Aug 2019 10:31:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) client-ip=192.237.175.120; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of xen-devel-bounces@lists.xenproject.org designates 192.237.175.120 as permitted sender) smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hxE9V-0006hP-21; Mon, 12 Aug 2019 17:30:37 +0000 Received: from [172.99.69.81] (helo=us1-rack-iad1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1hxE9T-0006hB-Kf for xen-devel@lists.xenproject.org; Mon, 12 Aug 2019 17:30:35 +0000 X-Inumbo-ID: e4367596-bd26-11e9-883b-d7d30b8f119f Received: from foss.arm.com (unknown [217.140.110.172]) by us1-rack-iad1.inumbo.com (Halon) with ESMTP id e4367596-bd26-11e9-883b-d7d30b8f119f; Mon, 12 Aug 2019 17:30:34 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 788301993; Mon, 12 Aug 2019 10:30:34 -0700 (PDT) Received: from e108454-lin.cambridge.arm.com (e108454-lin.cambridge.arm.com [10.1.196.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C6E133F706; Mon, 12 Aug 2019 10:30:33 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xenproject.org Date: Mon, 12 Aug 2019 18:29:59 +0100 Message-Id: <20190812173019.11956-9-julien.grall@arm.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20190812173019.11956-1-julien.grall@arm.com> References: <20190812173019.11956-1-julien.grall@arm.com> Subject: [Xen-devel] [PATCH v3 08/28] xen/arm32: head: Add a macro to move an immediate constant into a 32-bit register X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Julien Grall , Stefano Stabellini , Volodymyr Babchuk MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" The current boot code is using the pattern ldr rX, =... to move an immediate constant into a 32-bit register. This pattern implies to load the immediate constant from a literal pool, meaning a memory access will be performed. The memory access can be avoided by using movw/movt instructions. A new macro is introduced to move an immediate constant into a 32-bit register without a memory load. Follow-up patches will make use of it. Signed-off-by: Julien Grall Acked-by: Stefano Stabellini --- Changes in v3: - Add Stefano's acked-by Changes in v2: - Patch added --- xen/arch/arm/arm32/head.S | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/xen/arch/arm/arm32/head.S b/xen/arch/arm/arm32/head.S index 18ded49a04..99f4af18d8 100644 --- a/xen/arch/arm/arm32/head.S +++ b/xen/arch/arm/arm32/head.S @@ -37,6 +37,15 @@ #endif /* + * Move an immediate constant into a 32-bit register using movw/movt + * instructions. + */ +.macro mov_w reg, word + movw \reg, #:lower16:\word + movt \reg, #:upper16:\word +.endm + +/* * Common register usage in this file: * r0 - * r1 -