| Message ID | 20190814104131.20190-8-mark.rutland@arm.com |
|---|---|
| State | New |
| Headers | show |
| Series | kthread detection cleanup | expand |
diff --git a/arch/x86/events/intel/lbr.c b/arch/x86/events/intel/lbr.c index 6f814a27416b..ed2b7e57a249 100644 --- a/arch/x86/events/intel/lbr.c +++ b/arch/x86/events/intel/lbr.c @@ -857,7 +857,7 @@ static int branch_type(unsigned long from, unsigned long to, int abort) * can happen if measuring at the user level only * and we interrupt in a kernel thread, e.g., idle. */ - if (!current->mm) + if (is_kthread(current)) return X86_BR_NONE; /* may fail if text not present */
The x86 lbr branch_type() functions looks at current->mm, apparently to determine whether the thread is a kthread without any valid user context. In general, a non-NULL current->mm doesn't imply that current is a kthread, as kthreads can install an mm via use_mm(), and so it's preferable to use is_kthread() to determine whether a thread is a kthread. For consistency, let's use is_kthread() here. Signed-off-by: Mark Rutland <mark.rutland@arm.com> Cc: Andi Kleen <ak@linux.intel.com> Cc: Ingo Molnar <mingo@kernel.org> Cc: Kan Liang <kan.liang@intel.com> Cc: Peter Zijlstra <peterz@infradead.org> --- arch/x86/events/intel/lbr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.11.0