| Message ID | 20190814125012.8700-4-vkoul@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | None | expand |
Quoting Vinod Koul (2019-08-14 05:49:53) > Signed-off-by: Vinod Koul <vkoul@kernel.org> > --- Add some commit text? Or just squash with the first patch? Not sure why it's a different commit. > arch/arm64/boot/dts/qcom/sm8150.dtsi | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi > index cd9fcadaeacb..5f2f21270e2d 100644 > --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi > @@ -189,6 +189,21 @@ > }; > }; > > + tlmm: pinctrl@3100000 { > + compatible = "qcom,sm8150-pinctrl"; > + reg = <0x03100000 0x300000>, > + <0x03500000 0x300000>, > + <0x03900000 0x300000>, > + <0x03D00000 0x300000>; Please don't use capitalized hex characters. > + reg-names = "west", "east", "north", "south"; > + interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>; > + gpio-ranges = <&tlmm 0 0 175>; > + gpio-controller; > + #gpio-cells = <2>; > + interrupt-controller; > + #interrupt-cells = <2>; > + }; > +
On 14-08-19, 10:01, Stephen Boyd wrote: > Quoting Vinod Koul (2019-08-14 05:49:53) > > Signed-off-by: Vinod Koul <vkoul@kernel.org> > > --- > > Add some commit text? Or just squash with the first patch? Not sure why > it's a different commit. > > > arch/arm64/boot/dts/qcom/sm8150.dtsi | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi > > index cd9fcadaeacb..5f2f21270e2d 100644 > > --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi > > @@ -189,6 +189,21 @@ > > }; > > }; > > > > + tlmm: pinctrl@3100000 { > > + compatible = "qcom,sm8150-pinctrl"; > > + reg = <0x03100000 0x300000>, > > + <0x03500000 0x300000>, > > + <0x03900000 0x300000>, > > + <0x03D00000 0x300000>; > > Please don't use capitalized hex characters. Sure, this seems to be only instance where this crept in. Fixed now -- ~Vinod
diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi index cd9fcadaeacb..5f2f21270e2d 100644 --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi @@ -189,6 +189,21 @@ }; }; + tlmm: pinctrl@3100000 { + compatible = "qcom,sm8150-pinctrl"; + reg = <0x03100000 0x300000>, + <0x03500000 0x300000>, + <0x03900000 0x300000>, + <0x03D00000 0x300000>; + reg-names = "west", "east", "north", "south"; + interrupts = <GIC_SPI 208 IRQ_TYPE_LEVEL_HIGH>; + gpio-ranges = <&tlmm 0 0 175>; + gpio-controller; + #gpio-cells = <2>; + interrupt-controller; + #interrupt-cells = <2>; + }; + intc: interrupt-controller@17a00000 { compatible = "arm,gic-v3"; interrupt-controller;
Signed-off-by: Vinod Koul <vkoul@kernel.org> --- arch/arm64/boot/dts/qcom/sm8150.dtsi | 15 +++++++++++++++ 1 file changed, 15 insertions(+) -- 2.20.1