diff mbox series

selftests: bpf: install files test_xdp_vlan.sh

Message ID 20190820134121.25728-1-anders.roxell@linaro.org
State Accepted
Commit 3035bb72ee47d494c041465b4add9c6407c832ed
Headers show
Series selftests: bpf: install files test_xdp_vlan.sh | expand

Commit Message

Anders Roxell Aug. 20, 2019, 1:41 p.m. UTC
When ./test_xdp_vlan_mode_generic.sh runs it complains that it can't
find file test_xdp_vlan.sh.

 # selftests: bpf: test_xdp_vlan_mode_generic.sh
 # ./test_xdp_vlan_mode_generic.sh: line 9: ./test_xdp_vlan.sh: No such
 file or directory

Rework so that test_xdp_vlan.sh gets installed, added to the variable
TEST_PROGS_EXTENDED.

Fixes: d35661fcf95d ("selftests/bpf: add wrapper scripts for test_xdp_vlan.sh")
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>

---
 tools/testing/selftests/bpf/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.20.1

Comments

Jesper Dangaard Brouer Aug. 20, 2019, 2:07 p.m. UTC | #1
On Tue, 20 Aug 2019 15:41:21 +0200
Anders Roxell <anders.roxell@linaro.org> wrote:

> When ./test_xdp_vlan_mode_generic.sh runs it complains that it can't

> find file test_xdp_vlan.sh.

> 

>  # selftests: bpf: test_xdp_vlan_mode_generic.sh

>  # ./test_xdp_vlan_mode_generic.sh: line 9: ./test_xdp_vlan.sh: No such

>  file or directory

> 

> Rework so that test_xdp_vlan.sh gets installed, added to the variable

> TEST_PROGS_EXTENDED.

> 

> Fixes: d35661fcf95d ("selftests/bpf: add wrapper scripts for test_xdp_vlan.sh")

> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>

> ---


Thanks for catching this!

Acked-by: Jesper Dangaard Brouer <jbrouer@redhat.com>


>  tools/testing/selftests/bpf/Makefile | 3 ++-

>  1 file changed, 2 insertions(+), 1 deletion(-)

> 

> diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile

> index 1faad0c3c3c9..d7968e20463c 100644

> --- a/tools/testing/selftests/bpf/Makefile

> +++ b/tools/testing/selftests/bpf/Makefile

> @@ -68,7 +68,8 @@ TEST_PROGS := test_kmod.sh \

>  TEST_PROGS_EXTENDED := with_addr.sh \

>  	with_tunnels.sh \

>  	tcp_client.py \

> -	tcp_server.py

> +	tcp_server.py \

> +	test_xdp_vlan.sh

>  

>  # Compile but not part of 'make run_tests'

>  TEST_GEN_PROGS_EXTENDED = test_libbpf_open test_sock_addr test_skb_cgroup_id_user \




-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer
Daniel Borkmann Aug. 21, 2019, 3:11 p.m. UTC | #2
On 8/20/19 3:41 PM, Anders Roxell wrote:
> When ./test_xdp_vlan_mode_generic.sh runs it complains that it can't

> find file test_xdp_vlan.sh.

> 

>   # selftests: bpf: test_xdp_vlan_mode_generic.sh

>   # ./test_xdp_vlan_mode_generic.sh: line 9: ./test_xdp_vlan.sh: No such

>   file or directory

> 

> Rework so that test_xdp_vlan.sh gets installed, added to the variable

> TEST_PROGS_EXTENDED.

> 

> Fixes: d35661fcf95d ("selftests/bpf: add wrapper scripts for test_xdp_vlan.sh")

> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>


Applied, thanks!
diff mbox series

Patch

diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
index 1faad0c3c3c9..d7968e20463c 100644
--- a/tools/testing/selftests/bpf/Makefile
+++ b/tools/testing/selftests/bpf/Makefile
@@ -68,7 +68,8 @@  TEST_PROGS := test_kmod.sh \
 TEST_PROGS_EXTENDED := with_addr.sh \
 	with_tunnels.sh \
 	tcp_client.py \
-	tcp_server.py
+	tcp_server.py \
+	test_xdp_vlan.sh
 
 # Compile but not part of 'make run_tests'
 TEST_GEN_PROGS_EXTENDED = test_libbpf_open test_sock_addr test_skb_cgroup_id_user \