| Message ID | 20190823071428.6155-1-linus.walleij@linaro.org |
|---|---|
| State | Accepted |
| Commit | acff2f86b195653a9487fe3dbdbc821d77eff54a |
| Headers | show |
| Series | drm/sti: Include the right header | expand |
Le ven. 23 août 2019 à 09:14, Linus Walleij <linus.walleij@linaro.org> a écrit : > > The sti_hdmi.c file include <linux/of_gpio.h> despite not even > using any GPIOs. > > What it does use is devm_ioremap_nocache() which comes from > <linux/io.h> implicitly by including that header. > > Fix this up by including the right header instead. Applied on drm-misc-next, Thanks Benjamin > > Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org> > Cc: Vincent Abriou <vincent.abriou@st.com> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > drivers/gpu/drm/sti/sti_hdmi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c > index f03d617edc4c..4f1aaf222cb0 100644 > --- a/drivers/gpu/drm/sti/sti_hdmi.c > +++ b/drivers/gpu/drm/sti/sti_hdmi.c > @@ -9,7 +9,7 @@ > #include <linux/debugfs.h> > #include <linux/hdmi.h> > #include <linux/module.h> > -#include <linux/of_gpio.h> > +#include <linux/io.h> > #include <linux/platform_device.h> > #include <linux/reset.h> > > -- > 2.21.0 >
diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c index f03d617edc4c..4f1aaf222cb0 100644 --- a/drivers/gpu/drm/sti/sti_hdmi.c +++ b/drivers/gpu/drm/sti/sti_hdmi.c @@ -9,7 +9,7 @@ #include <linux/debugfs.h> #include <linux/hdmi.h> #include <linux/module.h> -#include <linux/of_gpio.h> +#include <linux/io.h> #include <linux/platform_device.h> #include <linux/reset.h>
The sti_hdmi.c file include <linux/of_gpio.h> despite not even using any GPIOs. What it does use is devm_ioremap_nocache() which comes from <linux/io.h> implicitly by including that header. Fix this up by including the right header instead. Cc: Benjamin Gaignard <benjamin.gaignard@linaro.org> Cc: Vincent Abriou <vincent.abriou@st.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- drivers/gpu/drm/sti/sti_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)