| Message ID | 20190828141610.9991-1-raj.khem@gmail.com |
|---|---|
| State | Accepted |
| Commit | 98625eb6c501d74d18e728a8b34e9719c7011f1b |
| Headers | show |
| Series | [oe,meta-oe,V2] libgpiod: nherit python3native unconditionally | expand |
diff --git a/meta-oe/recipes-support/libgpiod/libgpiod_1.4.1.bb b/meta-oe/recipes-support/libgpiod/libgpiod_1.4.1.bb index 756b143ef7..d559028989 100644 --- a/meta-oe/recipes-support/libgpiod/libgpiod_1.4.1.bb +++ b/meta-oe/recipes-support/libgpiod/libgpiod_1.4.1.bb @@ -12,7 +12,8 @@ PACKAGECONFIG[cxx] = "--enable-bindings-cxx,--disable-bindings-cxx" PACKAGECONFIG[tests] = "--enable-tests,--disable-tests,kmod udev" PACKAGECONFIG[python3] = "--enable-bindings-python,--disable-bindings-python,python3" -inherit ${@bb.utils.contains('PACKAGECONFIG', 'python3', 'python3native', '', d)} + +inherit python3native PACKAGES =+ "${PN}-python" FILES_${PN}-python = "${PYTHON_SITEPACKAGES_DIR}"
this recipe inherits python3native class conditionally, this condition depends on a given packageconfig, however inherit ${VAR} syntax requires VAR to be evaluated before inheriting it, therefore if someone appends python3 to packageconfig via a bbappend, then the packageconfig will become effective and add --enable-bindings-python to configure but inherit wont evaluate correctly since the expression adding to packageconfig PACKAGECONFIG_append = " python3" will be coming _after_ the inherit, and the builds will fail e.g. | ../../../libgpiod-1.3/bindings/python/gpiodmodule.c:8:10: fatal error: Python.h: No such file or directory | #include <Python.h> This will still mean that python3native is always inherited but the effective configure option will be --disable-bindings-python and that will do the right thing See. https://github.com/openembedded/meta-openembedded/issues/140 Signed-off-by: Khem Raj <raj.khem@gmail.com> --- v2: Inherit python3native unconditionally meta-oe/recipes-support/libgpiod/libgpiod_1.4.1.bb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.23.0 -- _______________________________________________ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel