| Message ID | 20190904181009.8374-2-raj.khem@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] python3: Expose PYTHON_BINABI in global config metadata | expand |
On Wed, 4 Sep 2019 at 20:10, Khem Raj <raj.khem@gmail.com> wrote: > +export PYTHON_LIBRARY="${STAGING_LIBDIR}/${PYTHON_BINABI}" > +export PYTHON_INCLUDE_DIR="${STAGING_INCDIR}/${PYTHON_BINABI} > You need to explain why this is needed. Where are these variables used? Also, python3-dir.bbclass already has all the needed settings, so please use it. Alex <div dir="ltr"><div dir="ltr">On Wed, 4 Sep 2019 at 20:10, Khem Raj <<a href="mailto:raj.khem@gmail.com">raj.khem@gmail.com</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">+export PYTHON_LIBRARY="${STAGING_LIBDIR}/${PYTHON_BINABI}"<br> +export PYTHON_INCLUDE_DIR="${STAGING_INCDIR}/${PYTHON_BINABI}<br></blockquote><div><br></div><div>You need to explain why this is needed. Where are these variables used?</div><div><br></div><div> Also, python3-dir.bbclass already has all the needed settings, so please use it.</div><div><br></div><div>Alex<br></div></div></div> -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
On Wed, Sep 4, 2019 at 11:17 AM Alexander Kanavin <alex.kanavin@gmail.com> wrote: > > On Wed, 4 Sep 2019 at 20:10, Khem Raj <raj.khem@gmail.com> wrote: >> >> +export PYTHON_LIBRARY="${STAGING_LIBDIR}/${PYTHON_BINABI}" >> +export PYTHON_INCLUDE_DIR="${STAGING_INCDIR}/${PYTHON_BINABI} > > > You need to explain why this is needed. Where are these variables used? > > Also, python3-dir.bbclass already has all the needed settings, so please use it. > sent v2 > Alex -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
diff --git a/meta/classes/python3native.bbclass b/meta/classes/python3native.bbclass index a3acaf61bb..b056378f69 100644 --- a/meta/classes/python3native.bbclass +++ b/meta/classes/python3native.bbclass @@ -9,6 +9,9 @@ DEPENDS_append = " python3-native " export STAGING_INCDIR export STAGING_LIBDIR +export PYTHON_LIBRARY="${STAGING_LIBDIR}/${PYTHON_BINABI}" +export PYTHON_INCLUDE_DIR="${STAGING_INCDIR}/${PYTHON_BINABI}" + export _PYTHON_SYSCONFIGDATA_NAME="_sysconfigdata" # suppress host user's site-packages dirs.
Signed-off-by: Khem Raj <raj.khem@gmail.com> --- meta/classes/python3native.bbclass | 3 +++ 1 file changed, 3 insertions(+) -- 2.23.0 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core